Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57990/?format=api
{ "id": 57990, "url": "http://patchwork.dpdk.org/api/patches/57990/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190827010122.15517-1-chenxux.di@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190827010122.15517-1-chenxux.di@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190827010122.15517-1-chenxux.di@intel.com", "date": "2019-08-27T01:01:22", "name": "[v1] drivers/net: release port upon close", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a9944930ed84ce61aa93da56abc5c5cb3948db19", "submitter": { "id": 1409, "url": "http://patchwork.dpdk.org/api/people/1409/?format=api", "name": "Chenxu Di", "email": "chenxux.di@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190827010122.15517-1-chenxux.di@intel.com/mbox/", "series": [ { "id": 6126, "url": "http://patchwork.dpdk.org/api/series/6126/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6126", "date": "2019-08-27T01:01:22", "name": "[v1] drivers/net: release port upon close", "version": 1, "mbox": "http://patchwork.dpdk.org/series/6126/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/57990/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/57990/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 51F791C039;\n\tTue, 27 Aug 2019 03:43:42 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id AC08E1C038\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 03:43:39 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Aug 2019 18:43:38 -0700", "from intel.sh.intel.com ([10.239.255.133])\n\tby fmsmga002.fm.intel.com with ESMTP; 26 Aug 2019 18:43:37 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,435,1559545200\"; d=\"scan'208\";a=\"209572884\"", "From": "chenxux.di@intel.com", "To": "dev@dpdk.org", "Cc": "Di ChenxuX <chenxux.di@intel.com>", "Date": "Tue, 27 Aug 2019 01:01:22 +0000", "Message-Id": "<20190827010122.15517-1-chenxux.di@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v1] drivers/net: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Di ChenxuX <chenxux.di@intel.com>\n\nSet RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private\nresources for the port can be freed by rte_eth_dev_close().\nThis patch cover all the intel drivers\n\nSigned-off-by: Di ChenxuX <chenxux.di@intel.com>\n---\n drivers/net/e1000/igb_ethdev.c | 5 +++++\n drivers/net/fm10k/fm10k_ethdev.c | 5 +++++\n drivers/net/i40e/i40e_ethdev.c | 5 +++++\n drivers/net/ice/ice_ethdev.c | 5 +++++\n drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++\n 5 files changed, 25 insertions(+)", "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex fec2b4289..fe785d1d7 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -843,6 +843,11 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)\n \trte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr,\n \t\t\tð_dev->data->mac_addrs[0]);\n \n+\t/* Pass the information to the rte_eth_dev_close() that it should also\n+\t * release the private port resources.\n+\t */\n+\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \t/* initialize the vfta */\n \tmemset(shadow_vfta, 0, sizeof(*shadow_vfta));\n \ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex db4d72129..b5a427c7b 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -3103,6 +3103,11 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)\n \t\t&dev->data->mac_addrs[0]);\n \t}\n \n+\t/* Pass the information to the rte_eth_dev_close() that it should also\n+\t * release the private port resources.\n+\t */\n+\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \t/* Reset the hw statistics */\n \tfm10k_stats_reset(dev);\n \ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 4e40b7ab5..a0536f14c 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1520,6 +1520,11 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused)\n \trte_ether_addr_copy((struct rte_ether_addr *)hw->mac.perm_addr,\n \t\t\t\t\t&dev->data->mac_addrs[0]);\n \n+\t/* Pass the information to the rte_eth_dev_close() that it should also\n+\t * release the private port resources.\n+\t */\n+\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \t/* Init dcb to sw mode by default */\n \tret = i40e_dcb_init_configure(dev, TRUE);\n \tif (ret != I40E_SUCCESS) {\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 44a14cb8a..476c768ee 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -1488,6 +1488,11 @@ ice_dev_init(struct rte_eth_dev *dev)\n \t\tgoto err_init_mac;\n \t}\n \n+\t/* Pass the information to the rte_eth_dev_close() that it should also\n+\t * release the private port resources.\n+\t */\n+\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \tret = ice_res_pool_init(&pf->msix_pool, 1,\n \t\t\t\thw->func_caps.common_cap.num_msix_vectors - 1);\n \tif (ret) {\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 03fc1f717..3e2b537ec 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1245,6 +1245,11 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \t\treturn -ENOMEM;\n \t}\n \n+\t/* Pass the information to the rte_eth_dev_close() that it should also\n+\t * release the private port resources.\n+\t */\n+\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \t/* initialize the vfta */\n \tmemset(shadow_vfta, 0, sizeof(*shadow_vfta));\n \n", "prefixes": [ "v1" ] }