Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 58036,
    "url": "http://patchwork.dpdk.org/api/patches/58036/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1566934217-23824-2-git-send-email-nitin.katiyar@ericsson.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1566934217-23824-2-git-send-email-nitin.katiyar@ericsson.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1566934217-23824-2-git-send-email-nitin.katiyar@ericsson.com",
    "date": "2019-08-27T19:30:17",
    "name": "[2/2] eal: DPDK init doesn't fail even if device probe fails.",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "d91a4f78ffbcdb3393b684d2dbed5632eb4dcbef",
    "submitter": {
        "id": 976,
        "url": "http://patchwork.dpdk.org/api/people/976/?format=api",
        "name": "Nitin Katiyar",
        "email": "nitin.katiyar@ericsson.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1566934217-23824-2-git-send-email-nitin.katiyar@ericsson.com/mbox/",
    "series": [
        {
            "id": 6136,
            "url": "http://patchwork.dpdk.org/api/series/6136/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6136",
            "date": "2019-08-27T19:30:16",
            "name": "[1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail.",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/6136/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/58036/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/58036/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CBC631C08E;\n\tTue, 27 Aug 2019 13:30:11 +0200 (CEST)",
            "from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58])\n\tby dpdk.org (Postfix) with ESMTP id 9FBBF1C035\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 13:30:09 +0200 (CEST)",
            "from ESESBMB501.ericsson.se (Unknown_Domain [153.88.183.114])\n\tby sessmg22.ericsson.net (Symantec Mail Security) with SMTP id\n\tDF.E9.02815.144156D5; Tue, 27 Aug 2019 13:30:09 +0200 (CEST)",
            "from ESESSMB502.ericsson.se (153.88.183.163) by\n\tESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1713.5; Tue, 27 Aug 2019 13:30:08 +0200",
            "from ESESSHC002.ericsson.se (153.88.183.24) by\n\tESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server\n\t(version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256) id\n\t15.1.1713.5 via Frontend Transport; Tue, 27 Aug 2019 13:30:08 +0200",
            "from ESGSCHC006.ericsson.se (146.11.116.83) by\n\tESESSHC002.ericsson.se (153.88.183.24) with Microsoft SMTP Server\n\t(TLS) id 14.3.439.0; Tue, 27 Aug 2019 13:30:08 +0200",
            "from localhost.localdomain (146.11.116.127) by\n\tsmtps-ao.internal.ericsson.com (146.11.116.83) with Microsoft SMTP\n\tServer (TLS) id 14.3.439.0; Tue, 27 Aug 2019 19:29:47 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801;\n\tc=relaxed/relaxed; \n\tq=dns/txt; i=@ericsson.com; t=1566905409; x=1569497409;\n\th=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=/LVnbR/3hD2Jiq2MDHYvcYw8amApVhMQT65sblasDx4=;\n\tb=W13cKc4M2fKCyqq3GLV+Ach+kxeh0UwdbJzFo/QOhipwl+wKRzpNVa1VlqsfUk5v\n\tDflgwqATv68bdfEslyaAo6H2lRsScRIV9iABwOHMsOixEgwZq4LGvLwIdAgkeggm\n\tbKC+KKJ9X7XOJkfRTHIaZ3nE1lVRiV4f6/vAlLgCQ6U=;",
        "X-AuditID": "c1b4fb3a-681ff70000000aff-82-5d6514415475",
        "From": "Nitin Katiyar <nitin.katiyar@ericsson.com>",
        "To": "<dev@dpdk.org>",
        "CC": "Nitin Katiyar <nitin.katiyar@ericsson.com>",
        "Date": "Wed, 28 Aug 2019 01:00:17 +0530",
        "Message-ID": "<1566934217-23824-2-git-send-email-nitin.katiyar@ericsson.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "In-Reply-To": "<1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com>",
        "References": "<1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[146.11.116.127]",
        "Subject": "[dpdk-dev] [PATCH 2/2] eal: DPDK init doesn't fail even if device\n\tprobe fails.",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "rte_bus_probe() doesn't return error. As a result rte_eal_init()\ndoesn't catch this error and thus making dpdk initialization\nsuccessful despite probe failing for devices.\n\nThis patch returns error if probe fails for any of device.\n\nSigned-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com>\n---\n lib/librte_eal/common/eal_common_bus.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c\nindex baa5b53..1721179 100644\n--- a/lib/librte_eal/common/eal_common_bus.c\n+++ b/lib/librte_eal/common/eal_common_bus.c\n@@ -70,16 +70,20 @@\n \t\t}\n \n \t\tret = bus->probe();\n-\t\tif (ret)\n+\t\tif (ret) {\n \t\t\tRTE_LOG(ERR, EAL, \"Bus (%s) probe failed.\\n\",\n \t\t\t\tbus->name);\n+\t\t\treturn ret;\n+\t\t}\n \t}\n \n \tif (vbus) {\n \t\tret = vbus->probe();\n-\t\tif (ret)\n+\t\tif (ret) {\n \t\t\tRTE_LOG(ERR, EAL, \"Bus (%s) probe failed.\\n\",\n \t\t\t\tvbus->name);\n+\t\t\treturn ret;\n+\t\t}\n \t}\n \n \treturn 0;\n",
    "prefixes": [
        "2/2"
    ]
}