Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58219/?format=api
http://patchwork.dpdk.org/api/patches/58219/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190829080000.20806-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190829080000.20806-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190829080000.20806-2-maxime.coquelin@redhat.com", "date": "2019-08-29T07:59:46", "name": "[01/15] vhost: remove vhost kernel header inclusion", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "06d9137497580b9ab8da315ab0b1451c781a0627", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190829080000.20806-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 6163, "url": "http://patchwork.dpdk.org/api/series/6163/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6163", "date": "2019-08-29T07:59:45", "name": "Introduce Virtio vDPA driver", "version": 1, "mbox": "http://patchwork.dpdk.org/series/6163/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/58219/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/58219/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6FF571D37D;\n\tThu, 29 Aug 2019 10:00:22 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 61A081D172;\n\tThu, 29 Aug 2019 10:00:21 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 97D16308218D;\n\tThu, 29 Aug 2019 08:00:20 +0000 (UTC)", "from localhost.localdomain (ovpn-112-52.ams2.redhat.com\n\t[10.36.112.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1294A5D713;\n\tThu, 29 Aug 2019 08:00:17 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "tiwei.bie@intel.com, zhihong.wang@intel.com, amorenoz@redhat.com,\n\txiao.w.wang@intel.com, dev@dpdk.org, jfreimann@redhat.com", "Cc": "stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 29 Aug 2019 09:59:46 +0200", "Message-Id": "<20190829080000.20806-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190829080000.20806-1-maxime.coquelin@redhat.com>", "References": "<20190829080000.20806-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.47]); Thu, 29 Aug 2019 08:00:20 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 01/15] vhost: remove vhost kernel header inclusion", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is preliminary rework for virtio-vdpa driver, in\norder to avoid conflicts with Virtio PMD headers.\n\nGenerally, I think it is better not to include kernel\nheaders in RTE headers, especially in the case of Vhost\nand Virtio which just re-use the kernel definitions,\nand has no runtime dependencies.\n\nIn order to not break IFC driver build, the vhost kernel\nheader is now included directly in the driver.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/ifc/ifcvf_vdpa.c | 1 +\n lib/librte_vhost/rte_vdpa.h | 1 -\n lib/librte_vhost/rte_vhost.h | 9 ++++-----\n 3 files changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c\nindex 8de9ef199..40cb15ca8 100644\n--- a/drivers/net/ifc/ifcvf_vdpa.c\n+++ b/drivers/net/ifc/ifcvf_vdpa.c\n@@ -7,6 +7,7 @@\n #include <fcntl.h>\n #include <sys/ioctl.h>\n #include <sys/epoll.h>\n+#include <linux/vhost.h>\n #include <linux/virtio_net.h>\n #include <stdbool.h>\n \ndiff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h\nindex 9a3deb31d..69438210b 100644\n--- a/lib/librte_vhost/rte_vdpa.h\n+++ b/lib/librte_vhost/rte_vdpa.h\n@@ -14,7 +14,6 @@\n #include <stdbool.h>\n \n #include <rte_pci.h>\n-#include \"rte_vhost.h\"\n \n #define MAX_VDPA_NAME_LEN 128\n \ndiff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h\nindex 7fb172912..62d3c3c36 100644\n--- a/lib/librte_vhost/rte_vhost.h\n+++ b/lib/librte_vhost/rte_vhost.h\n@@ -20,11 +20,6 @@\n extern \"C\" {\n #endif\n \n-/* These are not C++-aware. */\n-#include <linux/vhost.h>\n-#include <linux/virtio_ring.h>\n-#include <linux/virtio_net.h>\n-\n #define RTE_VHOST_USER_CLIENT\t\t(1ULL << 0)\n #define RTE_VHOST_USER_NO_RECONNECT\t(1ULL << 1)\n #define RTE_VHOST_USER_DEQUEUE_ZERO_COPY\t(1ULL << 2)\n@@ -72,6 +67,10 @@ extern \"C\" {\n #define VHOST_USER_PROTOCOL_F_HOST_NOTIFIER 11\n #endif\n \n+#ifndef VHOST_F_LOG_ALL\n+#define VHOST_F_LOG_ALL\t\t\t26\n+#endif\n+\n /** Indicate whether protocol features negotiation is supported. */\n #ifndef VHOST_USER_F_PROTOCOL_FEATURES\n #define VHOST_USER_F_PROTOCOL_FEATURES\t30\n", "prefixes": [ "01/15" ] }{ "id": 58219, "url": "