Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 58623,
    "url": "http://patchwork.dpdk.org/api/patches/58623/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190905161421.55981-15-yong.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190905161421.55981-15-yong.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190905161421.55981-15-yong.liu@intel.com",
    "date": "2019-09-05T16:14:21",
    "name": "[v1,14/14] vhost: check whether disable software pre-fetch",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "62442431256efd3fb9fa43947a70bb84cd1bf865",
    "submitter": {
        "id": 17,
        "url": "http://patchwork.dpdk.org/api/people/17/?format=api",
        "name": "Marvin Liu",
        "email": "yong.liu@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patchwork.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190905161421.55981-15-yong.liu@intel.com/mbox/",
    "series": [
        {
            "id": 6248,
            "url": "http://patchwork.dpdk.org/api/series/6248/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6248",
            "date": "2019-09-05T16:14:07",
            "name": "vhost packed ring performance optimization",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/6248/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/58623/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/58623/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EAC1D1EF50;\n\tThu,  5 Sep 2019 10:35:02 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id C73121EE3C\n\tfor <dev@dpdk.org>; Thu,  5 Sep 2019 10:34:47 +0200 (CEST)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2019 01:34:47 -0700",
            "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.142])\n\tby fmsmga006.fm.intel.com with ESMTP; 05 Sep 2019 01:34:46 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.64,470,1559545200\"; d=\"scan'208\";a=\"383781649\"",
        "From": "Marvin Liu <yong.liu@intel.com>",
        "To": "tiwei.bie@intel.com,\n\tmaxime.coquelin@redhat.com,\n\tdev@dpdk.org",
        "Cc": "Marvin Liu <yong.liu@intel.com>",
        "Date": "Fri,  6 Sep 2019 00:14:21 +0800",
        "Message-Id": "<20190905161421.55981-15-yong.liu@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20190905161421.55981-1-yong.liu@intel.com>",
        "References": "<20190905161421.55981-1-yong.liu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v1 14/14] vhost: check whether disable software\n\tpre-fetch",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Disable software pre-fetch actions on Skylake and Cascadelake platforms.\nHardware can fetch needed data for vhost, additional software pre-fetch\nwill have impact on performance.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>",
    "diff": "diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile\nindex 8623e91c0..1d1423bdc 100644\n--- a/lib/librte_vhost/Makefile\n+++ b/lib/librte_vhost/Makefile\n@@ -16,6 +16,12 @@ CFLAGS += -I vhost_user\n CFLAGS += -fno-strict-aliasing\n LDLIBS += -lpthread\n \n+AVX512_SUPPORT=$(shell $(CC) -march=native -dM -E - </dev/null |grep AVX512F)\n+\n+ifneq ($(AVX512_SUPPORT),)\n+CFLAGS += -DDISABLE_SWPREFETCH\n+endif\n+\n ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)\n LDLIBS += -lnuma\n endif\ndiff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 554617292..7d9a8eda0 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -489,7 +489,9 @@ map_one_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\tif (unlikely(!desc_addr))\n \t\t\treturn -1;\n \n+#ifndef DISABLE_SWPREFETCH\n \t\trte_prefetch0((void *)(uintptr_t)desc_addr);\n+#endif\n \n \t\tbuf_vec[vec_id].buf_iova = desc_iova;\n \t\tbuf_vec[vec_id].buf_addr = desc_addr;\n@@ -1011,7 +1013,9 @@ virtio_dev_rx_split(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t */\n \trte_smp_rmb();\n \n+#ifndef DISABLE_SWPREFETCH\n \trte_prefetch0(&vq->avail->ring[vq->last_avail_idx & (vq->size - 1)]);\n+#endif\n \n \tfor (pkt_idx = 0; pkt_idx < count; pkt_idx++) {\n \t\tuint32_t pkt_len = pkts[pkt_idx]->pkt_len + dev->vhost_hlen;\n@@ -1110,10 +1114,12 @@ virtio_dev_rx_burst_packed(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t(len3 != descs[avail_idx + 3].len)))\n \t\treturn -1;\n \n+#ifndef DISABLE_SWPREFETCH\n \trte_prefetch0((void *)(uintptr_t)desc_addr);\n \trte_prefetch0((void *)(uintptr_t)desc_addr1);\n \trte_prefetch0((void *)(uintptr_t)desc_addr2);\n \trte_prefetch0((void *)(uintptr_t)desc_addr3);\n+#endif\n \n \thdr = (struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)desc_addr;\n \thdr1 = (struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)desc_addr1;\n@@ -1687,7 +1693,9 @@ virtio_dev_tx_split(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t */\n \trte_smp_rmb();\n \n+#ifndef DISABLE_SWPREFETCH\n \trte_prefetch0(&vq->avail->ring[vq->last_avail_idx & (vq->size - 1)]);\n+#endif\n \n \tVHOST_LOG_DEBUG(VHOST_DATA, \"(%d) %s\\n\", dev->vid, __func__);\n \n@@ -1872,10 +1880,12 @@ virtio_dev_tx_burst_packed(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \tif (ret)\n \t\treturn ret;\n \n+#ifndef DISABLE_SWPREFETCH\n \trte_prefetch0((void *)(uintptr_t)desc_addr[0]);\n \trte_prefetch0((void *)(uintptr_t)desc_addr[1]);\n \trte_prefetch0((void *)(uintptr_t)desc_addr[2]);\n \trte_prefetch0((void *)(uintptr_t)desc_addr[3]);\n+#endif\n \n \trte_memcpy(rte_pktmbuf_mtod_offset(pkts[0], void *, 0),\n \t\t(void *)(uintptr_t)(desc_addr[0] + buf_offset),\n",
    "prefixes": [
        "v1",
        "14/14"
    ]
}