Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58658/?format=api
http://patchwork.dpdk.org/api/patches/58658/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190905145315.19395-4-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190905145315.19395-4-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190905145315.19395-4-ferruh.yigit@intel.com", "date": "2019-09-05T14:53:08", "name": "[03/10] crypto/null: fix global variable multiple definitions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6cf18d1ddb71228dd5cff7dea33e4964d8e6c7c0", "submitter": { "id": 324, "url": "http://patchwork.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190905145315.19395-4-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 6259, "url": "http://patchwork.dpdk.org/api/series/6259/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6259", "date": "2019-09-05T14:53:05", "name": "fix global variable multiple definitions", "version": 1, "mbox": "http://patchwork.dpdk.org/series/6259/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/58658/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/58658/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 996941EFDD;\n\tThu, 5 Sep 2019 16:53:32 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id D66641EF5F;\n\tThu, 5 Sep 2019 16:53:24 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2019 07:53:24 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.223.78])\n\tby fmsmga008.fm.intel.com with ESMTP; 05 Sep 2019 07:53:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,470,1559545200\"; d=\"scan'208\";a=\"182846349\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Declan Doherty <declan.doherty@intel.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Thu, 5 Sep 2019 15:53:08 +0100", "Message-Id": "<20190905145315.19395-4-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "References": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 03/10] crypto/null: fix global variable multiple\n\tdefinitions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'null_logtype_driver' global variable is defined in a header file which\nwas causing multiple definitions of the variable, fixed it by moving it\nto the .c file.\n\nIssue has been detected by '-fno-common' gcc flag.\n\nFixes: 735b783d8c2b (\"crypto/null: add dynamic logging\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/crypto/null/null_crypto_pmd.c | 1 +\n drivers/crypto/null/null_crypto_pmd_private.h | 2 +-\n 2 files changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/crypto/null/null_crypto_pmd.c b/drivers/crypto/null/null_crypto_pmd.c\nindex d5e3064f2..f11636c5f 100644\n--- a/drivers/crypto/null/null_crypto_pmd.c\n+++ b/drivers/crypto/null/null_crypto_pmd.c\n@@ -10,6 +10,7 @@\n #include \"null_crypto_pmd_private.h\"\n \n static uint8_t cryptodev_driver_id;\n+int null_logtype_driver;\n \n /** verify and set session parameters */\n int\ndiff --git a/drivers/crypto/null/null_crypto_pmd_private.h b/drivers/crypto/null/null_crypto_pmd_private.h\nindex d7bfd9cc8..89c4345b6 100644\n--- a/drivers/crypto/null/null_crypto_pmd_private.h\n+++ b/drivers/crypto/null/null_crypto_pmd_private.h\n@@ -8,7 +8,7 @@\n #define CRYPTODEV_NAME_NULL_PMD\t\tcrypto_null\n /**< Null crypto PMD device name */\n \n-int null_logtype_driver;\n+extern int null_logtype_driver;\n \n #define NULL_LOG(level, fmt, ...) \\\n \trte_log(RTE_LOG_ ## level, null_logtype_driver, \\\n", "prefixes": [ "03/10" ] }{ "id": 58658, "url": "