Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58662/?format=api
{ "id": 58662, "url": "http://patchwork.dpdk.org/api/patches/58662/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190905145315.19395-8-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190905145315.19395-8-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190905145315.19395-8-ferruh.yigit@intel.com", "date": "2019-09-05T14:53:12", "name": "[07/10] compress/octeontx: fix global variable multiple definitions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "189bc51995e3fca818d62896a3ed18647ab05843", "submitter": { "id": 324, "url": "http://patchwork.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190905145315.19395-8-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 6259, "url": "http://patchwork.dpdk.org/api/series/6259/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6259", "date": "2019-09-05T14:53:05", "name": "fix global variable multiple definitions", "version": 1, "mbox": "http://patchwork.dpdk.org/series/6259/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/58662/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/58662/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E456A1F027;\n\tThu, 5 Sep 2019 16:53:40 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 8018A1EF5F;\n\tThu, 5 Sep 2019 16:53:30 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2019 07:53:29 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.223.78])\n\tby fmsmga008.fm.intel.com with ESMTP; 05 Sep 2019 07:53:28 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,470,1559545200\"; d=\"scan'208\";a=\"182846380\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Ashish Gupta <ashish.gupta@marvell.com>,\n\tFiona Trahe <fiona.trahe@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Thu, 5 Sep 2019 15:53:12 +0100", "Message-Id": "<20190905145315.19395-8-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "References": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 07/10] compress/octeontx: fix global variable\n\tmultiple definitions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'octtx_zip_logtype_driver' global variable is defined in a header file\nwhich was causing multiple definitions of the variable, fixed it by\nmoving it to the .c file.\n\nIssue has been detected by '-fno-common' gcc flag.\n\nFixes: 43e610bb8565 (\"compress/octeontx: introduce octeontx zip PMD\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/compress/octeontx/otx_zip.h | 2 +-\n drivers/compress/octeontx/otx_zip_pmd.c | 2 ++\n 2 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/compress/octeontx/otx_zip.h b/drivers/compress/octeontx/otx_zip.h\nindex 3abefd1dc..e43f7f5c3 100644\n--- a/drivers/compress/octeontx/otx_zip.h\n+++ b/drivers/compress/octeontx/otx_zip.h\n@@ -17,7 +17,7 @@\n \n #include <zip_regs.h>\n \n-int octtx_zip_logtype_driver;\n+extern int octtx_zip_logtype_driver;\n \n /* ZIP VF Control/Status registers (CSRs): */\n /* VF_BAR0: */\ndiff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_zip_pmd.c\nindex a1651b22e..9e00c8663 100644\n--- a/drivers/compress/octeontx/otx_zip_pmd.c\n+++ b/drivers/compress/octeontx/otx_zip_pmd.c\n@@ -11,6 +11,8 @@\n \n #include \"otx_zip.h\"\n \n+int octtx_zip_logtype_driver;\n+\n static const struct rte_compressdev_capabilities\n \t\t\t\tocttx_zip_pmd_capabilities[] = {\n \t{\t.algo = RTE_COMP_ALGO_DEFLATE,\n", "prefixes": [ "07/10" ] }