Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58895/?format=api
{ "id": 58895, "url": "http://patchwork.dpdk.org/api/patches/58895/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190906190510.11146-2-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190906190510.11146-2-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190906190510.11146-2-honnappa.nagarahalli@arm.com", "date": "2019-09-06T19:05:05", "name": "[v2,1/6] lib/ring: apis to support configurable element size", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1f82340af1df26d6b1e9b06f5e0809c7383fd8ec", "submitter": { "id": 1045, "url": "http://patchwork.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190906190510.11146-2-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 6316, "url": "http://patchwork.dpdk.org/api/series/6316/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6316", "date": "2019-09-06T19:05:04", "name": "lib/ring: templates to support custom element size", "version": 2, "mbox": "http://patchwork.dpdk.org/series/6316/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/58895/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/58895/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BD5821BE99;\n\tFri, 6 Sep 2019 21:06:00 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id EFD1B1BE97\n\tfor <dev@dpdk.org>; Fri, 6 Sep 2019 21:05:58 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D9E028;\n\tFri, 6 Sep 2019 12:05:58 -0700 (PDT)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n\t[10.118.12.34])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t4A0B23F59C; Fri, 6 Sep 2019 12:05:58 -0700 (PDT)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "olivier.matz@6wind.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, \n\tbruce.richardson@intel.com, pablo.de.lara.guarch@intel.com", "Cc": "dev@dpdk.org, pbhagavatula@marvell.com, jerinj@marvell.com,\n\tHonnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "Date": "Fri, 6 Sep 2019 14:05:05 -0500", "Message-Id": "<20190906190510.11146-2-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190906190510.11146-1-honnappa.nagarahalli@arm.com>", "References": "<20190828144614.25284-1-honnappa.nagarahalli@arm.com>\n\t<20190906190510.11146-1-honnappa.nagarahalli@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 1/6] lib/ring: apis to support configurable\n\telement size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Current APIs assume ring elements to be pointers. However, in many\nuse cases, the size can be different. The new APIs\nrte_ring_get_memsize_elem and rte_ring_create_elem help reduce code\nduplication while creating rte_ring templates.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/librte_ring/Makefile | 2 +-\n lib/librte_ring/meson.build | 3 ++\n lib/librte_ring/rte_ring.c | 34 +++++++++----\n lib/librte_ring/rte_ring.h | 72 ++++++++++++++++++++++++++++\n lib/librte_ring/rte_ring_version.map | 2 +\n 5 files changed, 104 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_ring/Makefile b/lib/librte_ring/Makefile\nindex 21a36770d..4c8410229 100644\n--- a/lib/librte_ring/Makefile\n+++ b/lib/librte_ring/Makefile\n@@ -6,7 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk\n # library name\n LIB = librte_ring.a\n \n-CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3\n+CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3 -DALLOW_EXPERIMENTAL_API\n LDLIBS += -lrte_eal\n \n EXPORT_MAP := rte_ring_version.map\ndiff --git a/lib/librte_ring/meson.build b/lib/librte_ring/meson.build\nindex ab8b0b469..74219840a 100644\n--- a/lib/librte_ring/meson.build\n+++ b/lib/librte_ring/meson.build\n@@ -6,3 +6,6 @@ sources = files('rte_ring.c')\n headers = files('rte_ring.h',\n \t\t'rte_ring_c11_mem.h',\n \t\t'rte_ring_generic.h')\n+\n+# rte_ring_create_elem and rte_ring_get_memsize_elem are experimental\n+allow_experimental_apis = true\ndiff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c\nindex d9b308036..879feb9f6 100644\n--- a/lib/librte_ring/rte_ring.c\n+++ b/lib/librte_ring/rte_ring.c\n@@ -46,23 +46,32 @@ EAL_REGISTER_TAILQ(rte_ring_tailq)\n \n /* return the size of memory occupied by a ring */\n ssize_t\n-rte_ring_get_memsize(unsigned count)\n+rte_ring_get_memsize_elem(unsigned count, size_t esize)\n {\n \tssize_t sz;\n \n \t/* count must be a power of 2 */\n \tif ((!POWEROF2(count)) || (count > RTE_RING_SZ_MASK )) {\n \t\tRTE_LOG(ERR, RING,\n-\t\t\t\"Requested size is invalid, must be power of 2, and \"\n-\t\t\t\"do not exceed the size limit %u\\n\", RTE_RING_SZ_MASK);\n+\t\t\t\"Requested number of elements is invalid, must be \"\n+\t\t\t\"power of 2, and do not exceed the limit %u\\n\",\n+\t\t\tRTE_RING_SZ_MASK);\n+\n \t\treturn -EINVAL;\n \t}\n \n-\tsz = sizeof(struct rte_ring) + count * sizeof(void *);\n+\tsz = sizeof(struct rte_ring) + count * esize;\n \tsz = RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE);\n \treturn sz;\n }\n \n+/* return the size of memory occupied by a ring */\n+ssize_t\n+rte_ring_get_memsize(unsigned count)\n+{\n+\treturn rte_ring_get_memsize_elem(count, sizeof(void *));\n+}\n+\n void\n rte_ring_reset(struct rte_ring *r)\n {\n@@ -114,10 +123,10 @@ rte_ring_init(struct rte_ring *r, const char *name, unsigned count,\n \treturn 0;\n }\n \n-/* create the ring */\n+/* create the ring for a given element size */\n struct rte_ring *\n-rte_ring_create(const char *name, unsigned count, int socket_id,\n-\t\tunsigned flags)\n+rte_ring_create_elem(const char *name, unsigned count, size_t esize,\n+\t\tint socket_id, unsigned flags)\n {\n \tchar mz_name[RTE_MEMZONE_NAMESIZE];\n \tstruct rte_ring *r;\n@@ -135,7 +144,7 @@ rte_ring_create(const char *name, unsigned count, int socket_id,\n \tif (flags & RING_F_EXACT_SZ)\n \t\tcount = rte_align32pow2(count + 1);\n \n-\tring_size = rte_ring_get_memsize(count);\n+\tring_size = rte_ring_get_memsize_elem(count, esize);\n \tif (ring_size < 0) {\n \t\trte_errno = ring_size;\n \t\treturn NULL;\n@@ -182,6 +191,15 @@ rte_ring_create(const char *name, unsigned count, int socket_id,\n \treturn r;\n }\n \n+/* create the ring */\n+struct rte_ring *\n+rte_ring_create(const char *name, unsigned count, int socket_id,\n+\t\tunsigned flags)\n+{\n+\treturn rte_ring_create_elem(name, count, sizeof(void *), socket_id,\n+\t\tflags);\n+}\n+\n /* free the ring */\n void\n rte_ring_free(struct rte_ring *r)\ndiff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h\nindex 2a9f768a1..bbc1202d3 100644\n--- a/lib/librte_ring/rte_ring.h\n+++ b/lib/librte_ring/rte_ring.h\n@@ -122,6 +122,29 @@ struct rte_ring {\n #define __IS_SC 1\n #define __IS_MC 0\n \n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n+ * Calculate the memory size needed for a ring with given element size\n+ *\n+ * This function returns the number of bytes needed for a ring, given\n+ * the number of elements in it and the size of the element. This value\n+ * is the sum of the size of the structure rte_ring and the size of the\n+ * memory needed for storing the elements. The value is aligned to a cache\n+ * line size.\n+ *\n+ * @param count\n+ * The number of elements in the ring (must be a power of 2).\n+ * @param esize\n+ * The size of elements in the ring (recommended to be a power of 2).\n+ * @return\n+ * - The memory size needed for the ring on success.\n+ * - -EINVAL if count is not a power of 2.\n+ */\n+__rte_experimental\n+ssize_t rte_ring_get_memsize_elem(unsigned count, size_t esize);\n+\n /**\n * Calculate the memory size needed for a ring\n *\n@@ -175,6 +198,54 @@ ssize_t rte_ring_get_memsize(unsigned count);\n int rte_ring_init(struct rte_ring *r, const char *name, unsigned count,\n \tunsigned flags);\n \n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n+ * Create a new ring named *name* that stores elements with given size.\n+ *\n+ * This function uses ``memzone_reserve()`` to allocate memory. Then it\n+ * calls rte_ring_init() to initialize an empty ring.\n+ *\n+ * The new ring size is set to *count*, which must be a power of\n+ * two. Water marking is disabled by default. The real usable ring size\n+ * is *count-1* instead of *count* to differentiate a free ring from an\n+ * empty ring.\n+ *\n+ * The ring is added in RTE_TAILQ_RING list.\n+ *\n+ * @param name\n+ * The name of the ring.\n+ * @param count\n+ * The number of elements in the ring (must be a power of 2).\n+ * @param esize\n+ * The size of elements in the ring (recommended to be a power of 2).\n+ * @param socket_id\n+ * The *socket_id* argument is the socket identifier in case of\n+ * NUMA. The value can be *SOCKET_ID_ANY* if there is no NUMA\n+ * constraint for the reserved zone.\n+ * @param flags\n+ * An OR of the following:\n+ * - RING_F_SP_ENQ: If this flag is set, the default behavior when\n+ * using ``rte_ring_enqueue()`` or ``rte_ring_enqueue_bulk()``\n+ * is \"single-producer\". Otherwise, it is \"multi-producers\".\n+ * - RING_F_SC_DEQ: If this flag is set, the default behavior when\n+ * using ``rte_ring_dequeue()`` or ``rte_ring_dequeue_bulk()``\n+ * is \"single-consumer\". Otherwise, it is \"multi-consumers\".\n+ * @return\n+ * On success, the pointer to the new allocated ring. NULL on error with\n+ * rte_errno set appropriately. Possible errno values include:\n+ * - E_RTE_NO_CONFIG - function could not get pointer to rte_config structure\n+ * - E_RTE_SECONDARY - function was called from a secondary process instance\n+ * - EINVAL - count provided is not a power of 2\n+ * - ENOSPC - the maximum number of memzones has already been allocated\n+ * - EEXIST - a memzone with the same name already exists\n+ * - ENOMEM - no appropriate memory area found in which to create memzone\n+ */\n+__rte_experimental\n+struct rte_ring *rte_ring_create_elem(const char *name, unsigned count,\n+\t\t\t\tsize_t esize, int socket_id, unsigned flags);\n+\n /**\n * Create a new ring named *name* in memory.\n *\n@@ -216,6 +287,7 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned count,\n */\n struct rte_ring *rte_ring_create(const char *name, unsigned count,\n \t\t\t\t int socket_id, unsigned flags);\n+\n /**\n * De-allocate all memory used by the ring.\n *\ndiff --git a/lib/librte_ring/rte_ring_version.map b/lib/librte_ring/rte_ring_version.map\nindex 510c1386e..e410a7503 100644\n--- a/lib/librte_ring/rte_ring_version.map\n+++ b/lib/librte_ring/rte_ring_version.map\n@@ -21,6 +21,8 @@ DPDK_2.2 {\n EXPERIMENTAL {\n \tglobal:\n \n+\trte_ring_create_elem;\n+\trte_ring_get_memsize_elem;\n \trte_ring_reset;\n \n };\n", "prefixes": [ "v2", "1/6" ] }