Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59382/?format=api
http://patchwork.dpdk.org/api/patches/59382/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20190919163643.24130-3-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190919163643.24130-3-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190919163643.24130-3-yong.liu@intel.com", "date": "2019-09-19T16:36:29", "name": "[v2,02/16] vhost: unify unroll pragma parameter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "568e96f84578c46732b9685e86d805abe6d4fca4", "submitter": { "id": 17, "url": "http://patchwork.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20190919163643.24130-3-yong.liu@intel.com/mbox/", "series": [ { "id": 6444, "url": "http://patchwork.dpdk.org/api/series/6444/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6444", "date": "2019-09-19T16:36:27", "name": "vhost packed ring performance optimization", "version": 2, "mbox": "http://patchwork.dpdk.org/series/6444/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/59382/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/59382/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 368F51C229;\n\tThu, 19 Sep 2019 10:56:34 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 686231C1E1\n\tfor <dev@dpdk.org>; Thu, 19 Sep 2019 10:56:28 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Sep 2019 01:56:27 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.142])\n\tby orsmga001.jf.intel.com with ESMTP; 19 Sep 2019 01:56:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,523,1559545200\"; d=\"scan'208\";a=\"271146085\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Fri, 20 Sep 2019 00:36:29 +0800", "Message-Id": "<20190919163643.24130-3-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190919163643.24130-1-yong.liu@intel.com>", "References": "<20190905161421.55981-2-yong.liu@intel.com>\n\t<20190919163643.24130-1-yong.liu@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 02/16] vhost: unify unroll pragma parameter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add macro for unifying Clang/ICC/GCC unroll pragma format. Burst\nfunctions were contained of several small loops which optimized by\ncompiler’s loop unrolling pragma.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile\nindex 8623e91c0..30839a001 100644\n--- a/lib/librte_vhost/Makefile\n+++ b/lib/librte_vhost/Makefile\n@@ -16,6 +16,24 @@ CFLAGS += -I vhost_user\n CFLAGS += -fno-strict-aliasing\n LDLIBS += -lpthread\n \n+ifeq ($(RTE_TOOLCHAIN), gcc)\n+ifeq ($(shell test $(GCC_VERSION) -ge 83 && echo 1), 1)\n+CFLAGS += -DSUPPORT_GCC_UNROLL_PRAGMA\n+endif\n+endif\n+\n+ifeq ($(RTE_TOOLCHAIN), clang)\n+ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -ge 37 && echo 1), 1)\n+CFLAGS += -DSUPPORT_CLANG_UNROLL_PRAGMA\n+endif\n+endif\n+\n+ifeq ($(RTE_TOOLCHAIN), icc)\n+ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 16 && echo 1), 1)\n+CFLAGS += -DSUPPORT_ICC_UNROLL_PRAGMA\n+endif\n+endif\n+\n ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)\n LDLIBS += -lnuma\n endif\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 884befa85..5074226f0 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -39,6 +39,24 @@\n \n #define VHOST_LOG_CACHE_NR 32\n \n+#ifdef SUPPORT_GCC_UNROLL_PRAGMA\n+#define PRAGMA_PARAM \"GCC unroll 4\"\n+#endif\n+\n+#ifdef SUPPORT_CLANG_UNROLL_PRAGMA\n+#define PRAGMA_PARAM \"unroll 4\"\n+#endif\n+\n+#ifdef SUPPORT_ICC_UNROLL_PRAGMA\n+#define PRAGMA_PARAM \"unroll (4)\"\n+#endif\n+\n+#ifdef PRAGMA_PARAM\n+#define UNROLL_PRAGMA(param) _Pragma(param)\n+#else\n+#define UNROLL_PRAGMA(param) do {} while(0);\n+#endif\n+\n /**\n * Structure contains buffer address, length and descriptor index\n * from vring to do scatter RX.\n", "prefixes": [ "v2", "02/16" ] }{ "id": 59382, "url": "