Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60582/?format=api
{ "id": 60582, "url": "http://patchwork.dpdk.org/api/patches/60582/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20191006201409.8770-4-rmody@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191006201409.8770-4-rmody@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191006201409.8770-4-rmody@marvell.com", "date": "2019-10-06T20:14:03", "name": "[v2,3/9] net/qede/base: lock entire QM reconfiguration flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ef409dd57d6abce219b652ece738c29faa052cf2", "submitter": { "id": 1211, "url": "http://patchwork.dpdk.org/api/people/1211/?format=api", "name": "Rasesh Mody", "email": "rmody@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20191006201409.8770-4-rmody@marvell.com/mbox/", "series": [ { "id": 6708, "url": "http://patchwork.dpdk.org/api/series/6708/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6708", "date": "2019-10-06T20:14:03", "name": null, "version": 2, "mbox": "http://patchwork.dpdk.org/series/6708/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/60582/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/60582/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 56AD91D15A;\n\tSun, 6 Oct 2019 22:14:32 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n\t[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E1A041D14F\n\tfor <dev@dpdk.org>; Sun, 6 Oct 2019 22:14:25 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n\tby mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx96KEPWi010580; Sun, 6 Oct 2019 13:14:25 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n\tby mx0a-0016f401.pphosted.com with ESMTP id 2verhrc80q-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tSun, 06 Oct 2019 13:14:25 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tSun, 6 Oct 2019 13:14:23 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Sun, 6 Oct 2019 13:14:23 -0700", "from irv1user08.caveonetworks.com (unknown [10.104.116.105])\n\tby maili.marvell.com (Postfix) with ESMTP id 743D13F703F;\n\tSun, 6 Oct 2019 13:14:23 -0700 (PDT)", "(from rmody@localhost)\n\tby irv1user08.caveonetworks.com (8.14.4/8.14.4/Submit) id\n\tx96KEM5k008853; Sun, 6 Oct 2019 13:14:22 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-type; s=pfpt0818;\n\tbh=mZnXLUjr/URcPeD5mSKlr6MYUjze1/YbcjBBLRZPm+8=; \n\tb=KtbfK+6Q7ohWU5tDzHu3MmYU48JfDFBPm5trrkDxvcsWWCURDZsX44jx6r+E15a8o0xi\n\tCC2MqhrydgirNEqD5uuXRtIEiiLi3Ri+ZBsW7ovsyqeuyRDdQA+TmkGwqYBS9OZqZ/Is\n\tyWm15mt8oTuLdbmrkF7rLZjr53oU9qPP7mrECJDrElmI0wsqjDqPrVoKVLGLRjnqCnd5\n\tc+c1M3+s9imtymfIAdysHAanX5oaRKKEgpVvkZu7j4DBEzB+3zC48PJaC6+1nI2AJj1V\n\t8aKyBLn6JFOTZi0YX0N54WQS5aszOpLnVWQaD/2GZZ4hHVHaItUNWYoywFu188BF4Ydk\n\tAw== ", "X-Authentication-Warning": "irv1user08.caveonetworks.com: rmody set sender to\n\trmody@marvell.com using -f", "From": "Rasesh Mody <rmody@marvell.com>", "To": "<dev@dpdk.org>, <jerinj@marvell.com>, <ferruh.yigit@intel.com>", "CC": "Rasesh Mody <rmody@marvell.com>, <GR-Everest-DPDK-Dev@marvell.com>", "Date": "Sun, 6 Oct 2019 13:14:03 -0700", "Message-ID": "<20191006201409.8770-4-rmody@marvell.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20190930024921.21818-1-rmody@marvell.com>", "References": "<20190930024921.21818-1-rmody@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,1.0.8\n\tdefinitions=2019-10-06_08:2019-10-03,2019-10-06 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 3/9] net/qede/base: lock entire QM\n\treconfiguration flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Multiple flows can issue QM reconfiguration, hence hold the lock longer\nto account for entire duration of reconfiguration flow.\n\nSigned-off-by: Rasesh Mody <rmody@marvell.com>\n---\n drivers/net/qede/base/ecore_dev.c | 24 +++++++++++++-----------\n 1 file changed, 13 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c\nindex d7e1d7b32..b183519b5 100644\n--- a/drivers/net/qede/base/ecore_dev.c\n+++ b/drivers/net/qede/base/ecore_dev.c\n@@ -2291,18 +2291,21 @@ enum _ecore_status_t ecore_qm_reconf(struct ecore_hwfn *p_hwfn,\n {\n \tstruct ecore_qm_info *qm_info = &p_hwfn->qm_info;\n \tbool b_rc;\n-\tenum _ecore_status_t rc;\n+\tenum _ecore_status_t rc = ECORE_SUCCESS;\n+\n+\t/* multiple flows can issue qm reconf. Need to lock */\n+\tOSAL_SPIN_LOCK(&qm_lock);\n \n \t/* initialize ecore's qm data structure */\n \tecore_init_qm_info(p_hwfn);\n \n \t/* stop PF's qm queues */\n-\tOSAL_SPIN_LOCK(&qm_lock);\n \tb_rc = ecore_send_qm_stop_cmd(p_hwfn, p_ptt, false, true,\n \t\t\t\t qm_info->start_pq, qm_info->num_pqs);\n-\tOSAL_SPIN_UNLOCK(&qm_lock);\n-\tif (!b_rc)\n-\t\treturn ECORE_INVAL;\n+\tif (!b_rc) {\n+\t\trc = ECORE_INVAL;\n+\t\tgoto unlock;\n+\t}\n \n \t/* clear the QM_PF runtime phase leftovers from previous init */\n \tecore_init_clear_rt_data(p_hwfn);\n@@ -2313,18 +2316,17 @@ enum _ecore_status_t ecore_qm_reconf(struct ecore_hwfn *p_hwfn,\n \t/* activate init tool on runtime array */\n \trc = ecore_init_run(p_hwfn, p_ptt, PHASE_QM_PF, p_hwfn->rel_pf_id,\n \t\t\t p_hwfn->hw_info.hw_mode);\n-\tif (rc != ECORE_SUCCESS)\n-\t\treturn rc;\n \n \t/* start PF's qm queues */\n-\tOSAL_SPIN_LOCK(&qm_lock);\n \tb_rc = ecore_send_qm_stop_cmd(p_hwfn, p_ptt, true, true,\n \t\t\t\t qm_info->start_pq, qm_info->num_pqs);\n-\tOSAL_SPIN_UNLOCK(&qm_lock);\n \tif (!b_rc)\n-\t\treturn ECORE_INVAL;\n+\t\trc = ECORE_INVAL;\n \n-\treturn ECORE_SUCCESS;\n+unlock:\n+\tOSAL_SPIN_UNLOCK(&qm_lock);\n+\n+\treturn rc;\n }\n \n static enum _ecore_status_t ecore_alloc_qm_data(struct ecore_hwfn *p_hwfn)\n", "prefixes": [ "v2", "3/9" ] }