Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61434/?format=api
{ "id": 61434, "url": "http://patchwork.dpdk.org/api/patches/61434/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1571329213-240529-2-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1571329213-240529-2-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1571329213-240529-2-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2019-10-17T16:20:13", "name": "[2/2] crypto/aesni_gcm: allow device init if no AES-NI is present", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "04b365a6bc511cbd41a883b235203f499bc2ba29", "submitter": { "id": 9, "url": "http://patchwork.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1571329213-240529-2-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 6918, "url": "http://patchwork.dpdk.org/api/series/6918/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6918", "date": "2019-10-17T16:20:12", "name": "[1/2] crypto/aesni_mb: allow device init if no AES-NI is present", "version": 1, "mbox": "http://patchwork.dpdk.org/series/6918/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/61434/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/61434/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4256C1E8A6;\n\tThu, 17 Oct 2019 18:20:28 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 947E71E4E8\n\tfor <dev@dpdk.org>; Thu, 17 Oct 2019 18:20:24 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Oct 2019 09:20:24 -0700", "from silpixa00399593.ir.intel.com (HELO\n\tsilpixa00399593.ger.corp.intel.com) ([10.237.223.21])\n\tby FMSMGA003.fm.intel.com with ESMTP; 17 Oct 2019 09:20:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,308,1566889200\"; d=\"scan'208\";a=\"202433016\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "dev@dpdk.org", "Cc": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Thu, 17 Oct 2019 17:20:13 +0100", "Message-Id": "<1571329213-240529-2-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.7.5", "In-Reply-To": "<1571329213-240529-1-git-send-email-pablo.de.lara.guarch@intel.com>", "References": "<1571329213-240529-1-git-send-email-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/2] crypto/aesni_gcm: allow device init if no\n\tAES-NI is present", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The IPSec Multi buffer library does not require AES-NI\ninstructions to be supported by the CPU, as it can emulate these\ninstructions in software (adding a big performance penalty when\nusing AES algorithms).\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\nindex 1006a5c..0c4efa6 100644\n--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n@@ -491,11 +491,6 @@ aesni_gcm_create(const char *name,\n \tenum aesni_gcm_vector_mode vector_mode;\n \tMB_MGR *mb_mgr;\n \n-\t/* Check CPU for support for AES instruction set */\n-\tif (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_AES)) {\n-\t\tAESNI_GCM_LOG(ERR, \"AES instructions not supported by CPU\");\n-\t\treturn -EFAULT;\n-\t}\n \tdev = rte_cryptodev_pmd_create(name, &vdev->device, init_params);\n \tif (dev == NULL) {\n \t\tAESNI_GCM_LOG(ERR, \"driver %s: create failed\",\n@@ -522,10 +517,15 @@ aesni_gcm_create(const char *name,\n \n \tdev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |\n \t\t\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n-\t\t\tRTE_CRYPTODEV_FF_CPU_AESNI |\n \t\t\tRTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |\n \t\t\tRTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT;\n \n+\t/* Check CPU for support for AES instruction set */\n+\tif (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AES))\n+\t\tdev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AESNI;\n+ else\n+\t\tAESNI_GCM_LOG(WARNING, \"AES instructions not supported by CPU\");\n+\n \tmb_mgr = alloc_mb_mgr(0);\n \tif (mb_mgr == NULL)\n \t\treturn -ENOMEM;\n", "prefixes": [ "2/2" ] }