Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61950/?format=api
http://patchwork.dpdk.org/api/patches/61950/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20191025162042.71687-1-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191025162042.71687-1-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191025162042.71687-1-yong.liu@intel.com", "date": "2019-10-25T16:20:42", "name": "vhost: fix vhost user virtqueue not accessable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d963a4dd7537a2d243e61494e4414fc58e9a1042", "submitter": { "id": 17, "url": "http://patchwork.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20191025162042.71687-1-yong.liu@intel.com/mbox/", "series": [ { "id": 7065, "url": "http://patchwork.dpdk.org/api/series/7065/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=7065", "date": "2019-10-25T16:20:42", "name": "vhost: fix vhost user virtqueue not accessable", "version": 1, "mbox": "http://patchwork.dpdk.org/series/7065/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/61950/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/61950/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EBCC1C10B;\n\tFri, 25 Oct 2019 10:40:56 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 167C21C0CD\n\tfor <dev@dpdk.org>; Fri, 25 Oct 2019 10:40:53 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Oct 2019 01:40:53 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.142])\n\tby orsmga001.jf.intel.com with ESMTP; 25 Oct 2019 01:40:51 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,228,1569308400\"; d=\"scan'208\";a=\"282199870\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, \n\tamorenoz@redhat.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Sat, 26 Oct 2019 00:20:42 +0800", "Message-Id": "<20191025162042.71687-1-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] vhost: fix vhost user virtqueue not accessable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Log feature is disabled in vhost user, so that log address was invalid\nwhen checking. Add feature bit check can skip useless address check.\n\nFixes: 04cfc7fdbfca (\"vhost: translate incoming log address to gpa\")\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>\n---\n lib/librte_vhost/vhost_user.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 61ef699ac..0407fdc29 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -741,13 +741,15 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index)\n \t\tvq->last_avail_idx = vq->used->idx;\n \t}\n \n-\tvq->log_guest_addr =\n-\t\ttranslate_log_addr(dev, vq, addr->log_guest_addr);\n-\tif (vq->log_guest_addr == 0) {\n-\t\tRTE_LOG(DEBUG, VHOST_CONFIG,\n-\t\t\t\"(%d) failed to map log_guest_addr .\\n\",\n-\t\t\tdev->vid);\n-\t\treturn dev;\n+\tif (dev->features & (1ULL << VHOST_F_LOG_ALL)) {\n+\t\tvq->log_guest_addr =\n+\t\t\ttranslate_log_addr(dev, vq, addr->log_guest_addr);\n+\t\tif (vq->log_guest_addr == 0) {\n+\t\t\tRTE_LOG(DEBUG, VHOST_CONFIG,\n+\t\t\t\t\"(%d) failed to map log_guest_addr .\\n\",\n+\t\t\t\tdev->vid);\n+\t\t\treturn dev;\n+\t\t}\n \t}\n \tvq->access_ok = 1;\n \n", "prefixes": [] }{ "id": 61950, "url": "