Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6196/?format=api
{ "id": 6196, "url": "http://patchwork.dpdk.org/api/patches/6196/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1436367323-19968-2-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1436367323-19968-2-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1436367323-19968-2-git-send-email-thomas.monjalon@6wind.com", "date": "2015-07-08T14:55:22", "name": "[dpdk-dev,v2,1/2] mk: remove variables identical to config ones", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "50d7bda5612a2cb621b84bca521c1231828c41b9", "submitter": { "id": 1, "url": "http://patchwork.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1436367323-19968-2-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/6196/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/6196/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E73015A66;\n\tWed, 8 Jul 2015 16:56:43 +0200 (CEST)", "from mail-wi0-f173.google.com (mail-wi0-f173.google.com\n\t[209.85.212.173]) by dpdk.org (Postfix) with ESMTP id CD6A69E7\n\tfor <dev@dpdk.org>; Wed, 8 Jul 2015 16:56:39 +0200 (CEST)", "by wiga1 with SMTP id a1so287617759wig.0\n\tfor <dev@dpdk.org>; Wed, 08 Jul 2015 07:56:39 -0700 (PDT)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\tlj14sm3332162wic.18.2015.07.08.07.56.38\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 08 Jul 2015 07:56:38 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=UzCAkotmBAVVmmgsoo94Oqeu1H5aBeO0IGWhP15Ndsw=;\n\tb=gN3X9+Lctr++yXOTAQoibRjdsNpO2ZOOptRrTDpTyN7xLSjSF0hEgeg1Zt6UB6jWhW\n\thj7ADsVOv+Q7Dakyh0RPRxGVp69NFTN43pHeLrW4YAYOhVAnekc3hD6n8AEDdmiHGTFd\n\t2i9rlUNv5ihEIG5oAhMBbycaorMnWwxcsVNmo22aavupFurc/62Olu7FFjuzYmOCmMic\n\tWv6hFZhO+2bTiaFWFLk6hkSxH0kMvcHLycqyEMdkh1qhJepqEMNbz7r3P45C0mCqaBN4\n\tIN0IIYfDiorxhM7AhkQEcUMoh2g94p94ZNmprG/K8e6xuMHDtlD/qdOZV2gYLAB7TWR0\n\tR/pg==", "X-Gm-Message-State": "ALoCoQlVQ1Y7k0tFq36MM9QPX1xBpjSXjiLLebYEjTngoVk+y796YM1C3zoO7g1ur9vZd10/RpVj", "X-Received": "by 10.194.171.129 with SMTP id\n\tau1mr21477280wjc.115.1436367399647; \n\tWed, 08 Jul 2015 07:56:39 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "nhorman@tuxdriver.com", "Date": "Wed, 8 Jul 2015 16:55:22 +0200", "Message-Id": "<1436367323-19968-2-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.4.2", "In-Reply-To": "<1436367323-19968-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1435874746-32095-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1436367323-19968-1-git-send-email-thomas.monjalon@6wind.com>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH v2 1/2] mk: remove variables identical to config\n\tones", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "CONFIG_RTE_BUILD_SHARED_LIB and CONFIG_RTE_BUILD_COMBINE_LIBS does not\nhave quotes in their values (only y or n). That's why the variables\nRTE_BUILD_SHARED_LIB and RTE_BUILD_COMBINE_LIBS are always identical to\ntheir CONFIG_ counterpart, and are useless.\nIn order to have consistent naming of config options in the makefiles,\nthese options are removed and the \"CONFIG_ prefixed\" variables are used.\n\nFixes: e25e4d7ef16b (\"mk: shared libraries\")\nFixes: 4d3d79e7a5c6 (\"mk: combined library\")\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/exec-env/bsdapp/rte.vars.mk | 4 ++--\n mk/exec-env/linuxapp/rte.vars.mk | 4 ++--\n mk/rte.lib.mk | 12 ++++++------\n mk/rte.sdkbuild.mk | 2 +-\n mk/rte.sharelib.mk | 8 ++++----\n mk/rte.vars.mk | 8 --------\n 6 files changed, 15 insertions(+), 23 deletions(-)", "diff": "diff --git a/mk/exec-env/bsdapp/rte.vars.mk b/mk/exec-env/bsdapp/rte.vars.mk\nindex aed0e18..47a673e 100644\n--- a/mk/exec-env/bsdapp/rte.vars.mk\n+++ b/mk/exec-env/bsdapp/rte.vars.mk\n@@ -39,7 +39,7 @@\n #\n # examples for RTE_EXEC_ENV: linuxapp, bsdapp\n #\n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n EXECENV_CFLAGS = -pthread -fPIC\n else\n EXECENV_CFLAGS = -pthread\n@@ -49,7 +49,7 @@ EXECENV_LDFLAGS =\n EXECENV_LDLIBS = -lexecinfo\n EXECENV_ASFLAGS =\n \n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n EXECENV_LDLIBS += -lgcc_s\n endif\n \ndiff --git a/mk/exec-env/linuxapp/rte.vars.mk b/mk/exec-env/linuxapp/rte.vars.mk\nindex e5af318..5fd7d85 100644\n--- a/mk/exec-env/linuxapp/rte.vars.mk\n+++ b/mk/exec-env/linuxapp/rte.vars.mk\n@@ -39,7 +39,7 @@\n #\n # examples for RTE_EXEC_ENV: linuxapp, bsdapp\n #\n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n EXECENV_CFLAGS = -pthread -fPIC\n else\n EXECENV_CFLAGS = -pthread\n@@ -51,7 +51,7 @@ EXECENV_LDFLAGS = --no-as-needed\n EXECENV_LDLIBS = -lrt -lm\n EXECENV_ASFLAGS =\n \n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n EXECENV_LDLIBS += -lgcc_s\n endif\n \ndiff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex 25aa989..fff62a7 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -37,7 +37,7 @@ include $(RTE_SDK)/mk/internal/rte.depdirs-pre.mk\n \n # VPATH contains at least SRCDIR\n VPATH += $(SRCDIR)\n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n \n LIB := $(patsubst %.a,%.so.$(LIBABIVER),$(LIB))\n CPU_LDFLAGS += --version-script=$(SRCDIR)/$(EXPORT_MAP)\n@@ -87,7 +87,7 @@ O_TO_S_DO = @set -e; \\\n \t$(O_TO_S) && \\\n \techo $(O_TO_S_CMD) > $(call exe2cmd,$(@))\n \n-ifeq ($(RTE_BUILD_SHARED_LIB),n)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)\n O_TO_C = $(AR) crus $(LIB_ONE) $(OBJS-y)\n O_TO_C_STR = $(subst ','\\'',$(O_TO_C)) #'# fix syntax highlight\n O_TO_C_DISP = $(if $(V),\"$(O_TO_C_STR)\",\" AR_C $(@)\")\n@@ -110,7 +110,7 @@ lib_dir = [ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib;\n #\n # Archive objects in .a file if needed\n #\n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n $(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE\n ifeq ($(LIBABIVER),)\n \t@echo \"Must Specify a $(LIB) ABI version\"\n@@ -130,7 +130,7 @@ endif\n \t\t$(depfile_newer)),\\\n \t\t$(O_TO_S_DO))\n \n-ifeq ($(RTE_BUILD_COMBINE_LIBS),y)\n+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)\n \t$(if $(or \\\n $(file_missing),\\\n $(call cmdline_changed,$(O_TO_C_STR)),\\\n@@ -153,7 +153,7 @@ $(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE\n \t $(depfile_missing),\\\n \t $(depfile_newer)),\\\n \t $(O_TO_A_DO))\n-ifeq ($(RTE_BUILD_COMBINE_LIBS),y)\n+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)\n \t$(if $(or \\\n $(file_missing),\\\n $(call cmdline_changed,$(O_TO_C_STR)),\\\n@@ -171,7 +171,7 @@ $(RTE_OUTPUT)/lib/$(LIB): $(LIB)\n \t@echo \" INSTALL-LIB $(LIB)\"\n \t@[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib\n \t$(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib\n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n \t$(Q)ln -s -f $< $(RTE_OUTPUT)/lib/$(LIBSONAME)\n endif\n \ndiff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk\nindex 352f738..38ec7bd 100644\n--- a/mk/rte.sdkbuild.mk\n+++ b/mk/rte.sdkbuild.mk\n@@ -93,7 +93,7 @@ $(ROOTDIRS-y):\n \t@[ -d $(BUILDDIR)/$@ ] || mkdir -p $(BUILDDIR)/$@\n \t@echo \"== Build $@\"\n \t$(Q)$(MAKE) S=$@ -f $(RTE_SRCDIR)/$@/Makefile -C $(BUILDDIR)/$@ all\n-\t@if [ $@ = drivers -a $(RTE_BUILD_COMBINE_LIBS) = y ]; then \\\n+\t@if [ $@ = drivers -a $(CONFIG_RTE_BUILD_COMBINE_LIBS) = y ]; then \\\n \t\t$(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \\\n \tfi\n \ndiff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk\nindex de53558..7bb7219 100644\n--- a/mk/rte.sharelib.mk\n+++ b/mk/rte.sharelib.mk\n@@ -34,8 +34,8 @@ include $(RTE_SDK)/mk/internal/rte.build-pre.mk\n # VPATH contains at least SRCDIR\n VPATH += $(SRCDIR)\n \n-ifeq ($(RTE_BUILD_COMBINE_LIBS),y)\n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n LIB_ONE := lib$(RTE_LIBNAME).so\n else\n LIB_ONE := lib$(RTE_LIBNAME).a\n@@ -75,8 +75,8 @@ O_TO_A_DO = @set -e; \\\n # Archive objects to share library\n #\n \n-ifeq ($(RTE_BUILD_COMBINE_LIBS),y)\n-ifeq ($(RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)\n+ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n $(LIB_ONE): FORCE\n \t@[ -d $(dir $@) ] || mkdir -p $(dir $@)\n \t$(O_TO_S_DO)\ndiff --git a/mk/rte.vars.mk b/mk/rte.vars.mk\nindex d2f01b6..0469064 100644\n--- a/mk/rte.vars.mk\n+++ b/mk/rte.vars.mk\n@@ -63,14 +63,6 @@ ifneq ($(BUILDING_RTE_SDK),)\n RTE_TOOLCHAIN := $(CONFIG_RTE_TOOLCHAIN:\"%\"=%)\n RTE_TARGET := $(RTE_ARCH)-$(RTE_MACHINE)-$(RTE_EXEC_ENV)-$(RTE_TOOLCHAIN)\n RTE_SDK_BIN := $(RTE_OUTPUT)\n- RTE_BUILD_SHARED_LIB := $(CONFIG_RTE_BUILD_SHARED_LIB:\"%\"=%)\n- ifeq ($(RTE_BUILD_SHARED_LIB),)\n- RTE_BUILD_SHARED_LIB := n\n- endif\n- RTE_BUILD_COMBINE_LIBS := $(CONFIG_RTE_BUILD_COMBINE_LIBS:\"%\"=%)\n- ifeq ($(RTE_BUILD_COMBINE_LIBS),)\n- RTE_BUILD_COMBINE_LIBS := n\n- endif\n endif\n \n RTE_LIBNAME := $(CONFIG_RTE_LIBNAME:\"%\"=%)\n", "prefixes": [ "dpdk-dev", "v2", "1/2" ] }