Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62229/?format=api
{ "id": 62229, "url": "http://patchwork.dpdk.org/api/patches/62229/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20191030143619.4007-7-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191030143619.4007-7-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191030143619.4007-7-olivier.matz@6wind.com", "date": "2019-10-30T14:36:19", "name": "[v2,6/6] mempool: use the specific macro for object alignment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "368c13fa439dfa27e1d46c0120eb9807e04dc555", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20191030143619.4007-7-olivier.matz@6wind.com/mbox/", "series": [ { "id": 7161, "url": "http://patchwork.dpdk.org/api/series/7161/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=7161", "date": "2019-10-30T14:36:15", "name": "mempool: avoid objects allocations across pages", "version": 2, "mbox": "http://patchwork.dpdk.org/series/7161/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/62229/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/62229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9AD08A00BE;\n\tWed, 30 Oct 2019 15:37:42 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7EB141C02C;\n\tWed, 30 Oct 2019 15:37:08 +0100 (CET)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id A5C781BFCF\n for <dev@dpdk.org>; Wed, 30 Oct 2019 15:36:57 +0100 (CET)", "from glumotte.dev.6wind.com. (unknown [10.16.0.195])\n by proxy.6wind.com (Postfix) with ESMTP id F1136338A4E;\n Wed, 30 Oct 2019 15:36:55 +0100 (CET)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>,\n Ferruh Yigit <ferruh.yigit@linux.intel.com>,\n \"Giridharan, Ganesan\" <ggiridharan@rbbn.com>,\n Jerin Jacob Kollanukkaran <jerinj@marvell.com>,\n \"Kiran Kumar Kokkilagadda\" <kirankumark@marvell.com>,\n Stephen Hemminger <sthemmin@microsoft.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vamsi Krishna Attunuru <vattunuru@marvell.com>", "Date": "Wed, 30 Oct 2019 15:36:19 +0100", "Message-Id": "<20191030143619.4007-7-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191030143619.4007-1-olivier.matz@6wind.com>", "References": "<20190719133845.32432-1-olivier.matz@6wind.com>\n <20191030143619.4007-1-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 6/6] mempool: use the specific macro for\n\tobject alignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For consistency, RTE_MEMPOOL_ALIGN should be used in place of\nRTE_CACHE_LINE_SIZE. They have the same value, because the only arch\nthat was defining a specific value for it has been removed from dpdk.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/librte_mempool/rte_mempool.c | 2 +-\n lib/librte_mempool/rte_mempool.h | 3 +++\n lib/librte_mempool/rte_mempool_ops_default.c | 2 +-\n 3 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex d3db9273d..40cae3eb6 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -329,7 +329,7 @@ rte_mempool_populate_iova(struct rte_mempool *mp, char *vaddr,\n \tif (mp->flags & MEMPOOL_F_NO_CACHE_ALIGN)\n \t\toff = RTE_PTR_ALIGN_CEIL(vaddr, 8) - vaddr;\n \telse\n-\t\toff = RTE_PTR_ALIGN_CEIL(vaddr, RTE_CACHE_LINE_SIZE) - vaddr;\n+\t\toff = RTE_PTR_ALIGN_CEIL(vaddr, RTE_MEMPOOL_ALIGN) - vaddr;\n \n \tif (off > len) {\n \t\tret = -EINVAL;\ndiff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h\nindex 6d98b3743..cb7c423e6 100644\n--- a/lib/librte_mempool/rte_mempool.h\n+++ b/lib/librte_mempool/rte_mempool.h\n@@ -116,6 +116,9 @@ struct rte_mempool_objsz {\n #define\tMEMPOOL_PG_NUM_DEFAULT\t1\n \n #ifndef RTE_MEMPOOL_ALIGN\n+/**\n+ * Alignment of elements inside mempool.\n+ */\n #define RTE_MEMPOOL_ALIGN\tRTE_CACHE_LINE_SIZE\n #endif\n \ndiff --git a/lib/librte_mempool/rte_mempool_ops_default.c b/lib/librte_mempool/rte_mempool_ops_default.c\nindex e5cd4600f..390c490fd 100644\n--- a/lib/librte_mempool/rte_mempool_ops_default.c\n+++ b/lib/librte_mempool/rte_mempool_ops_default.c\n@@ -56,7 +56,7 @@ rte_mempool_op_calc_mem_size_default(const struct rte_mempool *mp,\n \t}\n \n \t*min_chunk_size = total_elt_sz;\n-\t*align = RTE_CACHE_LINE_SIZE;\n+\t*align = RTE_MEMPOOL_ALIGN;\n \n \treturn mem_size;\n }\n", "prefixes": [ "v2", "6/6" ] }