Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 623,
    "url": "http://patchwork.dpdk.org/api/patches/623/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1411974986-28137-3-git-send-email-changchun.ouyang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1411974986-28137-3-git-send-email-changchun.ouyang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1411974986-28137-3-git-send-email-changchun.ouyang@intel.com",
    "date": "2014-09-29T07:16:10",
    "name": "[dpdk-dev,v2,02/18] ixgbe: Clean up IXGBE base codes",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "73f307e3c7cfbcb77289b52b1392338c68057559",
    "submitter": {
        "id": 31,
        "url": "http://patchwork.dpdk.org/api/people/31/?format=api",
        "name": "Ouyang Changchun",
        "email": "changchun.ouyang@intel.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1411974986-28137-3-git-send-email-changchun.ouyang@intel.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/623/comments/",
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/623/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 35E767E27;\n\tMon, 29 Sep 2014 09:10:36 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id ACE557E27\n\tfor <dev@dpdk.org>; Mon, 29 Sep 2014 09:10:22 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 29 Sep 2014 00:16:56 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 29 Sep 2014 00:16:52 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id s8T7GoCF012662;\n\tMon, 29 Sep 2014 15:16:50 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s8T7GmRN028348; Mon, 29 Sep 2014 15:16:50 +0800",
            "(from couyang@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s8T7Gmq8028344; \n\tMon, 29 Sep 2014 15:16:48 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.04,618,1406617200\"; d=\"scan'208\";a=\"606847645\"",
        "From": "Ouyang Changchun <changchun.ouyang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 29 Sep 2014 15:16:10 +0800",
        "Message-Id": "<1411974986-28137-3-git-send-email-changchun.ouyang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1411974986-28137-1-git-send-email-changchun.ouyang@intel.com>",
        "References": "<1411974986-28137-1-git-send-email-changchun.ouyang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 02/18] ixgbe: Clean up IXGBE base codes",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch cleans up some IXGBE base codes, such as remove unnecessary return statement,\nand reduce goto statement etc.\n\nSigned-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c     | 2 --\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c     | 7 +++----\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c    | 2 +-\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.h    | 2 --\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82598.c | 2 ++\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82599.c | 1 +\n lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c       | 3 ++-\n 7 files changed, 9 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c\nindex ee2217d..c8ce893 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c\n@@ -1417,8 +1417,6 @@ STATIC void ixgbe_set_rxpba_82598(struct ixgbe_hw *hw, int num_pb,\n \t/* Setup Tx packet buffer sizes */\n \tfor (i = 0; i < IXGBE_MAX_PACKET_BUFFERS; i++)\n \t\tIXGBE_WRITE_REG(hw, IXGBE_TXPBSIZE(i), IXGBE_TXPBSIZE_40KB);\n-\n-\treturn;\n }\n \n /**\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c\nindex 835331b..046a35e 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c\n@@ -2103,7 +2103,7 @@ s32 ixgbe_identify_phy_82599(struct ixgbe_hw *hw)\n \tif (status != IXGBE_SUCCESS) {\n \t\t/* 82599 10GBASE-T requires an external PHY */\n \t\tif (hw->mac.ops.get_media_type(hw) == ixgbe_media_type_copper)\n-\t\t\tgoto out;\n+\t\t\treturn status;\n \t\telse\n \t\t\tstatus = ixgbe_identify_module_generic(hw);\n \t}\n@@ -2111,14 +2111,13 @@ s32 ixgbe_identify_phy_82599(struct ixgbe_hw *hw)\n \t/* Set PHY type none if no PHY detected */\n \tif (hw->phy.type == ixgbe_phy_unknown) {\n \t\thw->phy.type = ixgbe_phy_none;\n-\t\tstatus = IXGBE_SUCCESS;\n+\t\treturn IXGBE_SUCCESS;\n \t}\n \n \t/* Return error if SFP module has been detected but is not supported */\n \tif (hw->phy.type == ixgbe_phy_sfp_unsupported)\n-\t\tstatus = IXGBE_ERR_SFP_NOT_SUPPORTED;\n+\t\treturn IXGBE_ERR_SFP_NOT_SUPPORTED;\n \n-out:\n \treturn status;\n }\n \ndiff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c\nindex 8084659..e36b3a8 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c\n@@ -1060,7 +1060,7 @@ s32 ixgbe_stop_adapter_generic(struct ixgbe_hw *hw)\n \thw->adapter_stopped = true;\n \n \t/* Disable the receive unit */\n-\tIXGBE_WRITE_REG(hw, IXGBE_RXCTRL, 0);\n+\tixgbe_disable_rx(hw);\n \n \t/* Clear interrupt mask to stop interrupts from being generated */\n \tIXGBE_WRITE_REG(hw, IXGBE_EIMC, IXGBE_IRQ_CLEAR_MASK);\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.h b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.h\nindex 80e47c1..8ee1dba 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.h\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.h\n@@ -41,9 +41,7 @@ POSSIBILITY OF SUCH DAMAGE.\n \t\tIXGBE_WRITE_REG(hw, reg, (u32) value); \\\n \t\tIXGBE_WRITE_REG(hw, reg + 4, (u32) (value >> 32)); \\\n \t} while (0)\n-#ifndef IXGBE_REMOVED\n #define IXGBE_REMOVED(a) (0)\n-#endif /* IXGBE_REMOVED */\n struct ixgbe_pba {\n \tu16 word[2];\n \tu16 *pba_block;\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82598.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82598.c\nindex 52c7e72..a6161cd 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82598.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82598.c\n@@ -347,6 +347,8 @@ s32 ixgbe_dcb_hw_config_82598(struct ixgbe_hw *hw, int link_speed,\n \t\t\t      u16 *refill, u16 *max, u8 *bwg_id,\n \t\t\t      u8 *tsa)\n {\n+\tUNREFERENCED_1PARAMETER(link_speed);\n+\n \tixgbe_dcb_config_rx_arbiter_82598(hw, refill, max, tsa);\n \tixgbe_dcb_config_tx_desc_arbiter_82598(hw, refill, max, bwg_id,\n \t\t\t\t\t       tsa);\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82599.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82599.c\nindex 2bcf1c7..e754d1a 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82599.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_dcb_82599.c\n@@ -580,6 +580,7 @@ s32 ixgbe_dcb_hw_config_82599(struct ixgbe_hw *hw, int link_speed,\n \t\t\t      u16 *refill, u16 *max, u8 *bwg_id, u8 *tsa,\n \t\t\t      u8 *map)\n {\n+\tUNREFERENCED_1PARAMETER(link_speed);\n \n \tixgbe_dcb_config_rx_arbiter_82599(hw, refill, max, bwg_id, tsa,\n \t\t\t\t\t  map);\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c\nindex 7d2ed2a..4271f70 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c\n@@ -1804,7 +1804,7 @@ STATIC s32 ixgbe_get_i2c_ack(struct ixgbe_hw *hw)\n \t\tack = ixgbe_get_i2c_data(&i2cctl);\n \n \t\tusec_delay(1);\n-\t\tif (ack == 0)\n+\t\tif (!ack)\n \t\t\tbreak;\n \t}\n \n@@ -1886,6 +1886,7 @@ STATIC s32 ixgbe_clock_out_i2c_bit(struct ixgbe_hw *hw, bool data)\n \n \treturn status;\n }\n+\n /**\n  *  ixgbe_raise_i2c_clk - Raises the I2C SCL clock\n  *  @hw: pointer to hardware structure\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "02/18"
    ]
}