Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 62875,
    "url": "http://patchwork.dpdk.org/api/patches/62875/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1573548459-6931-2-git-send-email-matan@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1573548459-6931-2-git-send-email-matan@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1573548459-6931-2-git-send-email-matan@mellanox.com",
    "date": "2019-11-12T08:47:39",
    "name": "[2/2] app/testpmd: fix invalid port detaching",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6cffafbd6e285d7362b8372130547c0970b8c798",
    "submitter": {
        "id": 796,
        "url": "http://patchwork.dpdk.org/api/people/796/?format=api",
        "name": "Matan Azrad",
        "email": "matan@mellanox.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1573548459-6931-2-git-send-email-matan@mellanox.com/mbox/",
    "series": [
        {
            "id": 7406,
            "url": "http://patchwork.dpdk.org/api/series/7406/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=7406",
            "date": "2019-11-12T08:47:39",
            "name": "[1/2] bus/pci: fix driver detach clear",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/7406/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/62875/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/62875/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E856AA04AF;\n\tTue, 12 Nov 2019 09:47:54 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 27A0E2B8E;\n\tTue, 12 Nov 2019 09:47:53 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 20FC1B62\n for <dev@dpdk.org>; Tue, 12 Nov 2019 09:47:50 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n matan@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 12 Nov 2019 10:47:47 +0200",
            "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xAC8ll0h025250;\n Tue, 12 Nov 2019 10:47:47 +0200"
        ],
        "From": "Matan Azrad <matan@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>, thomas@monjalon.net,\n stable@dpdk.org",
        "Date": "Tue, 12 Nov 2019 08:47:39 +0000",
        "Message-Id": "<1573548459-6931-2-git-send-email-matan@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1573548459-6931-1-git-send-email-matan@mellanox.com>",
        "References": "<1573548459-6931-1-git-send-email-matan@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detaching",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The port was not validated before detaching.\n\nIgnore port detach operation when the port is not valid.\n\nFixes: f8e5baa2662d (\"app/testpmd: check not detaching device twice\")\nCc: thomas@monjalon.net\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n app/test-pmd/testpmd.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 4444346..370eefe 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2545,6 +2545,9 @@ struct extmem_param {\n \n \tprintf(\"Removing a device...\\n\");\n \n+\tif (port_id_is_invalid(port_id, ENABLED_WARN))\n+\t\treturn;\n+\n \tdev = rte_eth_devices[port_id].device;\n \tif (dev == NULL) {\n \t\tprintf(\"Device already removed\\n\");\n",
    "prefixes": [
        "2/2"
    ]
}