Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63263/?format=api
{ "id": 63263, "url": "http://patchwork.dpdk.org/api/patches/63263/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20191125081007.12396-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191125081007.12396-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191125081007.12396-2-david.marchand@redhat.com", "date": "2019-11-25T08:10:07", "name": "[2/2] buildtools: fix build with coverage enabled", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fe56127c8d8007bf789ee93f9cd1e36ca76e1ebe", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20191125081007.12396-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 7598, "url": "http://patchwork.dpdk.org/api/series/7598/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=7598", "date": "2019-11-25T08:10:06", "name": "[1/2] buildtools: fix experimental symbols listing", "version": 1, "mbox": "http://patchwork.dpdk.org/series/7598/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/63263/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/63263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DFF2A04C2;\n\tMon, 25 Nov 2019 09:10:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CF1865596;\n\tMon, 25 Nov 2019 09:10:28 +0100 (CET)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 3212A4CA6\n for <dev@dpdk.org>; Mon, 25 Nov 2019 09:10:27 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-273-ueMNFm-RMlyyG3MHyUQ89A-1; Mon, 25 Nov 2019 03:10:23 -0500", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com\n [10.5.11.12])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CDFD1005509;\n Mon, 25 Nov 2019 08:10:21 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-70.brq.redhat.com [10.40.204.70])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 127FC60F8A;\n Mon, 25 Nov 2019 08:10:18 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1574669426;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=cGb43gjI1KKafb6uamCXYxzmgnNvFWSZzrGQuK7WvuI=;\n b=RtQiNQQrsV1y2auomVXJsMeF9kiQZBibd+8KezyQtQsR97F3F/uMIqZEignwuZIOfyhyRY\n uywQzigpjXcnCVmsg0KymlWv/TV8OIrUgV9brdeHe5bQFLsq40Gxq6zWvhkrGFgZEVYHH3\n GzPb2d6ymix1igY1lXTTkygHM8hWPqo=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, arybchenko@solarflare.com, stable@dpdk.org,\n Neil Horman <nhorman@tuxdriver.com>", "Date": "Mon, 25 Nov 2019 09:10:07 +0100", "Message-Id": "<20191125081007.12396-2-david.marchand@redhat.com>", "In-Reply-To": "<20191125081007.12396-1-david.marchand@redhat.com>", "References": "<20191125081007.12396-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-MC-Unique": "ueMNFm-RMlyyG3MHyUQ89A-1", "X-Mimecast-Spam-Score": "0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH 2/2] buildtools: fix build with coverage enabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A compiler can reuse a variable name and prefix it when instrumenting\nwith coverage.\n\nExample:\n$ make defconfig T=x86_64-native-linux-gcc O=master\n$ make EXTRA_CFLAGS='--coverage' O=master\n[...]\n CC rte_flow.o\n rte_flow_dynf_metadata_offs is not flagged as experimental but is listed\n in version map\n Please add __rte_experimental to the definition of\n rte_flow_dynf_metadata_offs\n\n$ objdump -t master/build/lib/librte_ethdev/rte_flow.o |grep _offs$\n0000000000000000 l F .text.startup\t000000000000000a\n _GLOBAL__sub_I_65535_0_rte_flow_dynf_metadata_offs\n0000000000000620 g O .data\t0000000000000004\n rte_flow_dynf_metadata_offs\n\nProtect against this by adding a space character in the pattern.\n\nFixes: a4bcd61de82d (\"buildtools: add script to check experimental API exports\")\nCc: stable@dpdk.org\n\nReported-by: Andrew Rybchenko <arybchenko@solarflare.com>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n buildtools/check-experimental-syms.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh\nindex abebb89f12..f3603e5bac 100755\n--- a/buildtools/check-experimental-syms.sh\n+++ b/buildtools/check-experimental-syms.sh\n@@ -25,8 +25,8 @@ objdump -t $OBJFILE >$DUMPFILE\n ret=0\n for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3`\n do\n-\tif grep -q \"\\.text.*$SYM$\" $DUMPFILE &&\n-\t\t! grep -q \"\\.text\\.experimental.*$SYM$\" $DUMPFILE\n+\tif grep -q \"\\.text.*[[:space:]]$SYM$\" $DUMPFILE &&\n+\t\t! grep -q \"\\.text\\.experimental.*[[:space:]]$SYM$\" $DUMPFILE\n \tthen\n \t\tcat >&2 <<- END_OF_MESSAGE\n \t\t$SYM is not flagged as experimental\n", "prefixes": [ "2/2" ] }