Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64759/?format=api
{ "id": 64759, "url": "http://patchwork.dpdk.org/api/patches/64759/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200116092706.17388-3-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200116092706.17388-3-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200116092706.17388-3-huwei013@chinasoftinc.com", "date": "2020-01-16T09:27:04", "name": "[2/4] net/hns3: remove unnecessary input parameter valid judgement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3b683eab8437f7aa838b78f7e4b6c9cc737eed25", "submitter": { "id": 1537, "url": "http://patchwork.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200116092706.17388-3-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 8153, "url": "http://patchwork.dpdk.org/api/series/8153/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=8153", "date": "2020-01-16T09:27:02", "name": "improvement and cleanup for hns3 PMD driver", "version": 1, "mbox": "http://patchwork.dpdk.org/series/8153/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/64759/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/64759/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 121CDA0352;\n\tThu, 16 Jan 2020 10:27:36 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A28D21C1E3;\n\tThu, 16 Jan 2020 10:27:22 +0100 (CET)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 7414A1C1C4\n for <dev@dpdk.org>; Thu, 16 Jan 2020 10:27:17 +0100 (CET)", "from mail.chinasoftinc.com (inccas001.ito.icss [10.168.0.51]) by\n incedge.chinasoftinc.com with ESMTP id 03lpIfTLv9iNBXH7 (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;\n Thu, 16 Jan 2020 17:27:14 +0800 (CST)", "from localhost.localdomain (203.160.91.226) by INCCAS001.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.439.0; Thu, 16 Jan 2020\n 17:27:14 +0800" ], "X-ASG-Debug-ID": "1579166833-0a3dd17c8806fb0004-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.51", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 16 Jan 2020 17:27:04 +0800", "X-ASG-Orig-Subj": "[PATCH 2/4] net/hns3: remove unnecessary input parameter\n valid judgement", "Message-ID": "<20200116092706.17388-3-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20200116092706.17388-1-huwei013@chinasoftinc.com>", "References": "<20200116092706.17388-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[203.160.91.226]", "X-Barracuda-Connect": "inccas001.ito.icss[10.168.0.51]", "X-Barracuda-Start-Time": "1579166834", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://spam.chinasoftinc.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "951", "Subject": "[dpdk-dev] [PATCH 2/4] net/hns3: remove unnecessary input parameter\n\tvalid judgement", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lijun Ou <oulijun@huawei.com>\n\nSince the input parameter named dev has been guaranteed not to be NULL\nin the rte layer of DPDK framework, it doesn't need to check dev whether\nis null in the 'filter_ctrl' ops implementation function named\nhns3_dev_filter_ctrl.\n\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex aa614175d..98affa567 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1887,8 +1887,6 @@ hns3_dev_filter_ctrl(struct rte_eth_dev *dev, enum rte_filter_type filter_type,\n \tstruct hns3_hw *hw;\n \tint ret = 0;\n \n-\tif (dev == NULL)\n-\t\treturn -EINVAL;\n \thw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tswitch (filter_type) {\n \tcase RTE_ETH_FILTER_GENERIC:\n", "prefixes": [ "2/4" ] }