Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65039/?format=api
{ "id": 65039, "url": "http://patchwork.dpdk.org/api/patches/65039/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/dcc91827e7ef417a1c0e5a2a7b793233d36f6ca1.1579703134.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<dcc91827e7ef417a1c0e5a2a7b793233d36f6ca1.1579703134.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/dcc91827e7ef417a1c0e5a2a7b793233d36f6ca1.1579703134.git.dekelp@mellanox.com", "date": "2020-01-22T14:27:16", "name": "[04/11] net/mlx5: fix allow push VLAN without VID value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "75c630a0898567ca4022997cea3a80ab9144a578", "submitter": { "id": 1082, "url": "http://patchwork.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/dcc91827e7ef417a1c0e5a2a7b793233d36f6ca1.1579703134.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 8260, "url": "http://patchwork.dpdk.org/api/series/8260/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=8260", "date": "2020-01-22T14:27:13", "name": "net/mlx5: vlan actions validation fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/8260/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/65039/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/65039/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE284A0530;\n\tWed, 22 Jan 2020 15:30:48 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 27B394C90;\n\tWed, 22 Jan 2020 15:30:10 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id E209C3576\n for <dev@dpdk.org>; Wed, 22 Jan 2020 15:30:02 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 22 Jan 2020 16:29:57 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.128.130.87])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00METnL2010555;\n Wed, 22 Jan 2020 16:29:57 +0200" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "matan@mellanox.com, viacheslavo@mellanox.com", "Cc": "rasland@mellanox.com, orika@mellanox.com, dev@dpdk.org, stable@dpdk.org", "Date": "Wed, 22 Jan 2020 16:27:16 +0200", "Message-Id": "\n <dcc91827e7ef417a1c0e5a2a7b793233d36f6ca1.1579703134.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1579703134.git.dekelp@mellanox.com>", "References": "<cover.1579703134.git.dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 04/11] net/mlx5: fix allow push VLAN without VID\n\tvalue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently the push VLAN action requires a VID value, either from\nexisting VLAN item, or from following 'set VLAN vid' action.\n\nThis patch removes this limitation, allowing a push VLAN action with\nvid value 0.\n\nFixes: b8c0372bc5ac (\"net/mlx5: fix set VLAN ID/PCP in new header\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\nAcked-by: Ori Kam <orika@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 10 +---------\n 1 file changed, 1 insertion(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex d7176c8..59ece01 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1734,7 +1734,7 @@ struct field_modify_info modify_tcp[] = {\n */\n static int\n flow_dv_validate_action_push_vlan(uint64_t action_flags,\n-\t\t\t\t uint64_t item_flags,\n+\t\t\t\t uint64_t item_flags __rte_unused,\n \t\t\t\t const struct rte_flow_action *action,\n \t\t\t\t const struct rte_flow_attr *attr,\n \t\t\t\t struct rte_flow_error *error)\n@@ -1751,14 +1751,6 @@ struct field_modify_info modify_tcp[] = {\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, action,\n \t\t\t\t\t \"no support for multiple VLAN \"\n \t\t\t\t\t \"actions\");\n-\tif (!mlx5_flow_find_action\n-\t\t\t(action + 1, RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID) &&\n-\t !(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN))\n-\t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n-\t\t\t\t\"push VLAN needs to match on VLAN in order to \"\n-\t\t\t\t\"get VLAN VID information because there is \"\n-\t\t\t\t\"no followed set VLAN VID action\");\n \tif (action_flags & MLX5_FLOW_ACTION_PORT_ID)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, action,\n", "prefixes": [ "04/11" ] }