Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65041/?format=api
{ "id": 65041, "url": "http://patchwork.dpdk.org/api/patches/65041/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/b7d807dc8a0b38f7bff789a47d9fc7712b440e14.1579703134.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b7d807dc8a0b38f7bff789a47d9fc7712b440e14.1579703134.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b7d807dc8a0b38f7bff789a47d9fc7712b440e14.1579703134.git.dekelp@mellanox.com", "date": "2020-01-22T14:27:20", "name": "[08/11] net/mlx5: fix pop VLAN action validation function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "033282f2f0cf69bebf7b2404138cdcead9d3e446", "submitter": { "id": 1082, "url": "http://patchwork.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/b7d807dc8a0b38f7bff789a47d9fc7712b440e14.1579703134.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 8260, "url": "http://patchwork.dpdk.org/api/series/8260/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=8260", "date": "2020-01-22T14:27:13", "name": "net/mlx5: vlan actions validation fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/8260/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/65041/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/65041/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F81BA0530;\n\tWed, 22 Jan 2020 15:31:12 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CC1B71BE83;\n\tWed, 22 Jan 2020 15:30:14 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id CD3173977\n for <dev@dpdk.org>; Wed, 22 Jan 2020 15:30:03 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 22 Jan 2020 16:30:01 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.128.130.87])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00METnL6010555;\n Wed, 22 Jan 2020 16:30:01 +0200" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "matan@mellanox.com, viacheslavo@mellanox.com", "Cc": "rasland@mellanox.com, orika@mellanox.com, dev@dpdk.org, stable@dpdk.org", "Date": "Wed, 22 Jan 2020 16:27:20 +0200", "Message-Id": "\n <b7d807dc8a0b38f7bff789a47d9fc7712b440e14.1579703134.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1579703134.git.dekelp@mellanox.com>", "References": "<cover.1579703134.git.dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 08/11] net/mlx5: fix pop VLAN action validation\n\tfunction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Validation function of 'POP VLAN' action includes check for other\n'POP VLAN' actions present in flow.\nIt doesn't check for 'PUSH VLAN' actions present in flow.\n\nThis patch adds check for 'PUSH VLAN' actions present in flow.\n\nFixes: b41e47da2592 (\"net/mlx5: support pop flow action on VLAN header\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\nAcked-by: Ori Kam <orika@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 13 +++----------\n 1 file changed, 3 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 9dc08ce..de4b765 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1640,17 +1640,10 @@ struct field_modify_info modify_tcp[] = {\n \t\t\t\t\t NULL,\n \t\t\t\t\t \"pop vlan action not supported for \"\n \t\t\t\t\t \"egress\");\n-\t/*\n-\t * Check for inconsistencies:\n-\t * fail strip_vlan in a flow that matches packets without VLAN tags.\n-\t * fail strip_vlan in a flow that matches packets without explicitly a\n-\t * matching on VLAN tag ?\n-\t */\n-\tif (action_flags & MLX5_FLOW_ACTION_OF_POP_VLAN)\n+\tif (action_flags & MLX5_FLOW_VLAN_ACTIONS)\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t\t NULL,\n-\t\t\t\t\t \"no support for multiple vlan pop \"\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t\t \"no support for multiple VLAN \"\n \t\t\t\t\t \"actions\");\n \tif (!(item_flags & MLX5_FLOW_LAYER_OUTER_VLAN))\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n", "prefixes": [ "08/11" ] }