Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/661/?format=api
{ "id": 661, "url": "http://patchwork.dpdk.org/api/patches/661/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1412058028-10971-7-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1412058028-10971-7-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1412058028-10971-7-git-send-email-helin.zhang@intel.com", "date": "2014-09-30T06:20:27", "name": "[dpdk-dev,v3,6/7] i40e: Use constant random hash keys", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4ce75dedf3ab186b32a5b29e6c66ecd0819fa6ee", "submitter": { "id": 14, "url": "http://patchwork.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1412058028-10971-7-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/661/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/661/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C94076AAE;\n\tTue, 30 Sep 2014 08:14:23 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 3CBFD7E71\n\tfor <dev@dpdk.org>; Tue, 30 Sep 2014 08:14:17 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 29 Sep 2014 23:18:41 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 29 Sep 2014 23:20:47 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id s8U6KjGp003464;\n\tTue, 30 Sep 2014 14:20:45 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s8U6KgS9011049; Tue, 30 Sep 2014 14:20:44 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s8U6KgYU011045; \n\tTue, 30 Sep 2014 14:20:42 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,625,1406617200\"; d=\"scan'208\";a=\"610692302\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 30 Sep 2014 14:20:27 +0800", "Message-Id": "<1412058028-10971-7-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1412058028-10971-1-git-send-email-helin.zhang@intel.com>", "References": "<1412058028-10971-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 6/7] i40e: Use constant random hash keys", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To be simpler, and remove the race condition, it uses prepared\nconstant random hash keys to replace runtime generating the\nhash keys.\n\nv3 changes:\n* Use prepared random hash keys.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nAcked-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex f23e0bf..87a5f4d 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -211,9 +211,6 @@ static int i40e_dev_filter_ctrl(struct rte_eth_dev *dev,\n \t\t\t\tvoid *arg);\n static void i40e_hw_init(struct i40e_hw *hw);\n \n-/* Default hash key buffer for RSS */\n-static uint32_t rss_key_default[I40E_PFQF_HKEY_MAX_INDEX + 1];\n-\n static struct rte_pci_id pci_id_i40e_map[] = {\n #define RTE_PCI_DEV_ID_DECL_I40E(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n #include \"rte_pci_dev_ids.h\"\n@@ -4113,9 +4110,12 @@ i40e_pf_config_rss(struct i40e_pf *pf)\n \t}\n \tif (rss_conf.rss_key == NULL || rss_conf.rss_key_len <\n \t\t(I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t)) {\n-\t\t/* Calculate the default hash key */\n-\t\tfor (i = 0; i <= I40E_PFQF_HKEY_MAX_INDEX; i++)\n-\t\t\trss_key_default[i] = (uint32_t)rte_rand();\n+\t\t/* Random default keys */\n+\t\tstatic uint32_t rss_key_default[] = {0x6b793944,\n+\t\t\t0x23504cb5, 0x5bea75b6, 0x309f4f12, 0x3dc0a2b8,\n+\t\t\t0x024ddcdf, 0x339b8ca0, 0x4c4af64a, 0x34fac605,\n+\t\t\t0x55d85839, 0x3a58997d, 0x2ec938e1, 0x66031581};\n+\n \t\trss_conf.rss_key = (uint8_t *)rss_key_default;\n \t\trss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *\n \t\t\t\t\t\t\tsizeof(uint32_t);\n", "prefixes": [ "dpdk-dev", "v3", "6/7" ] }