Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/662/?format=api
{ "id": 662, "url": "http://patchwork.dpdk.org/api/patches/662/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20140930093400.GA18200@BRICHA3-MOBL/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20140930093400.GA18200@BRICHA3-MOBL>", "list_archive_url": "https://inbox.dpdk.org/dev/20140930093400.GA18200@BRICHA3-MOBL", "date": "2014-09-30T09:34:01", "name": "[dpdk-dev] Building current 1.8.1-rc1 with clang", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "2c6bebb989c76430f434897a7ef12784e88a14d7", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20140930093400.GA18200@BRICHA3-MOBL/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/662/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/662/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4B1EE6A87;\n\tTue, 30 Sep 2014 11:28:02 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 5DDE76A7D\n\tfor <dev@dpdk.org>; Tue, 30 Sep 2014 11:28:00 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 30 Sep 2014 02:34:38 -0700", "from bricha3-mobl.ger.corp.intel.com (HELO\n\tbricha3-mobl.ir.intel.com) ([10.243.20.27])\n\tby fmsmga002.fm.intel.com with SMTP; 30 Sep 2014 02:34:02 -0700", "by bricha3-mobl.ir.intel.com (sSMTP sendmail emulation);\n\tTue, 30 Sep 2014 10:34:01 +0001" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,625,1406617200\"; d=\"scan'208\";a=\"607454552\"", "Date": "Tue, 30 Sep 2014 10:34:01 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "\"Wiles, Roger Keith\" <keith.wiles@windriver.com>", "Message-ID": "<20140930093400.GA18200@BRICHA3-MOBL>", "References": "<A07EB24F-3F3B-4783-BE9B-5E5AA0FD08D9@windriver.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<A07EB24F-3F3B-4783-BE9B-5E5AA0FD08D9@windriver.com>", "Organization": "Intel Shannon Ltd.", "User-Agent": "Mutt/1.5.22 (2013-10-16)", "Cc": "\"<dev@dpdk.org>\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] Building current 1.8.1-rc1 with clang", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On Mon, Sep 29, 2014 at 09:50:34PM +0000, Wiles, Roger Keith wrote:\n> I just pulled the current repo and stated a build with ‘make install T=x86_64-native-linuxapp-clang’ which produced the following error. I do not think I am allowed to modify this file, correct? If that is the case then someone will have to update the original source. If you want me to submit a patch I can, but I do not think I fully understand what needs to be done. \n> \n> From what I can tell the line:\n> \tdma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);\n> needs to be:\n> \tdma_addr0 = _mm_setzero_si128();\n> \n> == Build lib/librte_pmd_ixgbe\n> CC ixgbe_common.o\n> CC ixgbe_82598.o\n> CC ixgbe_82599.o\n> CC ixgbe_x540.o\n> CC ixgbe_phy.o\n> CC ixgbe_api.o\n> CC ixgbe_vf.o\n> CC ixgbe_dcb.o\n> CC ixgbe_dcb_82599.o\n> CC ixgbe_dcb_82598.o\n> CC ixgbe_mbx.o\n> CC ixgbe_rxtx.o\n> CC ixgbe_ethdev.o\n> CC ixgbe_fdir.o\n> CC ixgbe_pf.o\n> CC ixgbe_rxtx_vec.o\n> /home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30: error: variable 'dma_addr0' is uninitialized\n> when used here [-Werror,-Wuninitialized]\n> dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);\n> ^~~~~~~~~\n> /home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:57:2: note: variable 'dma_addr0' is declared here\n> __m128i dma_addr0, dma_addr1;\n> ^\n> 1 error generated.\n> make[5]: *** [ixgbe_rxtx_vec.o] Error 1\n> make[4]: *** [librte_pmd_ixgbe] Error 2\n> make[3]: *** [lib] Error 2\n> make[2]: *** [all] Error 2\n> make[1]: *** [x86_64-native-linuxapp-clang_install] Error 2\n> make: *** [install] Error 2\n> \n> Thanks\n> ++Keith\n> \n> Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533\n> \n\nI think a simple one-line change like below should fix it. The xor can also \nbe written as a setzero call.\n\n\n/Bruce", "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c \nb/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\nindex 457f267..2236250 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c\n@@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq)\n\t\t\t\t RTE_IXGBE_RXQ_REARM_THRESH) < 0) {\n\t\tif (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >=\n\t\t rxq->nb_rx_desc) {\n- dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);\n+ dma_addr0 = _mm_setzero_si128();\n\t\t\tfor (i = 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) {\n\t\t\t\trxep[i].mbuf = &rxq->fake_mbuf;\n\t\t\t\t_mm_store_si128((__m128i *)&rxdp[i].read,\n", "prefixes": [ "dpdk-dev" ] }