Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66215/?format=api
{ "id": 66215, "url": "http://patchwork.dpdk.org/api/patches/66215/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200303132512.4138303-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200303132512.4138303-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200303132512.4138303-1-ferruh.yigit@intel.com", "date": "2020-03-03T13:25:12", "name": "log: add API to check if a logtype can log in a given level", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5798ee962ccc54dee654ba3537cc9183fbf6e018", "submitter": { "id": 324, "url": "http://patchwork.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200303132512.4138303-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 8763, "url": "http://patchwork.dpdk.org/api/series/8763/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=8763", "date": "2020-03-03T13:25:12", "name": "log: add API to check if a logtype can log in a given level", "version": 1, "mbox": "http://patchwork.dpdk.org/series/8763/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/66215/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/66215/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 66875A0572;\n\tTue, 3 Mar 2020 14:25:19 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A200A1BFEF;\n\tTue, 3 Mar 2020 14:25:18 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 9AC892BA8\n for <dev@dpdk.org>; Tue, 3 Mar 2020 14:25:16 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 03 Mar 2020 05:25:15 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by orsmga007.jf.intel.com with ESMTP; 03 Mar 2020 05:25:13 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,511,1574150400\"; d=\"scan'208\";a=\"228905655\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>", "Cc": "dev@dpdk.org,\n\tFerruh Yigit <ferruh.yigit@intel.com>", "Date": "Tue, 3 Mar 2020 13:25:12 +0000", "Message-Id": "<20200303132512.4138303-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] log: add API to check if a logtype can log in a\n\tgiven level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is a helper function in case components would like to do more work\nthan just logging a message based on log level, like for example\ncollecting some stats if the log type is DEBUG etc..\n\nA few existing relevant usage converted to this new API.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/bus/fslmc/fslmc_bus.c | 7 +------\n drivers/common/qat/qat_logs.c | 7 ++-----\n drivers/net/enic/enic_fm_flow.c | 2 +-\n drivers/net/mlx5/mlx5_mr.c | 2 +-\n lib/librte_eal/common/eal_common_log.c | 18 ++++++++++++++++++\n lib/librte_eal/common/include/rte_log.h | 13 +++++++++++++\n lib/librte_eal/rte_eal_version.map | 3 +++\n lib/librte_flow_classify/rte_flow_classify.c | 7 ++-----\n 8 files changed, 41 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex b3e964aa9..afbd82e8d 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -115,14 +115,9 @@ static void\n dump_device_list(void)\n {\n \tstruct rte_dpaa2_device *dev;\n-\tuint32_t global_log_level;\n-\tint local_log_level;\n \n \t/* Only if the log level has been set to Debugging, print list */\n-\tglobal_log_level = rte_log_get_global_level();\n-\tlocal_log_level = rte_log_get_level(dpaa2_logtype_bus);\n-\tif (global_log_level == RTE_LOG_DEBUG ||\n-\t local_log_level == RTE_LOG_DEBUG) {\n+\tif (rte_log_can_log(dpaa2_logtype_bus, RTE_LOG_DEBUG)) {\n \t\tDPAA2_BUS_LOG(DEBUG, \"List of devices scanned on bus:\");\n \t\tTAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {\n \t\t\tDPAA2_BUS_LOG(DEBUG, \"\\t\\t%s\", dev->device.name);\ndiff --git a/drivers/common/qat/qat_logs.c b/drivers/common/qat/qat_logs.c\nindex f97aba19d..dfd0cbe5d 100644\n--- a/drivers/common/qat/qat_logs.c\n+++ b/drivers/common/qat/qat_logs.c\n@@ -14,12 +14,9 @@ int\n qat_hexdump_log(uint32_t level, uint32_t logtype, const char *title,\n \t\tconst void *buf, unsigned int len)\n {\n-\tif (level > rte_log_get_global_level())\n-\t\treturn 0;\n-\tif (level > (uint32_t)(rte_log_get_level(logtype)))\n-\t\treturn 0;\n+\tif (rte_log_can_log(logtype, level))\n+\t\trte_hexdump(rte_log_get_stream(), title, buf, len);\n \n-\trte_hexdump(rte_log_get_stream(), title, buf, len);\n \treturn 0;\n }\n \ndiff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c\nindex c0ddfe9ba..d815f369e 100644\n--- a/drivers/net/enic/enic_fm_flow.c\n+++ b/drivers/net/enic/enic_fm_flow.c\n@@ -1504,7 +1504,7 @@ enic_fm_dump_tcam_entry(const struct fm_tcam_match_entry *fm_match,\n \t\t\tconst struct fm_action *fm_action,\n \t\t\tuint8_t ingress)\n {\n-\tif (rte_log_get_level(enic_pmd_logtype) < (int)RTE_LOG_DEBUG)\n+\tif (!rte_log_can_log(enic_pmd_logtype, RTE_LOG_DEBUG))\n \t\treturn;\n \tenic_fm_dump_tcam_match(fm_match, ingress);\n \tenic_fm_dump_tcam_actions(fm_action);\ndiff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c\nindex cb97c876e..6aa578646 100644\n--- a/drivers/net/mlx5/mlx5_mr.c\n+++ b/drivers/net/mlx5/mlx5_mr.c\n@@ -1597,7 +1597,7 @@ mlx5_mr_release(struct mlx5_ibv_shared *sh)\n {\n \tstruct mlx5_mr *mr_next;\n \n-\tif (rte_log_get_level(mlx5_logtype) == RTE_LOG_DEBUG)\n+\tif (rte_log_can_log(mlx5_logtype, RTE_LOG_DEBUG))\n \t\tmlx5_mr_dump_dev(sh);\n \trte_rwlock_write_lock(&sh->mr.rwlock);\n \t/* Detach from MR list and move to free list. */\ndiff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex c0efd5214..5b91ae31b 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -112,6 +112,24 @@ rte_log_get_level(uint32_t type)\n \treturn rte_logs.dynamic_types[type].loglevel;\n }\n \n+int\n+rte_log_can_log(uint32_t logtype, uint32_t level)\n+{\n+\tint log_level;\n+\n+\tif (level > rte_log_get_global_level())\n+\t\treturn 0;\n+\n+\tlog_level = rte_log_get_level(logtype);\n+\tif (log_level < 0)\n+\t\treturn 0;\n+\n+\tif (level > (uint32_t)log_level)\n+\t\treturn 0;\n+\n+\treturn 1;\n+}\n+\n int\n rte_log_set_level(uint32_t type, uint32_t level)\n {\ndiff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h\nindex 1bb0e6694..56e8952e5 100644\n--- a/lib/librte_eal/common/include/rte_log.h\n+++ b/lib/librte_eal/common/include/rte_log.h\n@@ -143,6 +143,19 @@ uint32_t rte_log_get_global_level(void);\n */\n int rte_log_get_level(uint32_t logtype);\n \n+/**\n+ * Check if a given `level` can be printed by a given `logtype`\n+ *\n+ * @param logtype\n+ * The log type identifier\n+ * @param level\n+ * Log level. A value between RTE_LOG_EMERG (1) and RTE_LOG_DEBUG (8).\n+ * @return\n+ * Returns '1' if log can be printed and '0' if it can't.\n+ */\n+__rte_experimental\n+int rte_log_can_log(uint32_t logtype, uint32_t level);\n+\n /**\n * Set the log level for a given type based on shell pattern.\n *\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 6cf507068..f9ede5b41 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -335,4 +335,7 @@ EXPERIMENTAL {\n \n \t# added in 20.02\n \trte_thread_is_intr;\n+\n+\t# added in 20.05\n+\trte_log_can_log;\n };\ndiff --git a/lib/librte_flow_classify/rte_flow_classify.c b/lib/librte_flow_classify/rte_flow_classify.c\nindex 5ff585803..6022064d8 100644\n--- a/lib/librte_flow_classify/rte_flow_classify.c\n+++ b/lib/librte_flow_classify/rte_flow_classify.c\n@@ -417,7 +417,6 @@ static struct rte_flow_classify_rule *\n allocate_acl_ipv4_5tuple_rule(struct rte_flow_classifier *cls)\n {\n \tstruct rte_flow_classify_rule *rule;\n-\tint log_level;\n \n \trule = malloc(sizeof(struct rte_flow_classify_rule));\n \tif (!rule)\n@@ -466,9 +465,7 @@ allocate_acl_ipv4_5tuple_rule(struct rte_flow_classifier *cls)\n \t\t\tcls->ntuple_filter.dst_port_mask;\n \trule->rules.u.ipv4_5tuple.dst_port = cls->ntuple_filter.dst_port;\n \n-\tlog_level = rte_log_get_level(librte_flow_classify_logtype);\n-\n-\tif (log_level == RTE_LOG_DEBUG)\n+\tif (rte_log_can_log(librte_flow_classify_logtype, RTE_LOG_DEBUG))\n \t\tprint_acl_ipv4_key_add(&rule->u.key.key_add);\n \n \t/* key delete values */\n@@ -476,7 +473,7 @@ allocate_acl_ipv4_5tuple_rule(struct rte_flow_classifier *cls)\n \t &rule->u.key.key_add.field_value[PROTO_FIELD_IPV4],\n \t NUM_FIELDS_IPV4 * sizeof(struct rte_acl_field));\n \n-\tif (log_level == RTE_LOG_DEBUG)\n+\tif (rte_log_can_log(librte_flow_classify_logtype, RTE_LOG_DEBUG))\n \t\tprint_acl_ipv4_key_delete(&rule->u.key.key_del);\n \n \treturn rule;\n", "prefixes": [] }