Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66309/?format=api
{ "id": 66309, "url": "http://patchwork.dpdk.org/api/patches/66309/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200305222333.18784-1-vladz@scylladb.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200305222333.18784-1-vladz@scylladb.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200305222333.18784-1-vladz@scylladb.com", "date": "2020-03-05T22:23:33", "name": "[v1] ena_ethdev: don't override the user provided queue length value", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "6bd5975fe8d1dedcdc66bf63424322d75dbba481", "submitter": { "id": 912, "url": "http://patchwork.dpdk.org/api/people/912/?format=api", "name": "Vladislav Zolotarov", "email": "vladz@scylladb.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200305222333.18784-1-vladz@scylladb.com/mbox/", "series": [ { "id": 8803, "url": "http://patchwork.dpdk.org/api/series/8803/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=8803", "date": "2020-03-05T22:23:33", "name": "[v1] ena_ethdev: don't override the user provided queue length value", "version": 1, "mbox": "http://patchwork.dpdk.org/series/8803/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/66309/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/66309/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7FBCDA056A;\n\tThu, 5 Mar 2020 23:23:39 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B67422BB8;\n\tThu, 5 Mar 2020 23:23:38 +0100 (CET)", "from mail-qt1-f193.google.com (mail-qt1-f193.google.com\n [209.85.160.193]) by dpdk.org (Postfix) with ESMTP id 414132BA8\n for <dev@dpdk.org>; Thu, 5 Mar 2020 23:23:38 +0100 (CET)", "by mail-qt1-f193.google.com with SMTP id a4so297624qto.12\n for <dev@dpdk.org>; Thu, 05 Mar 2020 14:23:38 -0800 (PST)", "from localhost.localdomain (ool-2f14799e.dyn.optonline.net.\n [47.20.121.158])\n by smtp.googlemail.com with ESMTPSA id o23sm6820280qtt.19.2020.03.05.14.23.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 Mar 2020 14:23:36 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=scylladb-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=1jZtoRYbVXDrwh/2SsGuuQ+1S73qrTlqis8A9SuO83E=;\n b=YJzCpnxeTzLkbGVSG2DLH7DKyC+jZ+IVVNBQCa+7ysGwZLEWmubh2wts0EPt4XGvEK\n MWUegFeyKrEdK4CHjD72DWztQ6EwR2ZYfrFwwDgE9a2R5crWO7xP3a2ZV32eApkzonra\n dlMmMEkXgl9hqTvVQ5aGHq0axDkEryYg44KL8h66vSpw4vJdRExTDx2E1rxF4uM2RL9i\n a6d8VeKpuecFRADn4UTLLnUYabhsblQ3AydvEvpk6VidRt27G4qaJER6RR5J04mRbk23\n qHZ2aGDctqgFMNThZFrbmtdo4HFhlWb9NNoHUnrEyC5i1rGw3kWz8tbZbS5qeJcljyXt\n WWig==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=1jZtoRYbVXDrwh/2SsGuuQ+1S73qrTlqis8A9SuO83E=;\n b=m1Cfk9KD5kkxKCaTOtxQ5tRBk2CTrRYIpGMNSOWoYzfdxg+8/A7ObQFvVnUDFx19CD\n LNKcSR/ZJiLqrg6TBVwtTO7yghQF/srzEhbNim7hfS8i5ABmIAn/5o5jTD753Cz2tJsJ\n /ogwqbS9rwekMNmrElPVDLAwT5FVhtI1Am4Ow4BwtvThGA0um9daxUKzzW60op2tyMxU\n Df9DDL6j5sC8odx7vuLZLgKY8JsSYyh4ytC59248FMfHvlnKipiNZHq7P2WCWtYAyjcW\n vO2QhcMJ+x6mDcTEk9kkezdYVk4JldTDrpHRPPG72fE7g34k8tTmkDwwOo1rPlfRbIlz\n PeBQ==", "X-Gm-Message-State": "ANhLgQ1YcteylAEkwNCJWvj4mEbu78T3d3bZSA5eJZFEtmLS+wPTor60\n NIuZ0yNojrM50xUVnZY1T5ImJRC/4E64IQ==", "X-Google-Smtp-Source": "\n ADFU+vsIvXxQSvMcXIsJfmr89iSK9QNehKb+cyG66XPkwnPxLANhNCq9GGlz03IYPDdUozjsfNAi2A==", "X-Received": "by 2002:aed:2519:: with SMTP id v25mr403743qtc.176.1583447016972;\n Thu, 05 Mar 2020 14:23:36 -0800 (PST)", "From": "Vlad Zolotarov <vladz@scylladb.com>", "To": "dev@dpdk.org", "Cc": "Vlad Zolotarov <vladz@scylladb.com>", "Date": "Thu, 5 Mar 2020 17:23:33 -0500", "Message-Id": "<20200305222333.18784-1-vladz@scylladb.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] ena_ethdev: don't override the user provided\n\tqueue length value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is a funny logic that seems to be outdated which tries to detect\na situation when a user requests a default size of the queue and\nconfigures a device specific default value.\n\nThis seems to be not in line with the DPDK current design that expects\nthe user to go via the rte_eth_dev_info_get() in order to get device\nspecific values.\n\nAnd if the user doesn't care it should pass 0 as a queue length and this\ncase is also being taken care of on the rte_eth level.\n\nSigned-off-by: Vlad Zolotarov <vladz@scylladb.com>\n---\n drivers/net/ena/ena_ethdev.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 665afee4f..bf632dee0 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1221,9 +1221,6 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (nb_desc == RTE_ETH_DEV_FALLBACK_TX_RINGSIZE)\n-\t\tnb_desc = adapter->tx_ring_size;\n-\n \ttxq->port_id = dev->data->port_id;\n \ttxq->next_to_clean = 0;\n \ttxq->next_to_use = 0;\n@@ -1292,9 +1289,6 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,\n \t\treturn ENA_COM_FAULT;\n \t}\n \n-\tif (nb_desc == RTE_ETH_DEV_FALLBACK_RX_RINGSIZE)\n-\t\tnb_desc = adapter->rx_ring_size;\n-\n \tif (!rte_is_power_of_2(nb_desc)) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"Unsupported size of RX queue: %d is not a power of 2.\\n\",\n", "prefixes": [ "v1" ] }