Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66518/?format=api
http://patchwork.dpdk.org/api/patches/66518/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1583862551-2049-5-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1583862551-2049-5-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1583862551-2049-5-git-send-email-phil.yang@arm.com", "date": "2020-03-10T17:49:05", "name": "[04/10] ipsec: optimize with c11 atomic for sa outbound sqn update", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "109c4431b733adfdfa6feecbfe66f2173326be64", "submitter": { "id": 833, "url": "http://patchwork.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1583862551-2049-5-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 8875, "url": "http://patchwork.dpdk.org/api/series/8875/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=8875", "date": "2020-03-10T17:49:01", "name": "generic rte atomic APIs deprecate proposal", "version": 1, "mbox": "http://patchwork.dpdk.org/series/8875/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/66518/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/66518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB4E5A0567;\n\tTue, 10 Mar 2020 18:50:35 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A17B71C069;\n\tTue, 10 Mar 2020 18:50:11 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 3212A1C06A\n for <dev@dpdk.org>; Tue, 10 Mar 2020 18:50:10 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B014C1FB;\n Tue, 10 Mar 2020 10:50:09 -0700 (PDT)", "from phil-VirtualBox.arm.com (A010647.Arm.com [10.170.243.28])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 599FD3F534;\n Tue, 10 Mar 2020 10:50:06 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "thomas@monjalon.net, harry.van.haaren@intel.com,\n konstantin.ananyev@intel.com, stephen@networkplumber.org,\n maxime.coquelin@redhat.com, dev@dpdk.org", "Cc": "david.marchand@redhat.com, jerinj@marvell.com, hemant.agrawal@nxp.com,\n Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, ruifeng.wang@arm.com,\n joyce.kong@arm.com, nd@arm.com", "Date": "Wed, 11 Mar 2020 01:49:05 +0800", "Message-Id": "<1583862551-2049-5-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "References": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH 04/10] ipsec: optimize with c11 atomic for sa\n\toutbound sqn update", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For SA outbound packets, rte_atomic64_add_return is used to generate\nSQN atomically. This introduced an unnecessary full barrier by calling\nthe '__sync' builtin implemented rte_atomic_XX API on aarch64. This\npatch optimized it with c11 atomic and eliminated the expensive barrier\nfor aarch64.\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n lib/librte_ipsec/ipsec_sqn.h | 3 ++-\n lib/librte_ipsec/sa.h | 2 +-\n 2 files changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_ipsec/ipsec_sqn.h b/lib/librte_ipsec/ipsec_sqn.h\nindex 0c2f76a..e884af7 100644\n--- a/lib/librte_ipsec/ipsec_sqn.h\n+++ b/lib/librte_ipsec/ipsec_sqn.h\n@@ -128,7 +128,8 @@ esn_outb_update_sqn(struct rte_ipsec_sa *sa, uint32_t *num)\n \n \tn = *num;\n \tif (SQN_ATOMIC(sa))\n-\t\tsqn = (uint64_t)rte_atomic64_add_return(&sa->sqn.outb.atom, n);\n+\t\tsqn = __atomic_add_fetch(&sa->sqn.outb.atom, n,\n+\t\t\t__ATOMIC_RELAXED);\n \telse {\n \t\tsqn = sa->sqn.outb.raw + n;\n \t\tsa->sqn.outb.raw = sqn;\ndiff --git a/lib/librte_ipsec/sa.h b/lib/librte_ipsec/sa.h\nindex d22451b..cab9a2e 100644\n--- a/lib/librte_ipsec/sa.h\n+++ b/lib/librte_ipsec/sa.h\n@@ -120,7 +120,7 @@ struct rte_ipsec_sa {\n \t */\n \tunion {\n \t\tunion {\n-\t\t\trte_atomic64_t atom;\n+\t\t\tuint64_t atom;\n \t\t\tuint64_t raw;\n \t\t} outb;\n \t\tstruct {\n", "prefixes": [ "04/10" ] }{ "id": 66518, "url": "