Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66688/?format=api
{ "id": 66688, "url": "http://patchwork.dpdk.org/api/patches/66688/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200316153822.113182-1-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200316153822.113182-1-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200316153822.113182-1-yong.liu@intel.com", "date": "2020-03-16T15:38:22", "name": "vhost: fix packed ring zero-copy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3dd8268d8b919a6ada9d956982a3a6a6e63275bd", "submitter": { "id": 17, "url": "http://patchwork.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200316153822.113182-1-yong.liu@intel.com/mbox/", "series": [ { "id": 8920, "url": "http://patchwork.dpdk.org/api/series/8920/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=8920", "date": "2020-03-16T15:38:22", "name": "vhost: fix packed ring zero-copy", "version": 1, "mbox": "http://patchwork.dpdk.org/series/8920/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/66688/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/66688/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A9919A0559;\n\tMon, 16 Mar 2020 09:02:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 89D341C08D;\n\tMon, 16 Mar 2020 09:02:02 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 3FCBC1C025;\n Mon, 16 Mar 2020 09:02:01 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Mar 2020 01:02:00 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.58])\n by orsmga005.jf.intel.com with ESMTP; 16 Mar 2020 01:01:56 -0700" ], "IronPort-SDR": [ "\n 8usR0H/HjNP5JmrEutrKodj+sQ9RGwUfEj2lsLsMRawzVRI7NefG0sVYgWjcdcFe3EvulJraSi\n hfF9w5DmxnhA==", "\n 9scwgPXuBMHfxQmIPBPxulYndgIJ5hy3nXm2rLUkuHTzcrCNnEcIvSKBseKv72im7pGFHEwa1v\n mGMi3NJVkM2g==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,559,1574150400\"; d=\"scan'208\";a=\"417056899\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Mon, 16 Mar 2020 23:38:22 +0800", "Message-Id": "<20200316153822.113182-1-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] vhost: fix packed ring zero-copy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Available buffer ID should be stored in the zmbuf in the packed-ring\ndequeue path. There's no guarantee that local queue avail index is\nequal to buffer ID.\n\nFixes: d1eafb532268 (\"vhost: add packed ring zcopy batch and single dequeue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>\nReported-by: Yinan Wang <yinan.wang@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 37c47c7dc..210415904 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -2004,7 +2004,7 @@ virtio_dev_tx_batch_packed_zmbuf(struct virtio_net *dev,\n \n \tvhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {\n \t\tzmbufs[i]->mbuf = pkts[i];\n-\t\tzmbufs[i]->desc_idx = avail_idx + i;\n+\t\tzmbufs[i]->desc_idx = ids[i];\n \t\tzmbufs[i]->desc_count = 1;\n \t}\n \n@@ -2045,7 +2045,7 @@ virtio_dev_tx_single_packed_zmbuf(struct virtio_net *dev,\n \t\treturn -1;\n \t}\n \tzmbuf->mbuf = *pkts;\n-\tzmbuf->desc_idx = vq->last_avail_idx;\n+\tzmbuf->desc_idx = buf_id;\n \tzmbuf->desc_count = desc_count;\n \n \trte_mbuf_refcnt_update(*pkts, 1);\n", "prefixes": [] }