Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/677/?format=api
{ "id": 677, "url": "http://patchwork.dpdk.org/api/patches/677/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/7F861DC0615E0C47A872E6F3C5FCDDBD02AE2665@BPXM14GP.gisp.nec.co.jp/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<7F861DC0615E0C47A872E6F3C5FCDDBD02AE2665@BPXM14GP.gisp.nec.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/7F861DC0615E0C47A872E6F3C5FCDDBD02AE2665@BPXM14GP.gisp.nec.co.jp", "date": "2014-09-30T11:13:08", "name": "[dpdk-dev,memnic,v2,3/7] pmd: use helper macros", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d4b3c69025f5eb7b299bd8e49221fe04e8dd6455", "submitter": { "id": 38, "url": "http://patchwork.dpdk.org/api/people/38/?format=api", "name": "Hiroshi Shimamoto", "email": "h-shimamoto@ct.jp.nec.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/7F861DC0615E0C47A872E6F3C5FCDDBD02AE2665@BPXM14GP.gisp.nec.co.jp/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/677/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/677/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D2556678B;\n\tTue, 30 Sep 2014 13:10:28 +0200 (CEST)", "from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52])\n\tby dpdk.org (Postfix) with ESMTP id 4501A5902\n\tfor <dev@dpdk.org>; Tue, 30 Sep 2014 13:10:27 +0200 (CEST)", "from mailgate3.nec.co.jp ([10.7.69.160])\n\tby tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8UBH6oQ024876\n\tfor <dev@dpdk.org>; Tue, 30 Sep 2014 20:17:06 +0900 (JST)", "from mailsv.nec.co.jp (imss62.nec.co.jp [10.7.69.157]) by\n\tmailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP\n\tid s8UBH6200987 for <dev@dpdk.org>;\n\tTue, 30 Sep 2014 20:17:06 +0900 (JST)", "from mail02.kamome.nec.co.jp (mail02.kamome.nec.co.jp [10.25.43.5])\n\tby mailsv.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8UBH6A6024645\n\tfor <dev@dpdk.org>; Tue, 30 Sep 2014 20:17:06 +0900 (JST)", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.141] [10.38.151.141]) by\n\tmail01b.kamome.nec.co.jp with ESMTP id BT-MMP-2225109;\n\tTue, 30 Sep 2014 20:13:09 +0900", "from BPXM14GP.gisp.nec.co.jp ([169.254.1.136]) by\n\tBPXC13GP.gisp.nec.co.jp ([10.38.151.141]) with mapi id 14.03.0174.002;\n\tTue, 30 Sep 2014 20:13:08 +0900" ], "From": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[memnic PATCH v2 3/7] pmd: use helper macros", "Thread-Index": "Ac/cn3n2FqYy9gPKQp6qx2mbmpjsAw==", "Date": "Tue, 30 Sep 2014 11:13:08 +0000", "Message-ID": "<7F861DC0615E0C47A872E6F3C5FCDDBD02AE2665@BPXM14GP.gisp.nec.co.jp>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.205.5.123]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "Hayato Momma <h-momma@ce.jp.nec.com>", "Subject": "[dpdk-dev] [memnic PATCH v2 3/7] pmd: use helper macros", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>\n\nDo not touch pktmbuf directly.\n\nIntead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()\nto access the property.\n\nSigned-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>\nReviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>\n---\n pmd/pmd_memnic.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c\nindex bbb5380..872f3c4 100644\n--- a/pmd/pmd_memnic.c\n+++ b/pmd/pmd_memnic.c\n@@ -308,8 +308,8 @@ static uint16_t memnic_recv_pkts(void *rx_queue,\n \n \t\trte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);\n \t\tmb->pkt.in_port = q->port_id;\n-\t\tmb->pkt.pkt_len = p->len;\n-\t\tmb->pkt.data_len = p->len;\n+\t\trte_pktmbuf_pkt_len(mb) = p->len;\n+\t\trte_pktmbuf_data_len(mb) = p->len;\n \t\trx_pkts[nr] = mb;\n \n \t\tpkts++;\n@@ -394,7 +394,7 @@ retry:\n \t\tptr = p->data;\n \t\tfor (sg = tx_pkts[nr]; sg; sg = sg->pkt.next) {\n \t\t\tvoid *src = rte_pktmbuf_mtod(sg, void *);\n-\t\t\tint data_len = sg->pkt.data_len;\n+\t\t\tint data_len = rte_pktmbuf_data_len(sg);\n \n \t\t\trte_memcpy(ptr, src, data_len);\n \t\t\tptr += data_len;\n", "prefixes": [ "dpdk-dev", "memnic", "v2", "3/7" ] }