Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67876/?format=api
{ "id": 67876, "url": "http://patchwork.dpdk.org/api/patches/67876/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200407034550.1814-1-roland.qi@ucloud.cn/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200407034550.1814-1-roland.qi@ucloud.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/20200407034550.1814-1-roland.qi@ucloud.cn", "date": "2020-04-07T03:45:50", "name": "vhost: fix check peer close", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f11cc60dda149fe6d4f736f450b4f30411727308", "submitter": { "id": 1662, "url": "http://patchwork.dpdk.org/api/people/1662/?format=api", "name": "Roland Qi", "email": "roland.qi@ucloud.cn" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200407034550.1814-1-roland.qi@ucloud.cn/mbox/", "series": [ { "id": 9220, "url": "http://patchwork.dpdk.org/api/series/9220/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9220", "date": "2020-04-07T03:45:50", "name": "vhost: fix check peer close", "version": 1, "mbox": "http://patchwork.dpdk.org/series/9220/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/67876/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/67876/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82533A0577;\n\tTue, 7 Apr 2020 05:46:10 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C7EF82B86;\n\tTue, 7 Apr 2020 05:46:09 +0200 (CEST)", "from m9785.mail.qiye.163.com (m9785.mail.qiye.163.com\n [220.181.97.85]) by dpdk.org (Postfix) with ESMTP id 58B05FFA\n for <dev@dpdk.org>; Tue, 7 Apr 2020 05:46:08 +0200 (CEST)", "from localhost.localdomain (unknown [120.132.1.226])\n by m9785.mail.qiye.163.com (Hmail) with ESMTPA id 587085C17D8;\n Tue, 7 Apr 2020 11:46:04 +0800 (CST)" ], "From": "qikai <roland.qi@ucloud.cn>", "To": "dev@dpdk.org", "Cc": "qikai <roland.qi@ucloud.cn>", "Date": "Tue, 7 Apr 2020 11:45:50 +0800", "Message-Id": "<20200407034550.1814-1-roland.qi@ucloud.cn>", "X-Mailer": "git-send-email 2.23.0.windows.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-HM-Spam-Status": "e1kfGhgUHx5ZQUtXWQgYFAkeWUFZSVVDQkNCQkJCSUJPSUNKWVdZKFlBSU\n I3V1ktWUFJV1kJDhceCFlBWTU0KTY6NyQpLjc#WQY+", "X-HM-Sender-Digest": "e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6N006Kxw4Czg5QxQfQzhDIi4U\n Gj8KCklVSlVKTkNNSUhKSk1PTkNDVTMWGhIXVQkUFxoVH1UKEjsOGBcUDh9VGBVFWVdZEgtZQVlK\n SUtVSkhJVUpVSUlNWVdZCAFZQUpMTEg3Bg++", "X-HM-Tid": "0a7152bebe0e2087kuqy587085c17d8", "Subject": "[dpdk-dev] [PATCH] vhost: fix check peer close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In process_slave_message_reply(), there is a\npossibility that receiving a peer close\nmessage instead of a real message response.\n\nthis patch targeting to handle the peer close\nscenario and report the correct error message.\n\nSigned-off-by: qikai <roland.qi@ucloud.cn>\n---\n lib/librte_vhost/vhost_user.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex bd1be0104..971ccdb01 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -2812,11 +2812,19 @@ static int process_slave_message_reply(struct virtio_net *dev,\n \tif ((msg->flags & VHOST_USER_NEED_REPLY) == 0)\n \t\treturn 0;\n \n-\tif (read_vhost_message(dev->slave_req_fd, &msg_reply) < 0) {\n+\tret = read_vhost_message(dev->slave_req_fd, &msg_reply);\n+\tif (ret <= 0) {\n+\t\tif (ret < 0)\n+\t\t\tVHOST_LOG_CONFIG(ERR,\n+\t\t\t\t\"vhost read slave message reply failed\\n\");\n+\t\telse\n+\t\t\tVHOST_LOG_CONFIG(INFO,\n+\t\t\t\t\"vhost peer closed\\n\");\n \t\tret = -1;\n \t\tgoto out;\n \t}\n \n+\tret = 0;\n \tif (msg_reply.request.slave != msg->request.slave) {\n \t\tVHOST_LOG_CONFIG(ERR,\n \t\t\t\"Received unexpected msg type (%u), expected %u\\n\",\n", "prefixes": [] }