Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67916/?format=api
{ "id": 67916, "url": "http://patchwork.dpdk.org/api/patches/67916/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200407224758.57459-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200407224758.57459-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200407224758.57459-1-thomas@monjalon.net", "date": "2020-04-07T22:47:58", "name": "log: fix level picked with globbing on type register", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "882ff89db76e7a4196707ee548322b26d8fee451", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200407224758.57459-1-thomas@monjalon.net/mbox/", "series": [ { "id": 9237, "url": "http://patchwork.dpdk.org/api/series/9237/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9237", "date": "2020-04-07T22:47:58", "name": "log: fix level picked with globbing on type register", "version": 1, "mbox": "http://patchwork.dpdk.org/series/9237/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/67916/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/67916/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A4648A0588;\n\tWed, 8 Apr 2020 00:48:36 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 841FC1BFE6;\n\tWed, 8 Apr 2020 00:48:35 +0200 (CEST)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 39C6F1BFB7;\n Wed, 8 Apr 2020 00:48:34 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id C8A6A5C0196;\n Tue, 7 Apr 2020 18:48:33 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Tue, 07 Apr 2020 18:48:33 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 39E94306D616;\n Tue, 7 Apr 2020 18:48:32 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding; s=mesmtp; bh=XsXk9JIiG5j44th4t8d1pwm\n +wyInRGUpdy2UaaxsrDk=; b=RlX3dVeLWZLuOD7jwXW8PbGRUDM09HSK6o1nqob\n g3YHZAou/doqxrvzj5lD35JAoI55ynHyg5mAmbz1eGD+SaKbi+uqDJHFM/EbZsbQ\n WoS/5vq7IKGnU39qXzljj9yi1Dr9PG1cegkFb2bwEl+ViqI5Jq9F2OUE79Omik6w\n pfxk=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=XsXk9JIiG5j44th4t\n 8d1pwm+wyInRGUpdy2UaaxsrDk=; b=IzTYhokexZltuYGpxj/IAE/9GCF/YTsO+\n iOxqUfgAQQHkRGNwZVlNAMexuBGGq8UpNEUoNht0xniF18Xut6e1umTHE9quMQ1K\n us4ArBc4RibNagbuQ8iPTdneECmC8TmkJtLCDqpBeyvt3+oq1Eyqhl1zCRVElBl4\n q/rBEgAkUuoEr1XNNoblzYLM62wu327U8Sa1wkfnibmqgHcJnFd95TnsGCbCNj4i\n IIXQfx3ACCQGgtdv5BklcyyZRcmuB8bdmPvf3OyD5ok90k4ig7cvASqlbOCWOfOY\n HY6oS+9XvqTb0s71Sns6ULuUD7xobvff2icMu+fm+0L5B5C2UYDqA==" ], "X-ME-Sender": "<xms:QAONXoe483T0FB7nkhtQNcF4u4wXI32lhL2mWx-np7_CH_4I7pk2MA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduhedrudeigddugecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghsucfo\n ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepje\n ejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm\n pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:QQONXmKaRzuashka3Zrf5Svfbn9W0NP3QpVQeV6v7UKaRslbdfkPbQ>\n <xmx:QQONXvpjaqOly1sYSKsItXHZ7VRsKQmW9dpH4TrOpq4qcKKTiJZ8Cg>\n <xmx:QQONXkUGPUO0VoB5U-OeV1nD4Knfmjg6zNx-_UGwbvdCeIetudrXng>\n <xmx:QQONXoRjrEGDrWI_K1LYzWWrg3_9FnO7f4koIjdUaRQ2ZCZy1AHqSg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ivan.malov@oktetlabs.ru, arybchenko@solarflare.com,\n stephen@networkplumber.org, stable@dpdk.org,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Wed, 8 Apr 2020 00:47:58 +0200", "Message-Id": "<20200407224758.57459-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.26.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] log: fix level picked with globbing on type\n\tregister", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When a log type is registered, the level can be picked\nby matching saved options.\nThe check of fnmatch globbing result was reversed.\n\nThe same bug was already fixed in a similar function.\nThis one is acting in log type register function.\n\nNote: this function rte_log_register_type_and_pick_level()\nis not used a lot and could be merged with rte_log_register().\n\nFixes: 6ff0f81d0ef7 (\"log: fix pattern matching\")\nCc: stable@dpdk.org\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_eal/common/eal_common_log.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex 7647a916ef..d7a5f9b641 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -320,7 +320,7 @@ rte_log_register_type_and_pick_level(const char *name, uint32_t level_def)\n \t\t\tcontinue;\n \n \t\tif (opt_ll->pattern) {\n-\t\t\tif (fnmatch(opt_ll->pattern, name, 0))\n+\t\t\tif (fnmatch(opt_ll->pattern, name, 0) == 0)\n \t\t\t\tlevel = opt_ll->level;\n \t\t} else {\n \t\t\tif (regexec(&opt_ll->re_match, name, 0, NULL, 0) == 0)\n", "prefixes": [] }