Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/681/?format=api
{ "id": 681, "url": "http://patchwork.dpdk.org/api/patches/681/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/7F861DC0615E0C47A872E6F3C5FCDDBD02AE26EC@BPXM14GP.gisp.nec.co.jp/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<7F861DC0615E0C47A872E6F3C5FCDDBD02AE26EC@BPXM14GP.gisp.nec.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/7F861DC0615E0C47A872E6F3C5FCDDBD02AE26EC@BPXM14GP.gisp.nec.co.jp", "date": "2014-09-30T11:15:28", "name": "[dpdk-dev,memnic,v2,7/7] pmd: burst mbuf freeing in xmit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6af3996c746cd9f8d8bb0335305d635010906c70", "submitter": { "id": 38, "url": "http://patchwork.dpdk.org/api/people/38/?format=api", "name": "Hiroshi Shimamoto", "email": "h-shimamoto@ct.jp.nec.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/7F861DC0615E0C47A872E6F3C5FCDDBD02AE26EC@BPXM14GP.gisp.nec.co.jp/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/681/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/681/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 17B61678B;\n\tTue, 30 Sep 2014 13:12:07 +0200 (CEST)", "from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52])\n\tby dpdk.org (Postfix) with ESMTP id 0CAE85902\n\tfor <dev@dpdk.org>; Tue, 30 Sep 2014 13:12:04 +0200 (CEST)", "from mailgate3.nec.co.jp ([10.7.69.192])\n\tby tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8UBIih2025725\n\tfor <dev@dpdk.org>; Tue, 30 Sep 2014 20:18:44 +0900 (JST)", "from mailsv3.nec.co.jp (imss61.nec.co.jp [10.7.69.156]) by\n\tmailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP\n\tid s8UBIh312916 for <dev@dpdk.org>;\n\tTue, 30 Sep 2014 20:18:43 +0900 (JST)", "from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7])\n\tby mailsv3.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8UBIhqY010585\n\tfor <dev@dpdk.org>; Tue, 30 Sep 2014 20:18:43 +0900 (JST)", "from bpxc99gp.gisp.nec.co.jp ([10.38.151.143] [10.38.151.143]) by\n\tmail02.kamome.nec.co.jp with ESMTP id BT-MMP-2237357;\n\tTue, 30 Sep 2014 20:15:29 +0900", "from BPXM14GP.gisp.nec.co.jp ([169.254.1.136]) by\n\tBPXC15GP.gisp.nec.co.jp ([10.38.151.143]) with mapi id 14.03.0174.002;\n\tTue, 30 Sep 2014 20:15:29 +0900" ], "From": "Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[memnic PATCH v2 7/7] pmd: burst mbuf freeing in xmit", "Thread-Index": "Ac/cn8kgpoARSvwTQxOtJV/Ci3mq+w==", "Date": "Tue, 30 Sep 2014 11:15:28 +0000", "Message-ID": "<7F861DC0615E0C47A872E6F3C5FCDDBD02AE26EC@BPXM14GP.gisp.nec.co.jp>", "Accept-Language": "ja-JP, en-US", "Content-Language": "ja-JP", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.205.5.123]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "Hayato Momma <h-momma@ce.jp.nec.com>", "Subject": "[dpdk-dev] [memnic PATCH v2 7/7] pmd: burst mbuf freeing in xmit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>\n\nIn rte_pktmbuf_free(), there might be cache miss/memory stall issue.\nIn small packet case, it could harm the performance.\n\nFrom the result of memnic-tester, in less than 1024 frame size the\nperformance could be improved.\n\nUsing Xeon E5-2697 v2 @ 2.70GHz, 4 vCPU.\n size | before | after\n 64 | 5.55Mpps | 5.83Mpps\n 128 | 5.44Mpps | 5.71Mpps\n 256 | 5.22Mpps | 5.40Mpps\n 512 | 4.52Mpps | 4.64Mpps\n 1024 | 3.73Mpps | 3.68Mpps\n 1280 | 3.22Mpps | 3.17Mpps\n 1518 | 2.93Mpps | 2.90Mpps\n\nSigned-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>\nReviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>\n---\n pmd/pmd_memnic.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c\nindex 875d3ea..59ee332 100644\n--- a/pmd/pmd_memnic.c\n+++ b/pmd/pmd_memnic.c\n@@ -344,7 +344,7 @@ static uint16_t memnic_xmit_pkts(void *tx_queue,\n \tstruct memnic_adapter *adapter = q->adapter;\n \tstruct memnic_data *data = &adapter->nic->down;\n \tstruct memnic_packet *p;\n-\tuint16_t nr;\n+\tuint16_t i, nr;\n \tint idx;\n \tstruct rte_eth_stats *st = &adapter->stats[rte_lcore_id()];\n \tuint64_t pkts, bytes, errs;\n@@ -408,9 +408,9 @@ retry:\n \n \t\trte_compiler_barrier();\n \t\tp->status = MEMNIC_PKT_ST_FILLED;\n-\n-\t\trte_pktmbuf_free(tx_pkts[nr]);\n \t}\n+\tfor (i = 0; i < nr; i++)\n+\t\trte_pktmbuf_free(tx_pkts[i]);\n \n \t/* stats */\n \tst->opackets += pkts;\n", "prefixes": [ "dpdk-dev", "memnic", "v2", "7/7" ] }