Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68563/?format=api
{ "id": 68563, "url": "http://patchwork.dpdk.org/api/patches/68563/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1586962156-11179-7-git-send-email-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1586962156-11179-7-git-send-email-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1586962156-11179-7-git-send-email-venkatkumar.duvvuru@broadcom.com", "date": "2020-04-15T14:49:11", "name": "[06/11] net/bnxt: aggregated ulp mapper create arguments to single structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3ee663ff4bfce8e4ebac0472bc7f48b6ed9baaaa", "submitter": { "id": 1635, "url": "http://patchwork.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1586962156-11179-7-git-send-email-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 9397, "url": "http://patchwork.dpdk.org/api/series/9397/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9397", "date": "2020-04-15T14:49:05", "name": "enhancements to host based flow table management", "version": 1, "mbox": "http://patchwork.dpdk.org/series/9397/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/68563/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/68563/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 091F8A0563;\n\tWed, 15 Apr 2020 16:51:34 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 862641D91B;\n\tWed, 15 Apr 2020 16:50:42 +0200 (CEST)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 72B121D90F\n for <dev@dpdk.org>; Wed, 15 Apr 2020 16:50:39 +0200 (CEST)", "by mail-pf1-f196.google.com with SMTP id r20so47301pfh.9\n for <dev@dpdk.org>; Wed, 15 Apr 2020 07:50:39 -0700 (PDT)", "from S60.dhcp.broadcom.net ([192.19.234.250])\n by smtp.gmail.com with ESMTPSA id 11sm13767969pfz.91.2020.04.15.07.50.35\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 15 Apr 2020 07:50:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=4uJQCodnE48Cx40hTtzws59/2lCEq8iveyGenkIww8E=;\n b=CbeEv1cWNyjvPWLxGpSLxvw7V/zVbsY/e6LPgy7pCQiOV5Dmy3Mcaufa7uoAGh2vEF\n goJ1hR+4Ir1RsErIoAWHntNB+pirTTTqoHfZ9m7RFa9i02JQqRcS6vUvUPRgN/JKWFkL\n ejs4C6H8Dxhzdl5yNxlbb2QmC7ya9GfXSkKws=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=4uJQCodnE48Cx40hTtzws59/2lCEq8iveyGenkIww8E=;\n b=Ue7KsAVFuI+XAuIuTOgdTaGyLUxFjAaqCS/M4TTCSQywgXqJmExutD0F9f1fUn4f7m\n 3AfNOU8UplCe1IL7JJ06TowC74WI8bR3UIkIZv06+Z7vCGOzKHPWHEPG0YKzEN/Xxho9\n BEhDc8T3krYerqxHOrm2vAJtU+sKaxWG25sxcoBz1kwpDMSaIYcnC4RX6hWLz501vyIM\n gtYX/m6iyYsd6r4+JimarbQJfivIfIMJFu+yTFhUKkKgxRtly0djRscw2HVCNK4V/6DR\n /yotL756P+kw2pLydppH/UKrol/rphd26y+ZmKMR1e8m8TUjH1Ujc7PbT1R99M7fDHBI\n ympA==", "X-Gm-Message-State": "AGi0PuYk2Gj+O+H+/8MWdjm5iB8kBQhmrweS/1uoz3dh6WxI3xpOmRh1\n 17uFBTAvqWfCnEFkS1k67IIF2qAtslL8UyGr7X7XEg+Sijmqf/sANYQKg4oXP6ktmXFRFcA6QUd\n aV8pcYRGigdio6XELibhnqDdAZIlcD2xDVa5xyoIx8BxvIcVtgQArYD/YXzhi4tsEoJN8", "X-Google-Smtp-Source": "\n APiQypJDioE17Bnb8kG0xLJtvJ5gr6qKy33bmvf8N+07J0M7wLChEyZljAGuzonDoqifC+Rqmy388g==", "X-Received": "by 2002:a63:48a:: with SMTP id 132mr27366111pge.380.1586962237961;\n Wed, 15 Apr 2020 07:50:37 -0700 (PDT)", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Mike Baucom <michael.baucom@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Wed, 15 Apr 2020 20:19:11 +0530", "Message-Id": "\n <1586962156-11179-7-git-send-email-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "\n <1586962156-11179-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "References": "\n <1586962156-11179-1-git-send-email-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 06/11] net/bnxt: aggregated ulp mapper create\n\targuments to single structure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Mike Baucom <michael.baucom@broadcom.com>\n\nThe changes are to the ulp mapper flow_create, the API changed\nto take the bnxt_ulp_mapper_create_parms structure instead of individual\nfields.\n\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nSigned-off-by: Mike Baucom <michael.baucom@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c | 19 ++++++++++---------\n drivers/net/bnxt/tf_ulp/ulp_mapper.c | 33 +++++++++++++++------------------\n drivers/net/bnxt/tf_ulp/ulp_mapper.h | 20 ++++++++++++--------\n 3 files changed, 37 insertions(+), 35 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c\nindex 026f33f..9326401 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c\n@@ -67,11 +67,11 @@ bnxt_ulp_flow_create(struct rte_eth_dev\t\t\t*dev,\n \t\t const struct rte_flow_action\tactions[],\n \t\t struct rte_flow_error\t\t*error)\n {\n+\tstruct bnxt_ulp_mapper_create_parms mapper_cparms = { 0 };\n \tstruct ulp_rte_parser_params params;\n \tstruct bnxt_ulp_context *ulp_ctx = NULL;\n \tuint32_t class_id, act_tmpl;\n \tstruct rte_flow *flow_id;\n-\tuint32_t app_priority;\n \tuint32_t fid;\n \tuint8_t\t*buffer;\n \tuint32_t vnic;\n@@ -125,16 +125,17 @@ bnxt_ulp_flow_create(struct rte_eth_dev\t\t\t*dev,\n \tif (ret != BNXT_TF_RC_SUCCESS)\n \t\tgoto parse_error;\n \n-\tapp_priority = attr->priority;\n+\tmapper_cparms.app_priority = attr->priority;\n+\tmapper_cparms.hdr_bitmap = ¶ms.hdr_bitmap;\n+\tmapper_cparms.hdr_field = params.hdr_field;\n+\tmapper_cparms.act = ¶ms.act_bitmap;\n+\tmapper_cparms.act_prop = ¶ms.act_prop;\n+\tmapper_cparms.class_tid = class_id;\n+\tmapper_cparms.act_tid = act_tmpl;\n+\n \t/* call the ulp mapper to create the flow in the hardware */\n \tret = ulp_mapper_flow_create(ulp_ctx,\n-\t\t\t\t app_priority,\n-\t\t\t\t ¶ms.hdr_bitmap,\n-\t\t\t\t params.hdr_field,\n-\t\t\t\t ¶ms.act_bitmap,\n-\t\t\t\t ¶ms.act_prop,\n-\t\t\t\t class_id,\n-\t\t\t\t act_tmpl,\n+\t\t\t\t &mapper_cparms,\n \t\t\t\t &fid);\n \tif (!ret) {\n \t\tflow_id = (struct rte_flow *)((uintptr_t)fid);\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\nindex 84d5ac6..dd44938 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n@@ -1411,26 +1411,23 @@ ulp_mapper_flow_destroy(struct bnxt_ulp_context\t*ulp_ctx, uint32_t fid)\n */\n int32_t\n ulp_mapper_flow_create(struct bnxt_ulp_context *ulp_ctx,\n-\t\t uint32_t app_priority __rte_unused,\n-\t\t struct ulp_rte_hdr_bitmap *hdr_bitmap __rte_unused,\n-\t\t struct ulp_rte_hdr_field *hdr_field,\n-\t\t struct ulp_rte_act_bitmap *act_bitmap,\n-\t\t struct ulp_rte_act_prop *act_prop,\n-\t\t uint32_t class_tid,\n-\t\t uint32_t act_tid,\n-\t\t uint32_t *flow_id)\n+\t\t struct bnxt_ulp_mapper_create_parms *cparms,\n+\t\t uint32_t *flowid)\n {\n-\tstruct ulp_regfile\t\tregfile;\n-\tstruct bnxt_ulp_mapper_parms\tparms;\n-\tstruct bnxt_ulp_device_params\t*device_params;\n-\tint32_t\t\t\t\trc, trc;\n+\tstruct bnxt_ulp_device_params *device_params;\n+\tstruct bnxt_ulp_mapper_parms parms;\n+\tstruct ulp_regfile regfile;\n+\tint32_t\t rc, trc;\n+\n+\tif (!ulp_ctx || !cparms)\n+\t\treturn -EINVAL;\n \n \t/* Initialize the parms structure */\n \tmemset(&parms, 0, sizeof(parms));\n-\tparms.act_prop = act_prop;\n-\tparms.act_bitmap = act_bitmap;\n+\tparms.act_prop = cparms->act_prop;\n+\tparms.act_bitmap = cparms->act;\n \tparms.regfile = ®file;\n-\tparms.hdr_field = hdr_field;\n+\tparms.hdr_field = cparms->hdr_field;\n \tparms.tfp = bnxt_ulp_cntxt_tfp_get(ulp_ctx);\n \tparms.ulp_ctx = ulp_ctx;\n \n@@ -1441,7 +1438,7 @@ ulp_mapper_flow_create(struct bnxt_ulp_context *ulp_ctx,\n \t}\n \n \t/* Get the action table entry from device id and act context id */\n-\tparms.act_tid = act_tid;\n+\tparms.act_tid = cparms->act_tid;\n \tparms.atbls = ulp_mapper_action_tbl_list_get(parms.dev_id,\n \t\t\t\t\t\t parms.act_tid,\n \t\t\t\t\t\t &parms.num_atbls);\n@@ -1452,7 +1449,7 @@ ulp_mapper_flow_create(struct bnxt_ulp_context *ulp_ctx,\n \t}\n \n \t/* Get the class table entry from device id and act context id */\n-\tparms.class_tid = class_tid;\n+\tparms.class_tid = cparms->class_tid;\n \tparms.ctbls = ulp_mapper_class_tbl_list_get(parms.dev_id,\n \t\t\t\t\t\t parms.class_tid,\n \t\t\t\t\t\t &parms.num_ctbls);\n@@ -1506,7 +1503,7 @@ ulp_mapper_flow_create(struct bnxt_ulp_context *ulp_ctx,\n \t\tgoto flow_error;\n \t}\n \n-\t*flow_id = parms.fid;\n+\t*flowid = parms.fid;\n \n \treturn rc;\n \ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.h b/drivers/net/bnxt/tf_ulp/ulp_mapper.h\nindex 5f3d46e..24727a3 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.h\n+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.h\n@@ -38,20 +38,24 @@ struct bnxt_ulp_mapper_parms {\n \tenum bnxt_ulp_flow_db_tables\t\ttbl_idx;\n };\n \n+struct bnxt_ulp_mapper_create_parms {\n+\tuint32_t\t\t\tapp_priority;\n+\tstruct ulp_rte_hdr_bitmap\t*hdr_bitmap;\n+\tstruct ulp_rte_hdr_field\t*hdr_field;\n+\tstruct ulp_rte_act_bitmap\t*act;\n+\tstruct ulp_rte_act_prop\t\t*act_prop;\n+\tuint32_t\t\t\tclass_tid;\n+\tuint32_t\t\t\tact_tid;\n+};\n+\n /*\n * Function to handle the mapping of the Flow to be compatible\n * with the underlying hardware.\n */\n int32_t\n ulp_mapper_flow_create(struct bnxt_ulp_context\t*ulp_ctx,\n-\t\t uint32_t\t\tapp_priority,\n-\t\t struct ulp_rte_hdr_bitmap *hdr_bitmap,\n-\t\t struct ulp_rte_hdr_field *hdr_field,\n-\t\t struct ulp_rte_act_bitmap *act,\n-\t\t struct ulp_rte_act_prop *act_prop,\n-\t\t uint32_t\t\tclass_tid,\n-\t\t uint32_t\t\tact_tid,\n-\t\t uint32_t\t\t*flow_id);\n+\t\t struct bnxt_ulp_mapper_create_parms *parms,\n+\t\t uint32_t *flowid);\n \n /* Function that frees all resources associated with the flow. */\n int32_t\n", "prefixes": [ "06/11" ] }