Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69112/?format=api
{ "id": 69112, "url": "http://patchwork.dpdk.org/api/patches/69112/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200422163756.2738-2-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200422163756.2738-2-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200422163756.2738-2-haiyue.wang@intel.com", "date": "2020-04-22T16:37:56", "name": "[v4,1/1] eal: add internal ABI mark support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "89a10f3631f295e383aeb5c47b89f60523406708", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200422163756.2738-2-haiyue.wang@intel.com/mbox/", "series": [ { "id": 9571, "url": "http://patchwork.dpdk.org/api/series/9571/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9571", "date": "2020-04-22T16:37:55", "name": "dpdk: introduce __rte_internal tag", "version": 4, "mbox": "http://patchwork.dpdk.org/series/9571/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/69112/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/69112/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C4309A00C2;\n\tWed, 22 Apr 2020 18:43:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 956741D55B;\n\tWed, 22 Apr 2020 18:43:43 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 4CCFA1D554\n for <dev@dpdk.org>; Wed, 22 Apr 2020 18:43:41 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2020 09:43:40 -0700", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.119.46])\n by orsmga004.jf.intel.com with ESMTP; 22 Apr 2020 09:43:38 -0700" ], "IronPort-SDR": [ "\n yGVfNS1XeTH+49iAgLS2KZR9nYaiL0rpxZggzIeT0UKF29PJ2f9DkR9YdiZUEvwHMvsOmbiitf\n 22xWzpNT9sfw==", "\n tcn8t0Dbmj3ET6O0XbNXWWAvTkI4exukMmnQNIz5Tis2L5tu5Eq8XWb/DL5uXVStxuwQpRS9M8\n F19w0FTkZtYA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,304,1583222400\"; d=\"scan'208\";a=\"402608643\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,\n bruce.richardson@intel.com, ferruh.yigit@intel.com, nhorman@tuxdriver.com,\n mdr@ashroe.eu", "Cc": "Haiyue Wang <haiyue.wang@intel.com>", "Date": "Thu, 23 Apr 2020 00:37:56 +0800", "Message-Id": "<20200422163756.2738-2-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200422163756.2738-1-haiyue.wang@intel.com>", "References": "<20190613142344.9188-1-nhorman@tuxdriver.com>\n <20200422163756.2738-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 1/1] eal: add internal ABI mark support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Introduce __rte_internal tag to mark internal ABI function, this kind of\nfunction can't be called by external application.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n buildtools/check-internal-syms.sh | 57 +++++++++++++++++++++++++++++\n devtools/check-symbol-change.sh | 7 ++++\n devtools/libabigail.abignore | 5 +++\n drivers/meson.build | 2 +-\n lib/librte_eal/include/rte_compat.h | 13 +++++++\n lib/meson.build | 2 +-\n mk/internal/rte.compile-pre.mk | 3 ++\n mk/target/generic/rte.vars.mk | 1 +\n 8 files changed, 88 insertions(+), 2 deletions(-)\n create mode 100755 buildtools/check-internal-syms.sh", "diff": "diff --git a/buildtools/check-internal-syms.sh b/buildtools/check-internal-syms.sh\nnew file mode 100755\nindex 000000000..5043acf87\n--- /dev/null\n+++ b/buildtools/check-internal-syms.sh\n@@ -0,0 +1,57 @@\n+#!/bin/sh\n+\n+# SPDX-License-Identifier: BSD-3-Clause\n+\n+MAPFILE=$1\n+OBJFILE=$2\n+\n+LIST_SYMBOL=$(dirname $(readlink -f $0))/map-list-symbol.sh\n+\n+# added check for \"make -C test/\" usage\n+if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]\n+then\n+\texit 0\n+fi\n+\n+if [ -d $MAPFILE ]\n+then\n+\texit 0\n+fi\n+\n+DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump)\n+trap 'rm -f \"$DUMPFILE\"' EXIT\n+objdump -t $OBJFILE >$DUMPFILE\n+\n+ret=0\n+for SYM in `$LIST_SYMBOL -S INTERNAL $MAPFILE |cut -d ' ' -f 3`\n+do\n+\tif grep -q \"\\.text.*[[:space:]]$SYM$\" $DUMPFILE &&\n+\t\t! grep -q \"\\.text\\.internal.*[[:space:]]$SYM$\" $DUMPFILE\n+\tthen\n+\t\tcat >&2 <<- END_OF_MESSAGE\n+\t\t$SYM is not flagged as internal\n+\t\tbut is listed in version map\n+\t\tPlease add __rte_internal to the definition of $SYM\n+\t\tEND_OF_MESSAGE\n+\t\tret=1\n+\tfi\n+done\n+\n+# Filter out symbols suffixed with a . for icc\n+for SYM in `awk '{\n+\tif ($2 != \"l\" && $4 == \".text.internal\" && !($NF ~ /\\.$/)) {\n+\t\tprint $NF\n+\t}\n+}' $DUMPFILE`\n+do\n+\t$LIST_SYMBOL -S INTERNAL -s $SYM -q $MAPFILE || {\n+\t\tcat >&2 <<- END_OF_MESSAGE\n+\t\t$SYM is flagged as internal\n+\t\tbut is not listed in version map\n+\t\tPlease add $SYM to the version map\n+\t\tEND_OF_MESSAGE\n+\t\tret=1\n+\t}\n+done\n+\n+exit $ret\ndiff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh\nindex ed2178e36..978979077 100755\n--- a/devtools/check-symbol-change.sh\n+++ b/devtools/check-symbol-change.sh\n@@ -91,6 +91,13 @@ check_for_rule_violations()\n \t\tif [ \"$ar\" = \"add\" ]\n \t\tthen\n \n+\t\t\tif [ \"$secname\" = \"INTERNAL\" ]\n+\t\t\tthen\n+\t\t\t\t# these are absolved from any further checking\n+\t\t\t\techo \"Skipping symbol $symname in INTERNAL\"\n+\t\t\t\tcontinue\n+\t\t\tfi\n+\n \t\t\tif [ \"$secname\" = \"unknown\" ]\n \t\t\tthen\n \t\t\t\t# Just inform the user of this occurrence, but\ndiff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore\nindex cd86d89ca..3e8e2ea74 100644\n--- a/devtools/libabigail.abignore\n+++ b/devtools/libabigail.abignore\n@@ -3,6 +3,11 @@\n [suppress_variable]\n symbol_version = EXPERIMENTAL\n \n+[suppress_function]\n+ symbol_version = INTERNAL\n+[suppress_variable]\n+ symbol_version = INTERNAL\n+\n ; Explicit ignore for driver-only ABI\n [suppress_type]\n name = rte_cryptodev_ops\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex 4d8f842ab..cac07161f 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -20,7 +20,7 @@ dpdk_driver_classes = ['common',\n disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'),\n \t\t).stdout().split()\n \n-default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']\n+default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API'] + ['-DALLOW_INTERNAL_API']\n if cc.has_argument('-Wno-format-truncation')\n \tdefault_cflags += '-Wno-format-truncation'\n endif\ndiff --git a/lib/librte_eal/include/rte_compat.h b/lib/librte_eal/include/rte_compat.h\nindex 3eb33784b..4cd8f68d6 100644\n--- a/lib/librte_eal/include/rte_compat.h\n+++ b/lib/librte_eal/include/rte_compat.h\n@@ -19,4 +19,17 @@ __attribute__((section(\".text.experimental\")))\n \n #endif\n \n+#ifndef ALLOW_INTERNAL_API\n+\n+#define __rte_internal \\\n+__attribute__((error(\"Symbol is not public ABI\"), \\\n+section(\".text.internal\")))\n+\n+#else\n+\n+#define __rte_internal \\\n+__attribute__((section(\".text.internal\")))\n+\n+#endif\n+\n #endif /* _RTE_COMPAT_H_ */\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 63c17ee75..981c2e397 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -36,7 +36,7 @@ if is_windows\n \tlibraries = ['kvargs','eal'] # only supported libraries for windows\n endif\n \n-default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']\n+default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API'] + ['-DALLOW_INTERNAL_API']\n if cc.has_argument('-Wno-format-truncation')\n \tdefault_cflags += '-Wno-format-truncation'\n endif\ndiff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk\nindex 82fe098f7..0369786a5 100644\n--- a/mk/internal/rte.compile-pre.mk\n+++ b/mk/internal/rte.compile-pre.mk\n@@ -58,6 +58,8 @@ C_TO_O_DISP = $(if $(V),\"$(C_TO_O_STR)\",\" CC $(@)\")\n endif\n EXPERIMENTAL_CHECK = $(RTE_SDK)/buildtools/check-experimental-syms.sh\n CHECK_EXPERIMENTAL = $(EXPERIMENTAL_CHECK) $(SRCDIR)/$(EXPORT_MAP) $@\n+INTERNAL_CHECK = $(RTE_SDK)/buildtools/check-internal-syms.sh\n+CHECK_INTERNAL = $(INTERNAL_CHECK) $(SRCDIR)/$(EXPORT_MAP) $@\n \n PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c\n PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -c -o $@.pmd.o $@.pmd.c\n@@ -76,6 +78,7 @@ C_TO_O_DO = @set -e; \\\n \t$(C_TO_O) && \\\n \t$(PMDINFO_TO_O) && \\\n \t$(CHECK_EXPERIMENTAL) && \\\n+\t$(CHECK_INTERNAL) && \\\n \techo $(C_TO_O_CMD) > $(call obj2cmd,$(@)) && \\\n \tsed 's,'$@':,dep_'$@' =,' $(call obj2dep,$(@)).tmp > $(call obj2dep,$(@)) && \\\n \trm -f $(call obj2dep,$(@)).tmp\ndiff --git a/mk/target/generic/rte.vars.mk b/mk/target/generic/rte.vars.mk\nindex ec2672897..11b0418e5 100644\n--- a/mk/target/generic/rte.vars.mk\n+++ b/mk/target/generic/rte.vars.mk\n@@ -106,6 +106,7 @@ ifeq ($(BUILDING_RTE_SDK),1)\n # building sdk\n CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h\n CFLAGS += -DALLOW_EXPERIMENTAL_API\n+CFLAGS += -DALLOW_INTERNAL_API\n else\n # if we are building an external application, include SDK's lib and\n # includes too\n", "prefixes": [ "v4", "1/1" ] }