Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/692/?format=api
{ "id": 692, "url": "http://patchwork.dpdk.org/api/patches/692/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1412170427-7245-1-git-send-email-reshma.pattan@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1412170427-7245-1-git-send-email-reshma.pattan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1412170427-7245-1-git-send-email-reshma.pattan@intel.com", "date": "2014-10-01T13:33:47", "name": "[dpdk-dev,v4] distributor_app: gracefull shutdown of tx/rx threads on SIGINT", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8232e801a3dd7ef5ad0733b99159b3585a5c1453", "submitter": { "id": 70, "url": "http://patchwork.dpdk.org/api/people/70/?format=api", "name": "Pattan, Reshma", "email": "reshma.pattan@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1412170427-7245-1-git-send-email-reshma.pattan@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/692/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/692/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B856BDE4;\n\tWed, 1 Oct 2014 15:27:09 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id A443E212\n\tfor <dev@dpdk.org>; Wed, 1 Oct 2014 15:27:08 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 01 Oct 2014 06:33:52 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 01 Oct 2014 06:33:51 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts91DXnUs030928; Wed, 1 Oct 2014 14:33:49 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s91DXnWJ007282;\n\tWed, 1 Oct 2014 14:33:49 +0100", "(from reshmapa@localhost)\n\tby sivswdev02.ir.intel.com with id s91DXnUm007278;\n\tWed, 1 Oct 2014 14:33:49 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,632,1406617200\"; d=\"scan'208\";a=\"608146917\"", "From": "reshmapa <reshma.pattan@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 1 Oct 2014 14:33:47 +0100", "Message-Id": "<1412170427-7245-1-git-send-email-reshma.pattan@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1412073577-12248-1-git-send-email-reshma.pattan@intel.com>", "References": "<1412073577-12248-1-git-send-email-reshma.pattan@intel.com>", "Subject": "[dpdk-dev] [PATCH v4] distributor_app: gracefull shutdown of tx/rx\n\tthreads on SIGINT", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Reshma Pattan <reshma.pattan@intel.com>\n\n\t*Handled gracefull shutdown of rx and tx threads upon SIGINT.\n\t*Gracefull shutdown of worker threads will be handled in\n\t future enhancements.\n\n\tSigned-off-by: Reshma Pattan <reshma.pattan@intel.com>\n---\n examples/distributor_app/main.c | 12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/examples/distributor_app/main.c b/examples/distributor_app/main.c\nindex f555d93..b6fa063 100644\n--- a/examples/distributor_app/main.c\n+++ b/examples/distributor_app/main.c\n@@ -85,6 +85,7 @@\n \n /* mask of enabled ports */\n static uint32_t enabled_port_mask = 0;\n+volatile uint8_t quit_signal = 0;\n \n static volatile struct app_stats {\n \tstruct {\n@@ -221,7 +222,7 @@ struct lcore_params {\n \tstruct rte_ring *r;\n };\n \n-static __attribute__((noreturn)) void\n+static int\n lcore_rx(struct lcore_params *p)\n {\n \tstruct rte_distributor *d = p->d;\n@@ -244,7 +245,7 @@ lcore_rx(struct lcore_params *p)\n \n \tprintf(\"\\nCore %u doing packet RX.\\n\", rte_lcore_id());\n \tport = 0;\n-\tfor (;;) {\n+\twhile (!quit_signal) {\n \t\t/* skip ports that are not enabled */\n \t\tif ((enabled_port_mask & (1 << port)) == 0) {\n \t\t\tif (++port == nb_ports)\n@@ -307,7 +308,7 @@ flush_all_ports(struct output_buffer *tx_buffers, uint8_t nb_ports)\n \t}\n }\n \n-static __attribute__((noreturn)) void\n+static int\n lcore_tx(struct rte_ring *in_r)\n {\n \tstatic struct output_buffer tx_buffers[RTE_MAX_ETHPORTS];\n@@ -328,7 +329,7 @@ lcore_tx(struct rte_ring *in_r)\n \t}\n \n \tprintf(\"\\nCore %u doing packet TX.\\n\", rte_lcore_id());\n-\tfor (;;) {\n+\twhile (!quit_signal) {\n \t\tfor (port = 0; port < nb_ports; port++) {\n \t\t\t/* skip ports that are not enabled */\n \t\t\tif ((enabled_port_mask & (1 << port)) == 0)\n@@ -370,7 +371,6 @@ lcore_tx(struct rte_ring *in_r)\n \t}\n }\n \n-\n static __attribute__((noreturn)) void\n lcore_worker(struct lcore_params *p)\n {\n@@ -415,7 +415,7 @@ int_handler(int sig_num)\n \t\tprintf(\" - Out Errs: %\"PRIu64\"\\n\", eth_stats.oerrors);\n \t\tprintf(\" - Mbuf Errs: %\"PRIu64\"\\n\", eth_stats.rx_nombuf);\n \t}\n-\texit(0);\n+\tquit_signal = 1;\n }\n \n /* display usage */\n", "prefixes": [ "dpdk-dev", "v4" ] }