Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69306/?format=api
{ "id": 69306, "url": "http://patchwork.dpdk.org/api/patches/69306/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200425105620.73021-7-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200425105620.73021-7-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200425105620.73021-7-haiyue.wang@intel.com", "date": "2020-04-25T10:56:20", "name": "[v7,6/6] devtools: enforce internal tag at the beginning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "299fc14c3e4ed0602b2ebe8cca694e40900deeb9", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200425105620.73021-7-haiyue.wang@intel.com/mbox/", "series": [ { "id": 9633, "url": "http://patchwork.dpdk.org/api/series/9633/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9633", "date": "2020-04-25T10:56:14", "name": "dpdk: introduce __rte_internal tag", "version": 7, "mbox": "http://patchwork.dpdk.org/series/9633/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/69306/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/69306/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8C7FFA00C2;\n\tSat, 25 Apr 2020 13:03:08 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D54D61C23D;\n\tSat, 25 Apr 2020 13:02:29 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id E4EEE1C1CE\n for <dev@dpdk.org>; Sat, 25 Apr 2020 13:02:25 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Apr 2020 04:02:25 -0700", "from npg-dpdk-haiyue-3.sh.intel.com ([10.67.119.46])\n by fmsmga005.fm.intel.com with ESMTP; 25 Apr 2020 04:02:23 -0700" ], "IronPort-SDR": [ "\n KJBs02dgXOB8cMBRFmpZBlKiicl7IlLO+4vO8dIRcuSkZFWsDL+mBzGr9rsZNezWApueZh5HIm\n 5a+HbTc/Slzg==", "\n mo1k10ZchruJ1iIkOusVM5LhvYQVTY3Kptxo5Rtt1/OBA/g0P4wL/2JN8YfjdOwdVxmW57UCvh\n USj0C/axMsjQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,315,1583222400\"; d=\"scan'208\";a=\"457729327\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,\n bruce.richardson@intel.com, ferruh.yigit@intel.com, nhorman@tuxdriver.com,\n mdr@ashroe.eu", "Cc": "Haiyue Wang <haiyue.wang@intel.com>", "Date": "Sat, 25 Apr 2020 18:56:20 +0800", "Message-Id": "<20200425105620.73021-7-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200425105620.73021-1-haiyue.wang@intel.com>", "References": "<20190613142344.9188-1-nhorman@tuxdriver.com>\n <20200425105620.73021-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 6/6] devtools: enforce internal tag at the\n\tbeginning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Move the internal tag on a separate line and make it the first thing of\nfunction prototypes.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n devtools/checkpatches.sh | 39 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 39 insertions(+)", "diff": "diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh\nindex c30ce64cc..42b833e0d 100755\n--- a/devtools/checkpatches.sh\n+++ b/devtools/checkpatches.sh\n@@ -111,6 +111,37 @@ check_experimental_tags() { # <patch>\n \treturn $res\n }\n \n+check_internal_tags() { # <patch>\n+\tres=0\n+\n+\tcat \"$1\" |awk '\n+\tBEGIN {\n+\t\tcurrent_file = \"\";\n+\t\tret = 0;\n+\t}\n+\t/^+++ b\\// {\n+\t\tcurrent_file = $2;\n+\t}\n+\t/^+.*__rte_internal/ {\n+\t\tif (current_file ~ \".c$\" ) {\n+\t\t\tprint \"Please only put __rte_internal tags in \" \\\n+\t\t\t\t\"headers (\"current_file\")\";\n+\t\t\tret = 1;\n+\t\t}\n+\t\tif ($1 != \"+__rte_internal\" || $2 != \"\") {\n+\t\t\tprint \"__rte_internal must appear alone on the line\" \\\n+\t\t\t\t\" immediately preceding the return type of\" \\\n+\t\t\t\t\" a function.\"\n+\t\t\tret = 1;\n+\t\t}\n+\t}\n+\tEND {\n+\t\texit ret;\n+\t}' || res=1\n+\n+\treturn $res\n+}\n+\n number=0\n range='origin/master..'\n quiet=false\n@@ -194,6 +225,14 @@ check () { # <patch> <commit> <title>\n \t\tret=1\n \tfi\n \n+\t! $verbose || printf '\\nChecking __rte_internal tags:\\n'\n+\treport=$(check_internal_tags \"$tmpinput\")\n+\tif [ $? -ne 0 ] ; then\n+\t\t$headline_printed || print_headline \"$3\"\n+\t\tprintf '%s\\n' \"$report\"\n+\t\tret=1\n+\tfi\n+\n \tif [ \"$tmpinput\" != \"$1\" ]; then\n \t\trm -f \"$tmpinput\"\n \t\ttrap - INT\n", "prefixes": [ "v7", "6/6" ] }