Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69515/?format=api
{ "id": 69515, "url": "http://patchwork.dpdk.org/api/patches/69515/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200429072822.102745-2-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200429072822.102745-2-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200429072822.102745-2-yong.liu@intel.com", "date": "2020-04-29T07:28:14", "name": "[v12,1/9] net/virtio: add Rx free threshold setting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "59d17623bc4a0ebb104f7a6dbe79783b3f179d6a", "submitter": { "id": 17, "url": "http://patchwork.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200429072822.102745-2-yong.liu@intel.com/mbox/", "series": [ { "id": 9726, "url": "http://patchwork.dpdk.org/api/series/9726/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9726", "date": "2020-04-29T07:28:13", "name": "add packed ring vectorized path", "version": 12, "mbox": "http://patchwork.dpdk.org/series/9726/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/69515/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/69515/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB4A5A00BE;\n\tWed, 29 Apr 2020 09:28:36 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C76981D904;\n\tWed, 29 Apr 2020 09:28:32 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id BD52B1D8F5\n for <dev@dpdk.org>; Wed, 29 Apr 2020 09:28:28 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Apr 2020 00:28:28 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.56])\n by fmsmga004.fm.intel.com with ESMTP; 29 Apr 2020 00:28:26 -0700" ], "IronPort-SDR": [ "\n sft57ZKxiNxLUre9SlTPkL8pBLUT/gfogDDqde4NkiL83/l52HFLItPZlef4A3NTAbGT46JMko\n 9fdkf71huzzQ==", "\n XQDfwXVIhrywXuAh/le0J+kWmD7Vrb4jZ+0F7qDY4fh1RRV/AA8K/HHhPLD0YeU7q0SXPMPhc2\n NCJJq3f7AFwA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,330,1583222400\"; d=\"scan'208\";a=\"282415075\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com, xiaolong.ye@intel.com, zhihong.wang@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Wed, 29 Apr 2020 15:28:14 +0800", "Message-Id": "<20200429072822.102745-2-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200429072822.102745-1-yong.liu@intel.com>", "References": "<20200313174230.74661-1-yong.liu@intel.com>\n <20200429072822.102745-1-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v12 1/9] net/virtio: add Rx free threshold setting", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Introduce free threshold setting in Rx queue, its default value is 32.\nLimit the threshold size to multiple of four as only vectorized packed\nRx function will utilize it. Virtio driver will rearm Rx queue when\nmore than rx_free_thresh descs were dequeued.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 060410577..94ba7a3ec 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -936,6 +936,7 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \tstruct virtio_hw *hw = dev->data->dev_private;\n \tstruct virtqueue *vq = hw->vqs[vtpci_queue_idx];\n \tstruct virtnet_rx *rxvq;\n+\tuint16_t rx_free_thresh;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -944,6 +945,28 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t\treturn -EINVAL;\n \t}\n \n+\trx_free_thresh = rx_conf->rx_free_thresh;\n+\tif (rx_free_thresh == 0)\n+\t\trx_free_thresh =\n+\t\t\tRTE_MIN(vq->vq_nentries / 4, DEFAULT_RX_FREE_THRESH);\n+\n+\tif (rx_free_thresh & 0x3) {\n+\t\tRTE_LOG(ERR, PMD, \"rx_free_thresh must be multiples of four.\"\n+\t\t\t\" (rx_free_thresh=%u port=%u queue=%u)\\n\",\n+\t\t\trx_free_thresh, dev->data->port_id, queue_idx);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (rx_free_thresh >= vq->vq_nentries) {\n+\t\tRTE_LOG(ERR, PMD, \"rx_free_thresh must be less than the \"\n+\t\t\t\"number of RX entries (%u).\"\n+\t\t\t\" (rx_free_thresh=%u port=%u queue=%u)\\n\",\n+\t\t\tvq->vq_nentries,\n+\t\t\trx_free_thresh, dev->data->port_id, queue_idx);\n+\t\treturn -EINVAL;\n+\t}\n+\tvq->vq_free_thresh = rx_free_thresh;\n+\n \tif (nb_desc == 0 || nb_desc > vq->vq_nentries)\n \t\tnb_desc = vq->vq_nentries;\n \tvq->vq_free_cnt = RTE_MIN(vq->vq_free_cnt, nb_desc);\ndiff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h\nindex 58ad7309a..6301c56b2 100644\n--- a/drivers/net/virtio/virtqueue.h\n+++ b/drivers/net/virtio/virtqueue.h\n@@ -18,6 +18,8 @@\n \n struct rte_mbuf;\n \n+#define DEFAULT_RX_FREE_THRESH 32\n+\n /*\n * Per virtio_ring.h in Linux.\n * For virtio_pci on SMP, we don't need to order with respect to MMIO\n", "prefixes": [ "v12", "1/9" ] }