Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69570/?format=api
{ "id": 69570, "url": "http://patchwork.dpdk.org/api/patches/69570/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200430054606.92715-2-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200430054606.92715-2-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200430054606.92715-2-haiyue.wang@intel.com", "date": "2020-04-30T05:46:06", "name": "[v1,2/2] devtools: updating internal symbols ABI version", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "008637538a1df3bcae7a0e3a8a4f5c485230adde", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200430054606.92715-2-haiyue.wang@intel.com/mbox/", "series": [ { "id": 9750, "url": "http://patchwork.dpdk.org/api/series/9750/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9750", "date": "2020-04-30T05:46:05", "name": "[v1,1/2] devtools: add internal ABI version check", "version": 1, "mbox": "http://patchwork.dpdk.org/series/9750/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/69570/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/69570/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B022A00C5;\n\tThu, 30 Apr 2020 07:54:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 530061D93A;\n\tThu, 30 Apr 2020 07:54:42 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 31B791D931\n for <dev@dpdk.org>; Thu, 30 Apr 2020 07:54:38 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Apr 2020 22:54:37 -0700", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.119.213])\n by orsmga006.jf.intel.com with ESMTP; 29 Apr 2020 22:54:35 -0700" ], "IronPort-SDR": [ "\n xbnxqfOu65Gy25hov93jST2qfLsDrBCJmSARWBztEhzcoa5d3uZ7bAW5PQbMOZiWYUUel27oEj\n MQvq5OW18leg==", "\n aHXKtSa1pKZ8XddO+BStZz5pmNwmKuM96w9sxcFBMzXD9pPBBdUBDQTHXxqjjVgJoX0QRN/tEu\n jrS9FX4eje0g==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,334,1583222400\"; d=\"scan'208\";a=\"261661251\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,\n bruce.richardson@intel.com, anatoly.burakov@intel.com,\n nhorman@tuxdriver.com, mdr@ashroe.eu", "Cc": "Haiyue Wang <haiyue.wang@intel.com>", "Date": "Thu, 30 Apr 2020 13:46:06 +0800", "Message-Id": "<20200430054606.92715-2-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200430054606.92715-1-haiyue.wang@intel.com>", "References": "<20200430054606.92715-1-haiyue.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 2/2] devtools: updating internal symbols ABI\n\tversion", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "INTERNAL is new introduced version, update the script that automatically\nleaving internal section exactly as it is.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n devtools/update_version_map_abi.py | 37 +++++++++++++++++++++++++++---\n 1 file changed, 34 insertions(+), 3 deletions(-)", "diff": "diff --git a/devtools/update_version_map_abi.py b/devtools/update_version_map_abi.py\nindex 616412a1c..e2104e61e 100755\n--- a/devtools/update_version_map_abi.py\n+++ b/devtools/update_version_map_abi.py\n@@ -50,7 +50,10 @@ def __parse_map_file(f_in):\n stable_lines = set()\n # copy experimental section as is\n experimental_lines = []\n+ # copy internal section as is\n+ internal_lines = []\n in_experimental = False\n+ in_internal = False\n has_stable = False\n \n # gather all functions\n@@ -63,6 +66,7 @@ def __parse_map_file(f_in):\n if match:\n # whatever section this was, it's not active any more\n in_experimental = False\n+ in_internal = False\n continue\n \n # if we're in the middle of experimental section, we need to copy\n@@ -71,6 +75,12 @@ def __parse_map_file(f_in):\n experimental_lines += [line]\n continue\n \n+ # if we're in the middle of internal section, we need to copy\n+ # the section verbatim, so just add the line\n+ if in_internal:\n+ internal_lines += [line]\n+ continue\n+\n # skip empty lines\n if not line:\n continue\n@@ -81,7 +91,9 @@ def __parse_map_file(f_in):\n cur_section = match.group(\"version\")\n # is it experimental?\n in_experimental = cur_section == \"EXPERIMENTAL\"\n- if not in_experimental:\n+ # is it internal?\n+ in_internal = cur_section == \"INTERNAL\"\n+ if not in_experimental and not in_internal:\n has_stable = True\n continue\n \n@@ -90,7 +102,7 @@ def __parse_map_file(f_in):\n if match:\n stable_lines.add(match.group(\"func\"))\n \n- return has_stable, stable_lines, experimental_lines\n+ return has_stable, stable_lines, experimental_lines, internal_lines\n \n \n def __generate_stable_abi(f_out, abi_version, lines):\n@@ -132,6 +144,20 @@ def __generate_experimental_abi(f_out, lines):\n # end section\n print(\"};\", file=f_out)\n \n+def __generate_internal_abi(f_out, lines):\n+ # start internal section\n+ print(\"INTERNAL {\", file=f_out)\n+\n+ # print all internal lines as they were\n+ for line in lines:\n+ # don't print empty whitespace\n+ if not line:\n+ print(\"\", file=f_out)\n+ else:\n+ print(\"\\t{}\".format(line), file=f_out)\n+\n+ # end section\n+ print(\"};\", file=f_out)\n \n def __main():\n arg_parser = argparse.ArgumentParser(\n@@ -158,7 +184,7 @@ def __main():\n sys.exit(1)\n \n with open(parsed.map_file) as f_in:\n- has_stable, stable_lines, experimental_lines = __parse_map_file(f_in)\n+ has_stable, stable_lines, experimental_lines, internal_lines = __parse_map_file(f_in)\n \n with open(parsed.map_file, 'w') as f_out:\n need_newline = has_stable and experimental_lines\n@@ -169,6 +195,11 @@ def __main():\n print(file=f_out)\n if experimental_lines:\n __generate_experimental_abi(f_out, experimental_lines)\n+ if internal_lines:\n+ if has_stable or experimental_lines:\n+ # separate sections with a newline\n+ print(file=f_out)\n+ __generate_internal_abi(f_out, internal_lines)\n \n \n if __name__ == \"__main__\":\n", "prefixes": [ "v1", "2/2" ] }