Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/698/?format=api
{ "id": 698, "url": "http://patchwork.dpdk.org/api/patches/698/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1412202445-7832-1-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1412202445-7832-1-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1412202445-7832-1-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2014-10-01T22:27:25", "name": "[dpdk-dev] pmd: Fixed compilation error due to old RTE_DRV_LOG when bypass=y", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f55d2714b1e82b578f49c0ee75f4737d551f3dc8", "submitter": { "id": 9, "url": "http://patchwork.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1412202445-7832-1-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/698/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/698/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<pdelarax@ecsmtp.ir.intel.com>", "Received": [ "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 111C5212\n\tfor <dev@dpdk.org>; Thu, 2 Oct 2014 00:20:42 +0200 (CEST)", "from azsmga001.ch.intel.com ([10.2.17.19])\n\tby orsmga103.jf.intel.com with ESMTP; 01 Oct 2014 15:25:09 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby azsmga001.ch.intel.com with ESMTP; 01 Oct 2014 15:27:27 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts91MRQ5Z017601 for <dev@dpdk.org>; Wed, 1 Oct 2014 23:27:26 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s91MRQIL007868\n\tfor <dev@dpdk.org>; Wed, 1 Oct 2014 23:27:26 +0100", "(from pdelarax@localhost)\n\tby sivswdev02.ir.intel.com with id s91MRPk7007864\n\tfor dev@dpdk.org; Wed, 1 Oct 2014 23:27:25 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,635,1406617200\"; d=\"scan'208\";a=\"481364629\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 1 Oct 2014 23:27:25 +0100", "Message-Id": "<1412202445-7832-1-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] pmd: Fixed compilation error due to old\n\tRTE_DRV_LOG when bypass=y", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 01 Oct 2014 22:20:43 -0000" }, "content": "RTE_DRV_LOG macro has changed, so now it requires at least 2 arguments,\nwhich have been added in ixgbe_bypass, specifying log type, to fix compilation error\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c | 10 +++++-----\n lib/librte_pmd_ixgbe/ixgbe_bypass.c | 2 +-\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c\nindex 2623419..12cc01d 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c\n@@ -63,7 +63,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\trs = IXGBE_SFF_SOFT_RS_SELECT_1G;\n \t\tbreak;\n \tdefault:\n-\t\tPMD_DRV_LOG(\"Invalid fixed module speed\");\n+\t\tPMD_DRV_LOG(ERR, \"Invalid fixed module speed\");\n \t\treturn;\n \t}\n \n@@ -72,7 +72,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\t\t\t\t IXGBE_I2C_EEPROM_DEV_ADDR2,\n \t\t\t\t\t &eeprom_data);\n \tif (status) {\n-\t\tPMD_DRV_LOG(\"Failed to read Rx Rate Select RS0\");\n+\t\tPMD_DRV_LOG(ERR, \"Failed to read Rx Rate Select RS0\");\n \t\tgoto out;\n \t}\n \n@@ -82,7 +82,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\t\t\t\t IXGBE_I2C_EEPROM_DEV_ADDR2,\n \t\t\t\t\t eeprom_data);\n \tif (status) {\n-\t\tPMD_DRV_LOG(\"Failed to write Rx Rate Select RS0\");\n+\t\tPMD_DRV_LOG(ERR, \"Failed to write Rx Rate Select RS0\");\n \t\tgoto out;\n \t}\n \n@@ -91,7 +91,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\t\t\t\t IXGBE_I2C_EEPROM_DEV_ADDR2,\n \t\t\t\t\t &eeprom_data);\n \tif (status) {\n-\t\tPMD_DRV_LOG(\"Failed to read Rx Rate Select RS1\");\n+\t\tPMD_DRV_LOG(ERR, \"Failed to read Rx Rate Select RS1\");\n \t\tgoto out;\n \t}\n \n@@ -101,7 +101,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)\n \t\t\t\t\t IXGBE_I2C_EEPROM_DEV_ADDR2,\n \t\t\t\t\t eeprom_data);\n \tif (status) {\n-\t\tPMD_DRV_LOG(\"Failed to write Rx Rate Select RS1\");\n+\t\tPMD_DRV_LOG(ERR, \"Failed to write Rx Rate Select RS1\");\n \t\tgoto out;\n \t}\n out:\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_bypass.c b/lib/librte_pmd_ixgbe/ixgbe_bypass.c\nindex 1a980b8..15203a4 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_bypass.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_bypass.c\n@@ -114,7 +114,7 @@ ixgbe_bypass_init(struct rte_eth_dev *dev)\n \t/* Only allow BYPASS ops on the first port */\n \tif (hw->device_id != IXGBE_DEV_ID_82599_BYPASS ||\n \t\t\thw->bus.func != 0) {\n-\t\tPMD_DRV_LOG(\"bypass function is not supported on that device\");\n+\t\tPMD_DRV_LOG(ERR, \"bypass function is not supported on that device\");\n \t\treturn;\n \t}\n \n", "prefixes": [ "dpdk-dev" ] }