Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69807/?format=api
{ "id": 69807, "url": "http://patchwork.dpdk.org/api/patches/69807/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200506090240.19214-1-praveen.shetty@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200506090240.19214-1-praveen.shetty@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200506090240.19214-1-praveen.shetty@intel.com", "date": "2020-05-06T09:02:40", "name": "[v1] examples/ipsec-secgw: resolve coverity issue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d876bec170323eac68a2252fa9a64c0878638f42", "submitter": { "id": 1521, "url": "http://patchwork.dpdk.org/api/people/1521/?format=api", "name": "Shetty, Praveen", "email": "praveen.shetty@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200506090240.19214-1-praveen.shetty@intel.com/mbox/", "series": [ { "id": 9859, "url": "http://patchwork.dpdk.org/api/series/9859/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9859", "date": "2020-05-06T09:02:40", "name": "[v1] examples/ipsec-secgw: resolve coverity issue", "version": 1, "mbox": "http://patchwork.dpdk.org/series/9859/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/69807/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/69807/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C48C5A0350;\n\tWed, 6 May 2020 11:02:48 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 28D701D675;\n\tWed, 6 May 2020 11:02:48 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id A7B331D64E\n for <dev@dpdk.org>; Wed, 6 May 2020 11:02:46 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 May 2020 02:02:45 -0700", "from silpixa00399416.ir.intel.com (HELO\n silpixa00399416.ger.corp.intel.com) ([10.237.223.137])\n by orsmga004.jf.intel.com with ESMTP; 06 May 2020 02:02:43 -0700" ], "IronPort-SDR": [ "\n ldzdlNHNJMrG3T7q68LrTxlsKC2QrTw/aH9u/+LrdpLKqoWvO9RUd28Zp6QhE2K4L6PLpNZwDi\n cE5260bhnEUg==", "\n ynCBS0CgVQIsXRrOZGhLhQZZ4duI3xenMRN3Pd8UODyMP2CK9AGLMIgZEmqAs54hyVLtBg0/O/\n +kOd6HhElWPQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,358,1583222400\"; d=\"scan'208\";a=\"407169599\"", "From": "Praveen Shetty <praveen.shetty@intel.com>", "To": "dev@dpdk.org, declan.doherty@intel.com, akhil.goyal@nxp.com,\n anoobj@marvell.com", "Cc": "bernard.iremonger@intel.com, konstantin.ananyev@intel.com,\n praveen.shetty@intel.com", "Date": "Wed, 6 May 2020 10:02:40 +0100", "Message-Id": "<20200506090240.19214-1-praveen.shetty@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v1] examples/ipsec-secgw: resolve coverity issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Function create_ipsec_esp_flow returns a negative number in case of any\nfailure. But passing negative number to strerror is causing the coverity\nissue.\nIn case of failure, displaying exact error message to console is handled\nin create_ipsec_esp_flow function.So it is not required to print the\nerror message again using strerror.\nThis patch will remove the unnecessary calling of strerror function\nto fix the coverity issue.\n\nCoverity issue: 357691\nFixes: 6738c0a95695 (\"examples/ipsec-secgw: support flow director\")\nCc: praveen.shetty@intel.com\n\nSigned-off-by: Praveen Shetty <praveen.shetty@intel.com>\n---\n examples/ipsec-secgw/sa.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c\nindex e3a1a5aff..632482176 100644\n--- a/examples/ipsec-secgw/sa.c\n+++ b/examples/ipsec-secgw/sa.c\n@@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[],\n \t\t\trc = create_ipsec_esp_flow(sa);\n \t\t\tif (rc != 0)\n \t\t\t\tRTE_LOG(ERR, IPSEC_ESP,\n-\t\t\t\t\t\"create_ipsec_esp_flow() failed %s\\n\",\n-\t\t\t\t\tstrerror(rc));\n+\t\t\t\t\t\"create_ipsec_esp_flow() failed\\n\");\n \t\t}\n \t\tprint_one_sa_rule(sa, inbound);\n \t}\n", "prefixes": [ "v1" ] }