Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70062/?format=api
{ "id": 70062, "url": "http://patchwork.dpdk.org/api/patches/70062/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200511100059.5035-1-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200511100059.5035-1-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200511100059.5035-1-pbhagavatula@marvell.com", "date": "2020-05-11T10:00:57", "name": "[1/2] common/octeontx2: move internal symbols to INTERNAL section", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bd1a79f599748f35abdf3340229af701f9e8b27d", "submitter": { "id": 1183, "url": "http://patchwork.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200511100059.5035-1-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 9972, "url": "http://patchwork.dpdk.org/api/series/9972/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=9972", "date": "2020-05-11T10:00:57", "name": "[1/2] common/octeontx2: move internal symbols to INTERNAL section", "version": 1, "mbox": "http://patchwork.dpdk.org/series/9972/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/70062/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/70062/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A2747A0350;\n\tMon, 11 May 2020 12:01:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6BC4C1C1D5;\n\tMon, 11 May 2020 12:01:12 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id C75931C01F\n for <dev@dpdk.org>; Mon, 11 May 2020 12:01:11 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 04B9tnMw014435; Mon, 11 May 2020 03:01:09 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0b-0016f401.pphosted.com with ESMTP id 30wv1n5tqd-4\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 11 May 2020 03:01:09 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 11 May 2020 03:01:06 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 11 May 2020 03:01:06 -0700", "from BG-LT7430.marvell.com (BG-LT7430.marvell.com [10.28.161.240])\n by maili.marvell.com (Postfix) with ESMTP id 878323F7055;\n Mon, 11 May 2020 03:01:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0818; bh=8jZhl7rz3MOZyBb+SQ6DEmj6S2zDxnYQw6gmUlXv7YQ=;\n b=lCDAQaKZhmAzR4UjkJFqYCXBPR26dNRSep1CBU0Yn71GaPQMTpQZW9NPcPZkLTZI6jU9\n Q3xIuN16cpDiwjq1P5rMQ/x1tr8wFcKFWRIgfmBiyrvXNncuMJ7+rfQxfg2RINkTuDj4\n HgNPW3Mrj2woDgMEKVf3o0FxATIsPAcsBzJbL0J3q4EY3w/N1gzKdyK4+GGxTzfmQoyY\n j1ToE1bPvlaoce+C2K5NCK1AWDluHKY/hUa4Oer6Gn2HZurHWrU2ay5wHoY5QrbBdpCO\n lixGP64X5gpSOu6xCmuq4vWIHj+e/pbeShsFCJ32JyUUtEOkZgRhDSZwobwwHQCbhX4J Zg==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Anoob\n Joseph\" <anoobj@marvell.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman\n <nhorman@tuxdriver.com>", "CC": "<thomas@monjalon.net>, <dev@dpdk.org>, Pavan Nikhilesh\n <pbhagavatula@marvell.com>", "Date": "Mon, 11 May 2020 15:30:57 +0530", "Message-ID": "<20200511100059.5035-1-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676\n definitions=2020-05-11_04:2020-05-11,\n 2020-05-11 signatures=0", "Subject": "[dpdk-dev] [PATCH 1/2] common/octeontx2: move internal symbols to\n\tINTERNAL section", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nMove the internal symbols to INTERNAL sections so that any\nchange in them is not reported as ABI breakage.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n drivers/common/octeontx2/otx2_common.h | 8 ++++++++\n drivers/common/octeontx2/otx2_dev.h | 3 +++\n drivers/common/octeontx2/otx2_irq.h | 3 +++\n drivers/common/octeontx2/otx2_mbox.h | 6 ++++++\n drivers/common/octeontx2/otx2_sec_idev.h | 6 ++++++\n .../octeontx2/rte_common_octeontx2_version.map | 16 +++-------------\n 6 files changed, 29 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h\nindex e62cdea07..174702687 100644\n--- a/drivers/common/octeontx2/otx2_common.h\n+++ b/drivers/common/octeontx2/otx2_common.h\n@@ -62,13 +62,21 @@ struct otx2_idev_cfg {\n \t};\n };\n \n+__rte_internal\n struct otx2_idev_cfg *otx2_intra_dev_get_cfg(void);\n+__rte_internal\n void otx2_sso_pf_func_set(uint16_t sso_pf_func);\n+__rte_internal\n uint16_t otx2_sso_pf_func_get(void);\n+__rte_internal\n uint16_t otx2_npa_pf_func_get(void);\n+__rte_internal\n struct otx2_npa_lf *otx2_npa_lf_obj_get(void);\n+__rte_internal\n void otx2_npa_set_defaults(struct otx2_idev_cfg *idev);\n+__rte_internal\n int otx2_npa_lf_active(void *dev);\n+__rte_internal\n int otx2_npa_lf_obj_ref(void);\n \n /* Log */\ndiff --git a/drivers/common/octeontx2/otx2_dev.h b/drivers/common/octeontx2/otx2_dev.h\nindex 13b75e118..cd4fe517d 100644\n--- a/drivers/common/octeontx2/otx2_dev.h\n+++ b/drivers/common/octeontx2/otx2_dev.h\n@@ -94,6 +94,7 @@ struct otx2_dev {\n \tOTX2_DEV;\n };\n \n+__rte_internal\n int otx2_dev_priv_init(struct rte_pci_device *pci_dev, void *otx2_dev);\n \n /* Common dev init and fini routines */\n@@ -116,7 +117,9 @@ otx2_dev_init(struct rte_pci_device *pci_dev, void *otx2_dev)\n \treturn otx2_dev_priv_init(pci_dev, otx2_dev);\n }\n \n+__rte_internal\n void otx2_dev_fini(struct rte_pci_device *pci_dev, void *otx2_dev);\n+__rte_internal\n int otx2_dev_active_vfs(void *otx2_dev);\n \n #define RVU_PFVF_PF_SHIFT\t10\ndiff --git a/drivers/common/octeontx2/otx2_irq.h b/drivers/common/octeontx2/otx2_irq.h\nindex 9d326276e..0683cf554 100644\n--- a/drivers/common/octeontx2/otx2_irq.h\n+++ b/drivers/common/octeontx2/otx2_irq.h\n@@ -16,10 +16,13 @@ typedef struct {\n \tuint64_t bits[MAX_VFPF_DWORD_BITS];\n } otx2_intr_t;\n \n+__rte_internal\n int otx2_register_irq(struct rte_intr_handle *intr_handle,\n \t\t rte_intr_callback_fn cb, void *data, unsigned int vec);\n+__rte_internal\n void otx2_unregister_irq(struct rte_intr_handle *intr_handle,\n \t\t\t rte_intr_callback_fn cb, void *data, unsigned int vec);\n+__rte_internal\n int otx2_disable_irqs(struct rte_intr_handle *intr_handle);\n \n #endif /* _OTX2_IRQ_H_ */\ndiff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common/octeontx2/otx2_mbox.h\nindex 5351deaf2..8af8ada05 100644\n--- a/drivers/common/octeontx2/otx2_mbox.h\n+++ b/drivers/common/octeontx2/otx2_mbox.h\n@@ -1582,19 +1582,25 @@ struct tim_enable_rsp {\n \tuint32_t __otx2_io currentbucket;\n };\n \n+__rte_internal\n const char *otx2_mbox_id2name(uint16_t id);\n int otx2_mbox_id2size(uint16_t id);\n void otx2_mbox_reset(struct otx2_mbox *mbox, int devid);\n int otx2_mbox_init(struct otx2_mbox *mbox, uintptr_t hwbase, uintptr_t reg_base,\n \t\t int direction, int ndevsi, uint64_t intr_offset);\n void otx2_mbox_fini(struct otx2_mbox *mbox);\n+__rte_internal\n void otx2_mbox_msg_send(struct otx2_mbox *mbox, int devid);\n+__rte_internal\n int otx2_mbox_wait_for_rsp(struct otx2_mbox *mbox, int devid);\n int otx2_mbox_wait_for_rsp_tmo(struct otx2_mbox *mbox, int devid, uint32_t tmo);\n+__rte_internal\n int otx2_mbox_get_rsp(struct otx2_mbox *mbox, int devid, void **msg);\n+__rte_internal\n int otx2_mbox_get_rsp_tmo(struct otx2_mbox *mbox, int devid, void **msg,\n \t\t\t uint32_t tmo);\n int otx2_mbox_get_availmem(struct otx2_mbox *mbox, int devid);\n+__rte_internal\n struct mbox_msghdr *otx2_mbox_alloc_msg_rsp(struct otx2_mbox *mbox, int devid,\n \t\t\t\t\t int size, int size_rsp);\n \ndiff --git a/drivers/common/octeontx2/otx2_sec_idev.h b/drivers/common/octeontx2/otx2_sec_idev.h\nindex c681f5094..89cdaf66a 100644\n--- a/drivers/common/octeontx2/otx2_sec_idev.h\n+++ b/drivers/common/octeontx2/otx2_sec_idev.h\n@@ -22,16 +22,22 @@ struct otx2_sec_idev_cfg {\n \trte_spinlock_t tx_cpt_lock;\n };\n \n+__rte_internal\n uint8_t otx2_eth_dev_is_sec_capable(struct rte_eth_dev *eth_dev);\n \n+__rte_internal\n int otx2_sec_idev_cfg_init(int port_id);\n \n+__rte_internal\n int otx2_sec_idev_tx_cpt_qp_add(uint16_t port_id, struct otx2_cpt_qp *qp);\n \n+__rte_internal\n int otx2_sec_idev_tx_cpt_qp_remove(struct otx2_cpt_qp *qp);\n \n+__rte_internal\n int otx2_sec_idev_tx_cpt_qp_put(struct otx2_cpt_qp *qp);\n \n+__rte_internal\n int otx2_sec_idev_tx_cpt_qp_get(uint16_t port_id, struct otx2_cpt_qp **qp);\n \n #endif /* _OTX2_SEC_IDEV_H_ */\ndiff --git a/drivers/common/octeontx2/rte_common_octeontx2_version.map b/drivers/common/octeontx2/rte_common_octeontx2_version.map\nindex 01279c339..94af2ed69 100644\n--- a/drivers/common/octeontx2/rte_common_octeontx2_version.map\n+++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map\n@@ -1,4 +1,4 @@\n-DPDK_20.0 {\n+INTERNAL {\n \tglobal:\n \n \totx2_dev_active_vfs;\n@@ -30,23 +30,13 @@ DPDK_20.0 {\n \totx2_sso_pf_func_get;\n \totx2_sso_pf_func_set;\n \totx2_unregister_irq;\n-\n-\tlocal: *;\n-};\n-\n-DPDK_21 {\n-\tglobal:\n-\n \totx2_eth_dev_is_sec_capable;\n \totx2_sec_idev_cfg_init;\n \totx2_sec_idev_tx_cpt_qp_add;\n \totx2_sec_idev_tx_cpt_qp_remove;\n \totx2_sec_idev_tx_cpt_qp_get;\n \totx2_sec_idev_tx_cpt_qp_put;\n-} DPDK_20.0;\n-\n-EXPERIMENTAL {\n-\tglobal:\n-\n \totx2_logtype_ep;\n+\n+\tlocal: *;\n };\n", "prefixes": [ "1/2" ] }