Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70222/?format=api
{ "id": 70222, "url": "http://patchwork.dpdk.org/api/patches/70222/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/42ffe3a708bebeca95efff77a0f0cc6b3526a1af.1589442278.git.cloud.wangxiaoyun@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<42ffe3a708bebeca95efff77a0f0cc6b3526a1af.1589442278.git.cloud.wangxiaoyun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/42ffe3a708bebeca95efff77a0f0cc6b3526a1af.1589442278.git.cloud.wangxiaoyun@huawei.com", "date": "2020-05-14T09:29:18", "name": "[v1,3/4] net/hinic: code style modification", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "28f193a0e65d3918078b0894131c9e052cb8cc88", "submitter": { "id": 1446, "url": "http://patchwork.dpdk.org/api/people/1446/?format=api", "name": "Wangxiaoyun (Cloud)", "email": "cloud.wangxiaoyun@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/42ffe3a708bebeca95efff77a0f0cc6b3526a1af.1589442278.git.cloud.wangxiaoyun@huawei.com/mbox/", "series": [ { "id": 10058, "url": "http://patchwork.dpdk.org/api/series/10058/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10058", "date": "2020-05-14T09:29:15", "name": "fixes for queue resource free and code style", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10058/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/70222/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/70222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E60FDA00C3;\n\tThu, 14 May 2020 11:06:11 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 197431D70C;\n\tThu, 14 May 2020 11:06:03 +0200 (CEST)", "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by dpdk.org (Postfix) with ESMTP id 569361D705\n for <dev@dpdk.org>; Thu, 14 May 2020 11:06:01 +0200 (CEST)", "from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id 0BEA37B29D6D37BFA3E5;\n Thu, 14 May 2020 17:06:00 +0800 (CST)", "from tester.localdomain (10.175.119.39) by\n DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id\n 14.3.487.0; Thu, 14 May 2020 17:05:54 +0800" ], "From": "Xiaoyun wang <cloud.wangxiaoyun@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <bluca@debian.org>, <luoxianjun@huawei.com>,\n <luoxingyu@huawei.com>, <zhouguoyang@huawei.com>, <shahar.belkar@huawei.com>,\n <yin.yinshi@huawei.com>, <david.yangxiaoliang@huawei.com>,\n <zhaohui8@huawei.com>, <zhengjingzhou@huawei.com>, Xiaoyun wang\n <cloud.wangxiaoyun@huawei.com>", "Date": "Thu, 14 May 2020 17:29:18 +0800", "Message-ID": "\n <42ffe3a708bebeca95efff77a0f0cc6b3526a1af.1589442278.git.cloud.wangxiaoyun@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<cover.1589442278.git.cloud.wangxiaoyun@huawei.com>", "References": "<cover.1589442278.git.cloud.wangxiaoyun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.175.119.39]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v1 3/4] net/hinic: code style modification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The patch modifies the comments of structures or functions, and adds\nspace for comments, removes extra empty lines and adjusts the\nprint level for VF branches in one sdk interface.\n\nSigned-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>\n---\n drivers/net/hinic/base/hinic_pmd_cmdq.h | 2 +-\n drivers/net/hinic/base/hinic_pmd_hwif.c | 2 +-\n drivers/net/hinic/base/hinic_pmd_nicio.c | 1 -\n drivers/net/hinic/hinic_pmd_ethdev.c | 28 +++++++++++++---------------\n drivers/net/hinic/hinic_pmd_ethdev.h | 12 +++++++-----\n 5 files changed, 22 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/hinic/base/hinic_pmd_cmdq.h b/drivers/net/hinic/base/hinic_pmd_cmdq.h\nindex 4ce0a4c..0d5e380 100644\n--- a/drivers/net/hinic/base/hinic_pmd_cmdq.h\n+++ b/drivers/net/hinic/base/hinic_pmd_cmdq.h\n@@ -9,7 +9,7 @@\n \n #define HINIC_SCMD_DATA_LEN\t\t16\n \n-/* hiovs pmd use 64, kernel l2nic use 4096 */\n+/* pmd driver uses 64, kernel l2nic use 4096 */\n #define\tHINIC_CMDQ_DEPTH\t\t64\n \n #define\tHINIC_CMDQ_BUF_SIZE\t\t2048U\ndiff --git a/drivers/net/hinic/base/hinic_pmd_hwif.c b/drivers/net/hinic/base/hinic_pmd_hwif.c\nindex 63fba0d..4578b68 100644\n--- a/drivers/net/hinic/base/hinic_pmd_hwif.c\n+++ b/drivers/net/hinic/base/hinic_pmd_hwif.c\n@@ -99,7 +99,7 @@ void hinic_set_pf_status(struct hinic_hwif *hwif, enum hinic_pf_status status)\n \tu32 addr = HINIC_CSR_FUNC_ATTR5_ADDR;\n \n \tif (hwif->attr.func_type == TYPE_VF) {\n-\t\tPMD_DRV_LOG(ERR, \"VF doesn't support set attr5\");\n+\t\tPMD_DRV_LOG(INFO, \"VF doesn't support to set attr5\");\n \t\treturn;\n \t}\n \ndiff --git a/drivers/net/hinic/base/hinic_pmd_nicio.c b/drivers/net/hinic/base/hinic_pmd_nicio.c\nindex 60c4e14..7f7e11d 100644\n--- a/drivers/net/hinic/base/hinic_pmd_nicio.c\n+++ b/drivers/net/hinic/base/hinic_pmd_nicio.c\n@@ -369,7 +369,6 @@ static int init_rq_ctxts(struct hinic_nic_io *nic_io)\n \t\t\t\t\t HINIC_MOD_L2NIC,\n \t\t\t\t\t HINIC_UCODE_CMD_MDY_QUEUE_CONTEXT,\n \t\t\t\t\t cmd_buf, &out_param, 0);\n-\n \t\tif ((err) || out_param != 0) {\n \t\t\tPMD_DRV_LOG(ERR, \"Failed to set RQ ctxts\");\n \t\t\terr = -EFAULT;\ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex 073afa4..8634fe8 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -354,7 +354,7 @@ static int hinic_dev_configure(struct rte_eth_dev *dev)\n \t\treturn err;\n \t}\n \n-\t/*clear fdir filter flag in function table*/\n+\t/* clear fdir filter flag in function table */\n \thinic_free_fdir_filter(nic_dev);\n \n \treturn HINIC_OK;\n@@ -440,7 +440,7 @@ static int hinic_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t}\n \tnic_dev->rxqs[queue_idx] = rxq;\n \n-\t/* alloc rx sq hw wqepage*/\n+\t/* alloc rx sq hw wqe page */\n \trc = hinic_create_rq(hwdev, queue_idx, rq_depth, socket_id);\n \tif (rc) {\n \t\tPMD_DRV_LOG(ERR, \"Create rxq[%d] failed, dev_name: %s, rq_depth: %d\",\n@@ -2035,12 +2035,12 @@ static int hinic_rss_conf_get(struct rte_eth_dev *dev,\n }\n \n /**\n- * DPDK callback to update the RETA indirection table.\n+ * DPDK callback to update the RSS redirection table.\n *\n * @param dev\n * Pointer to Ethernet device structure.\n * @param reta_conf\n- * Pointer to RETA configuration structure array.\n+ * Pointer to RSS reta configuration data.\n * @param reta_size\n * Size of the RETA table.\n *\n@@ -2102,14 +2102,13 @@ static int hinic_rss_indirtbl_update(struct rte_eth_dev *dev,\n \treturn HINIC_ERROR;\n }\n \n-\n /**\n- * DPDK callback to get the RETA indirection table.\n+ * DPDK callback to get the RSS indirection table.\n *\n * @param dev\n * Pointer to Ethernet device structure.\n * @param reta_conf\n- * Pointer to RETA configuration structure array.\n+ * Pointer to RSS reta configuration data.\n * @param reta_size\n * Size of the RETA table.\n *\n@@ -2309,8 +2308,7 @@ static int hinic_dev_xstats_get_names(struct rte_eth_dev *dev,\n \tfor (i = 0; i < HINIC_VPORT_XSTATS_NUM; i++) {\n \t\tsnprintf(xstats_names[count].name,\n \t\t\t sizeof(xstats_names[count].name),\n-\t\t\t \"%s\",\n-\t\t\t hinic_vport_stats_strings[i].name);\n+\t\t\t \"%s\", hinic_vport_stats_strings[i].name);\n \t\tcount++;\n \t}\n \n@@ -2321,13 +2319,13 @@ static int hinic_dev_xstats_get_names(struct rte_eth_dev *dev,\n \tfor (i = 0; i < HINIC_PHYPORT_XSTATS_NUM; i++) {\n \t\tsnprintf(xstats_names[count].name,\n \t\t\t sizeof(xstats_names[count].name),\n-\t\t\t \"%s\",\n-\t\t\t hinic_phyport_stats_strings[i].name);\n+\t\t\t \"%s\", hinic_phyport_stats_strings[i].name);\n \t\tcount++;\n \t}\n \n \treturn count;\n }\n+\n /**\n * DPDK callback to set mac address\n *\n@@ -2492,19 +2490,19 @@ static int hinic_set_mc_addr_list(struct rte_eth_dev *dev,\n }\n \n /**\n- * DPDK callback to manage filter operations\n+ * DPDK callback to manage filter control operations\n *\n * @param dev\n * Pointer to Ethernet device structure.\n * @param filter_type\n- * Filter type.\n+ * Filter type, which just supports generic type.\n * @param filter_op\n- * Operation to perform.\n+ * Filter operation to perform.\n * @param arg\n * Pointer to operation-specific structure.\n *\n * @return\n- * 0 on success, negative errno value on failure.\n+ * 0 on success, negative error value otherwise.\n */\n static int hinic_dev_filter_ctrl(struct rte_eth_dev *dev,\n \t\t enum rte_filter_type filter_type,\ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.h b/drivers/net/hinic/hinic_pmd_ethdev.h\nindex 1cb389d..64b2c81 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.h\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.h\n@@ -53,11 +53,13 @@ struct hinic_5tuple_filter_info {\n \t * used when more than one filter matches.\n \t */\n \tuint8_t priority;\n-\tuint8_t dst_ip_mask:1, /* if mask is 1b, do not compare dst ip. */\n-\t\tsrc_ip_mask:1, /* if mask is 1b, do not compare src ip. */\n-\t\tdst_port_mask:1, /* if mask is 1b, do not compare dst port. */\n-\t\tsrc_port_mask:1, /* if mask is 1b, do not compare src port. */\n-\t\tproto_mask:1; /* if mask is 1b, do not compare protocol. */\n+\n+\t/* if mask is 1b, do not compare the response bit domain */\n+\tuint8_t dst_ip_mask:1,\n+\t\tsrc_ip_mask:1,\n+\t\tdst_port_mask:1,\n+\t\tsrc_port_mask:1,\n+\t\tproto_mask:1;\n };\n \n /* 5tuple filter structure */\n", "prefixes": [ "v1", "3/4" ] }