Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70224/?format=api
{ "id": 70224, "url": "http://patchwork.dpdk.org/api/patches/70224/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/bc14ac569b4d5191ca2cf9db3d3424481447b557.1589442278.git.cloud.wangxiaoyun@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<bc14ac569b4d5191ca2cf9db3d3424481447b557.1589442278.git.cloud.wangxiaoyun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/bc14ac569b4d5191ca2cf9db3d3424481447b557.1589442278.git.cloud.wangxiaoyun@huawei.com", "date": "2020-05-14T09:29:19", "name": "[v1,4/4] net/hinic: optimize RSS RETA table updates", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "85dc6bba2fbd852a0ad358f3d9bf7eba590250ed", "submitter": { "id": 1446, "url": "http://patchwork.dpdk.org/api/people/1446/?format=api", "name": "Wangxiaoyun (Cloud)", "email": "cloud.wangxiaoyun@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/bc14ac569b4d5191ca2cf9db3d3424481447b557.1589442278.git.cloud.wangxiaoyun@huawei.com/mbox/", "series": [ { "id": 10058, "url": "http://patchwork.dpdk.org/api/series/10058/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10058", "date": "2020-05-14T09:29:15", "name": "fixes for queue resource free and code style", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10058/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/70224/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/70224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7E509A00C3;\n\tThu, 14 May 2020 11:06:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CA8AC1D71D;\n\tThu, 14 May 2020 11:06:22 +0200 (CEST)", "from huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by dpdk.org (Postfix) with ESMTP id 873841D70A\n for <dev@dpdk.org>; Thu, 14 May 2020 11:06:20 +0200 (CEST)", "from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60])\n by Forcepoint Email with ESMTP id 1ADE931DD81C61A9C7D8;\n Thu, 14 May 2020 17:06:05 +0800 (CST)", "from tester.localdomain (10.175.119.39) by\n DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id\n 14.3.487.0; Thu, 14 May 2020 17:05:57 +0800" ], "From": "Xiaoyun wang <cloud.wangxiaoyun@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <bluca@debian.org>, <luoxianjun@huawei.com>,\n <luoxingyu@huawei.com>, <zhouguoyang@huawei.com>, <shahar.belkar@huawei.com>,\n <yin.yinshi@huawei.com>, <david.yangxiaoliang@huawei.com>,\n <zhaohui8@huawei.com>, <zhengjingzhou@huawei.com>, Xiaoyun wang\n <cloud.wangxiaoyun@huawei.com>", "Date": "Thu, 14 May 2020 17:29:19 +0800", "Message-ID": "\n <bc14ac569b4d5191ca2cf9db3d3424481447b557.1589442278.git.cloud.wangxiaoyun@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<cover.1589442278.git.cloud.wangxiaoyun@huawei.com>", "References": "<cover.1589442278.git.cloud.wangxiaoyun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.175.119.39]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v1 4/4] net/hinic: optimize RSS RETA table updates", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Before updating RSS indirection table, firstly determine whether\nrq num in RETA table is legal, if it is invalid(such as exceeding\nthe maximum rxq num), driver will not update hw indirection\ntable and return fail.\n\nSigned-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>\n---\n drivers/net/hinic/hinic_pmd_ethdev.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex 8634fe8..2f0f33a 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -2075,16 +2075,16 @@ static int hinic_rss_indirtbl_update(struct rte_eth_dev *dev,\n \tfor (i = 0; i < reta_size; i++) {\n \t\tidx = i / RTE_RETA_GROUP_SIZE;\n \t\tshift = i % RTE_RETA_GROUP_SIZE;\n-\t\tif (reta_conf[idx].mask & (1ULL << shift))\n-\t\t\tindirtbl[i] = reta_conf[idx].reta[shift];\n-\t}\n \n-\tfor (i = 0 ; i < reta_size; i++) {\n-\t\tif (indirtbl[i] >= nic_dev->num_rq) {\n-\t\t\tPMD_DRV_LOG(ERR, \"Invalid reta entry, index: %d, num_rq: %d\",\n-\t\t\t\t i, nic_dev->num_rq);\n-\t\t\tgoto disable_rss;\n+\t\tif (reta_conf[idx].reta[shift] >= nic_dev->num_rq) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Invalid reta entry, indirtbl[%d]: %d \"\n+\t\t\t\t\"exceeds the maximum rxq num: %d\", i,\n+\t\t\t\treta_conf[idx].reta[shift], nic_dev->num_rq);\n+\t\t\treturn -EINVAL;\n \t\t}\n+\n+\t\tif (reta_conf[idx].mask & (1ULL << shift))\n+\t\t\tindirtbl[i] = reta_conf[idx].reta[shift];\n \t}\n \n \terr = hinic_rss_set_indir_tbl(nic_dev->hwdev, tmpl_idx, indirtbl);\n", "prefixes": [ "v1", "4/4" ] }