Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70678/?format=api
{ "id": 70678, "url": "http://patchwork.dpdk.org/api/patches/70678/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200528083031.440282-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200528083031.440282-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200528083031.440282-1-maxime.coquelin@redhat.com", "date": "2020-05-28T08:30:31", "name": "vhost: enable reply-ack systematically", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c585c36464604e8ac33633d9cd14ba54ee62f8a8", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200528083031.440282-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 10265, "url": "http://patchwork.dpdk.org/api/series/10265/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10265", "date": "2020-05-28T08:30:31", "name": "vhost: enable reply-ack systematically", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10265/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/70678/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/70678/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB92AA00BE;\n\tThu, 28 May 2020 10:30:48 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 797E41DB4D;\n\tThu, 28 May 2020 10:30:47 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 4901B1D9DC\n for <dev@dpdk.org>; Thu, 28 May 2020 10:30:45 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-161-g6jm9aDUMteq7NepNR4K2Q-1; Thu, 28 May 2020 04:30:43 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E423D18FE879;\n Thu, 28 May 2020 08:30:41 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.21])\n by smtp.corp.redhat.com (Postfix) with ESMTP id E1AB55C1C8;\n Thu, 28 May 2020 08:30:33 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1590654644;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=tskVYVSbP3RNXkpa6krIc3R8jgKXokH0C+orWdTHnK4=;\n b=ie6D/unFZ9o+58SxVc1eC7mgLu/T+qE06WVYup4ZcRn09R07D/qzY+t7vc8kvquOPizwBK\n RuegXHwBOnGWmDcg+5ZrBwgKZqgghwuXjkPAhUcsaYFPEL9HxYzvMtbXBCjdhgxtxOuAZD\n WyZySpNOHkBs6M1PuXF5QvQgPFHEOJ8=", "X-MC-Unique": "g6jm9aDUMteq7NepNR4K2Q-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, xiaolong.ye@intel.com, amorenoz@redhat.com,\n david.marchand@redhat.com, thomas@monjalon.net", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 28 May 2020 10:30:31 +0200", "Message-Id": "<20200528083031.440282-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vhost: enable reply-ack systematically", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As announced dunring v20.05 release cycle, this\npatch makes reply-ack protocol feature to be enabled\nunconditionally.\n\nThis protocol feature makes the communication between the\nmaster and the slave more robust, avoiding for example\npossible undefined behaviour with VHOST_USER_SET_MEM_TABLE.\n\nAlso, reply-ack support will be required for upcoming\nVHOST_USER_SET_STATUS request.\n\nNote that this protocol feature was disabled by default\nbecause Qemu version 2.7.0 to 2.9.0 had a bug causing a\ndeadlock when reply-ack was negotiated and multiqueue\nenabled. These Qemu version are now very old and no more\nmaintained, so we can resonnably consider we no more\nsupport them.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 9 ---------\n 1 file changed, 9 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 84bebad792..ea9cd107b9 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -2012,15 +2012,6 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,\n \trte_vhost_driver_get_features(dev->ifname, &features);\n \trte_vhost_driver_get_protocol_features(dev->ifname, &protocol_features);\n \n-\t/*\n-\t * REPLY_ACK protocol feature is only mandatory for now\n-\t * for IOMMU feature. If IOMMU is explicitly disabled by the\n-\t * application, disable also REPLY_ACK feature for older buggy\n-\t * Qemu versions (from v2.7.0 to v2.9.0).\n-\t */\n-\tif (!(features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)))\n-\t\tprotocol_features &= ~(1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK);\n-\n \tmsg->payload.u64 = protocol_features;\n \tmsg->size = sizeof(msg->payload.u64);\n \tmsg->fd_num = 0;\n", "prefixes": [] }