Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71327/?format=api
http://patchwork.dpdk.org/api/patches/71327/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200612032410.20864-4-guinanx.sun@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200612032410.20864-4-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200612032410.20864-4-guinanx.sun@intel.com", "date": "2020-06-12T03:23:52", "name": "[03/21] net/ixgbe/base: hange flow for \"Apply Update\" command", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "406c1ec1041eb20044a6fcf957dbae16c0ed1a92", "submitter": { "id": 1476, "url": "http://patchwork.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200612032410.20864-4-guinanx.sun@intel.com/mbox/", "series": [ { "id": 10428, "url": "http://patchwork.dpdk.org/api/series/10428/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10428", "date": "2020-06-12T03:23:49", "name": "update ixgbe base code", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10428/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/71327/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/71327/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 06537A00BE;\n\tFri, 12 Jun 2020 05:46:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B7A8C1B952;\n\tFri, 12 Jun 2020 05:46:14 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 4E27058C4\n for <dev@dpdk.org>; Fri, 12 Jun 2020 05:46:09 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Jun 2020 20:46:09 -0700", "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:07 -0700" ], "IronPort-SDR": [ "\n iNuQIdc2kglOx/n9ekIXyDLROn8niAOJGa3NKG9dc7XfJB9Dw3975DCyB/z1/TQVGkwBSGlOif\n 5cAQ/FsNdKIQ==", "\n LG6eAzF9XLfVgab/zlheeIQT/o0lJi2ix7KmuJGP7ONAEFnbr4j7s19uK1je6XoZlOQ3wiR/sj\n S3gwv4DdIFrw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,501,1583222400\"; d=\"scan'208\";a=\"289759473\"", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Guinan Sun <guinanx.sun@intel.com>,\n Mateusz Kowalski <mateusz.kowalski@intel.com>", "Date": "Fri, 12 Jun 2020 03:23:52 +0000", "Message-Id": "<20200612032410.20864-4-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200612032410.20864-1-guinanx.sun@intel.com>", "References": "<20200612032410.20864-1-guinanx.sun@intel.com>", "Subject": "[dpdk-dev] [PATCH 03/21] net/ixgbe/base: hange flow for \"Apply\n\tUpdate\" command", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For the \"Apply Update\" command the firmware does not\ngiven an response. For this command, success should\nbe return. Based on information at EAS.\n\nSigned-off-by: Mateusz Kowalski <mateusz.kowalski@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 9 ++++++++-\n drivers/net/ixgbe/base/ixgbe_type.h | 12 ++++++++++++\n 2 files changed, 20 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex 9e3b71e38..89ae2b462 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -4584,11 +4584,18 @@ s32 ixgbe_hic_unlocked(struct ixgbe_hw *hw, u32 *buffer, u32 length,\n \t\tmsec_delay(1);\n \t}\n \n+\t/* For each command except \"Apply Update\" perform\n+\t * status checks in the HICR registry.\n+\t */\n+\tif ((buffer[0] & IXGBE_HOST_INTERFACE_MASK_CMD) ==\n+\t IXGBE_HOST_INTERFACE_APPLY_UPDATE_CMD)\n+\t\treturn IXGBE_SUCCESS;\n+\n \t/* Check command completion */\n \tif ((timeout && i == timeout) ||\n \t !(IXGBE_READ_REG(hw, IXGBE_HICR) & IXGBE_HICR_SV)) {\n \t\tERROR_REPORT1(IXGBE_ERROR_CAUTION,\n-\t\t\t \"Command has failed with no status valid.\\n\");\n+\t\t\t \"Command has failed with no status valid.\\n\");\n \t\treturn IXGBE_ERR_HOST_INTERFACE_COMMAND;\n \t}\n \ndiff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h\nindex 0470b1dfc..33ca659cd 100644\n--- a/drivers/net/ixgbe/base/ixgbe_type.h\n+++ b/drivers/net/ixgbe/base/ixgbe_type.h\n@@ -4366,4 +4366,16 @@ struct ixgbe_hw {\n #define IXGBE_NW_MNG_IF_SEL_MDIO_PHY_ADD\t\\\n \t\t\t\t(0x1F << IXGBE_NW_MNG_IF_SEL_MDIO_PHY_ADD_SHIFT)\n \n+/* Code Command (Flash I/F Interface) */\n+#define IXGBE_HOST_INTERFACE_FLASH_READ_CMD\t\t\t0x30\n+#define IXGBE_HOST_INTERFACE_SHADOW_RAM_READ_CMD\t\t0x31\n+#define IXGBE_HOST_INTERFACE_FLASH_WRITE_CMD\t\t\t0x32\n+#define IXGBE_HOST_INTERFACE_SHADOW_RAM_WRITE_CMD\t\t0x33\n+#define IXGBE_HOST_INTERFACE_FLASH_MODULE_UPDATE_CMD\t\t0x34\n+#define IXGBE_HOST_INTERFACE_FLASH_BLOCK_EREASE_CMD\t\t0x35\n+#define IXGBE_HOST_INTERFACE_SHADOW_RAM_DUMP_CMD\t\t0x36\n+#define IXGBE_HOST_INTERFACE_FLASH_INFO_CMD\t\t\t0x37\n+#define IXGBE_HOST_INTERFACE_APPLY_UPDATE_CMD\t\t\t0x38\n+#define IXGBE_HOST_INTERFACE_MASK_CMD\t\t\t\t0x000000FF\n+\n #endif /* _IXGBE_TYPE_H_ */\n", "prefixes": [ "03/21" ] }{ "id": 71327, "url": "