Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 71334,
    "url": "http://patchwork.dpdk.org/api/patches/71334/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200612032410.20864-11-guinanx.sun@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200612032410.20864-11-guinanx.sun@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200612032410.20864-11-guinanx.sun@intel.com",
    "date": "2020-06-12T03:23:59",
    "name": "[10/21] net/ixgbe/base: move increments after evaluations",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "bb0d58e75fd9ba8142cd543ade5ed6774b875926",
    "submitter": {
        "id": 1476,
        "url": "http://patchwork.dpdk.org/api/people/1476/?format=api",
        "name": "Guinan Sun",
        "email": "guinanx.sun@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patchwork.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200612032410.20864-11-guinanx.sun@intel.com/mbox/",
    "series": [
        {
            "id": 10428,
            "url": "http://patchwork.dpdk.org/api/series/10428/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10428",
            "date": "2020-06-12T03:23:49",
            "name": "update ixgbe base code",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/10428/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/71334/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/71334/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE548A00BE;\n\tFri, 12 Jun 2020 05:47:43 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D51F21B951;\n\tFri, 12 Jun 2020 05:46:28 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 189621BEA3\n for <dev@dpdk.org>; Fri, 12 Jun 2020 05:46:24 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Jun 2020 20:46:24 -0700",
            "from intel.sh.intel.com ([10.239.255.18])\n by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:22 -0700"
        ],
        "IronPort-SDR": [
            "\n qN6kwi+s8+lWzThACxyWp9MbnELcCwkOQKVSK73+P4GjbZ6unhKazA5lZzehXkbsUGDtUsyTlo\n M1hP4UfNW6dw==",
            "\n zF2HdKzAOR9k+Yc3XfGrOPFsK8s9bZlUDulfTbsbW9ILFFMNIhiYz6wrSi5X4O3XlEFboJoTd7\n sl1A+0js1bog=="
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.73,501,1583222400\"; d=\"scan'208\";a=\"289759540\"",
        "From": "Guinan Sun <guinanx.sun@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Guinan Sun <guinanx.sun@intel.com>,\n\tJeb Cramer <jeb.j.cramer@intel.com>",
        "Date": "Fri, 12 Jun 2020 03:23:59 +0000",
        "Message-Id": "<20200612032410.20864-11-guinanx.sun@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200612032410.20864-1-guinanx.sun@intel.com>",
        "References": "<20200612032410.20864-1-guinanx.sun@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 10/21] net/ixgbe/base: move increments after\n\tevaluations",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The retry variable was being incremented before it was evaluated by the\nsubsequent conditional against the maximum retries to figure out which\nmessage to print.  So we'll move the increment op to the end.\n\nSigned-off-by: Jeb Cramer <jeb.j.cramer@intel.com>\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_phy.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c\nindex 13f00ac67..9bb24f1ef 100644\n--- a/drivers/net/ixgbe/base/ixgbe_phy.c\n+++ b/drivers/net/ixgbe/base/ixgbe_phy.c\n@@ -138,11 +138,11 @@ s32 ixgbe_read_i2c_combined_generic_int(struct ixgbe_hw *hw, u8 addr, u16 reg,\n \t\tixgbe_i2c_bus_clear(hw);\n \t\tif (lock)\n \t\t\thw->mac.ops.release_swfw_sync(hw, swfw_mask);\n-\t\tretry++;\n \t\tif (retry < max_retry)\n \t\t\tDEBUGOUT(\"I2C byte read combined error - Retrying.\\n\");\n \t\telse\n \t\t\tDEBUGOUT(\"I2C byte read combined error.\\n\");\n+\t\tretry++;\n \t} while (retry < max_retry);\n \n \treturn IXGBE_ERR_I2C;\n@@ -203,11 +203,11 @@ s32 ixgbe_write_i2c_combined_generic_int(struct ixgbe_hw *hw, u8 addr, u16 reg,\n \t\tixgbe_i2c_bus_clear(hw);\n \t\tif (lock)\n \t\t\thw->mac.ops.release_swfw_sync(hw, swfw_mask);\n-\t\tretry++;\n \t\tif (retry < max_retry)\n \t\t\tDEBUGOUT(\"I2C byte write combined error - Retrying.\\n\");\n \t\telse\n \t\t\tDEBUGOUT(\"I2C byte write combined error.\\n\");\n+\t\tretry++;\n \t} while (retry < max_retry);\n \n \treturn IXGBE_ERR_I2C;\n@@ -2057,12 +2057,11 @@ STATIC s32 ixgbe_read_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset,\n \t\t\thw->mac.ops.release_swfw_sync(hw, swfw_mask);\n \t\t\tmsec_delay(100);\n \t\t}\n-\t\tretry++;\n \t\tif (retry < max_retry)\n \t\t\tDEBUGOUT(\"I2C byte read error - Retrying.\\n\");\n \t\telse\n \t\t\tDEBUGOUT(\"I2C byte read error.\\n\");\n-\n+\t\tretry++;\n \t} while (retry < max_retry);\n \n \treturn status;\n@@ -2161,11 +2160,11 @@ STATIC s32 ixgbe_write_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset,\n \n fail:\n \t\tixgbe_i2c_bus_clear(hw);\n-\t\tretry++;\n \t\tif (retry < max_retry)\n \t\t\tDEBUGOUT(\"I2C byte write error - Retrying.\\n\");\n \t\telse\n \t\t\tDEBUGOUT(\"I2C byte write error.\\n\");\n+\t\tretry++;\n \t} while (retry < max_retry);\n \n \tif (lock)\n",
    "prefixes": [
        "10/21"
    ]
}