Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71520/?format=api
{ "id": 71520, "url": "http://patchwork.dpdk.org/api/patches/71520/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200615004354.14380-2-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200615004354.14380-2-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200615004354.14380-2-dmitry.kozliuk@gmail.com", "date": "2020-06-15T00:43:43", "name": "[v9,01/12] eal: replace rte_page_sizes with a set of constants", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b456b0ea81cb031086cef98b7f85be2477d794de", "submitter": { "id": 1581, "url": "http://patchwork.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200615004354.14380-2-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 10455, "url": "http://patchwork.dpdk.org/api/series/10455/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10455", "date": "2020-06-15T00:43:42", "name": "Windows basic memory management", "version": 9, "mbox": "http://patchwork.dpdk.org/series/10455/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/71520/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/71520/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5C7CA0093;\n\tMon, 15 Jun 2020 02:44:17 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C51B64C8B;\n\tMon, 15 Jun 2020 02:44:17 +0200 (CEST)", "from mail-lj1-f196.google.com (mail-lj1-f196.google.com\n [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 0451449E0\n for <dev@dpdk.org>; Mon, 15 Jun 2020 02:44:03 +0200 (CEST)", "by mail-lj1-f196.google.com with SMTP id 9so17104802ljc.8\n for <dev@dpdk.org>; Sun, 14 Jun 2020 17:44:03 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id f19sm4176342lfk.24.2020.06.14.17.44.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 14 Jun 2020 17:44:02 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Wo7UMW/kz2WBu66kayDiu9sVzaczM6fJ1aGaRO7qddY=;\n b=mNGRBHZTVKaSO7Z8zG19mAiC+cezVrh10rhybkF6EcUf5cq3U05QxoYsvJi8vzFEJg\n 04veT9ZXghvSyfWHAcFh4yZHsqAPEzlF2D0q0PZ9aj4iSoaIrbPWKRupOwAoy+3I86xs\n IUiX0CcqdM+Nui/sGE9q1ua9GghuSlMJHL3rhdkXHmDRD9D1C48ljyrsGg0WL1unBXId\n xt1PthBjHDL6/DfQsHjhdjo17LSha1HMqvVxz3Stw4pn6i/pbCvq3VdKXJbMVZWhw36q\n GjyIxKNcGWCRE/0KUJ5mVX8VlEYTfH/R/QBi0cx+8gku0oBAURS8GfSofpv4Y4oFs38c\n Nplg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Wo7UMW/kz2WBu66kayDiu9sVzaczM6fJ1aGaRO7qddY=;\n b=FIgmnhW7h4PZw2w/wKvnlIr6RwKEbid56gsd9ILljBqSb5ed2xoW0ZuUC34KwjQ/g2\n UUypHXtxm0QIwIoZ278pIucAC7hSR4oGphzKxkJ2Z6MXoANwaYHH/HCKLv3ZAS3t/v4D\n pzIAdOvds4t9LhlzV15w0u3+Y1nxhn4xwj8+kJ212RCzhdEj7wZMucoiYfTudhJy4ACC\n AHkSMhfH5EkY54noBtWwMfd6F5XLdjT4NorLpmhcFGlVgbIGYFdBG9RIWtwLF2w3LNHj\n veBV6WUgpYowHmUR2ADfR+zDhzbmU2okkRjaixnAddPLc8DfWC1LI2ULAlbTJeQmM89x\n AQzQ==", "X-Gm-Message-State": "AOAM530SKwd7zkFCAH1fvtyNOBeqYCQOeZ0kQPJcVM2NxRCc109uBHUt\n Uv/wJckgRlcXneRTyEQ85O1eR93NjQsRTQ==", "X-Google-Smtp-Source": "\n ABdhPJz/Pp/mgWfj1Dv7nygQq4bVjV1KDLNCNgu2sjBw1dqhW9C2AAM0KxFsnnQ6fhD9PK2W8ch+ew==", "X-Received": "by 2002:a2e:9192:: with SMTP id\n f18mr12480885ljg.383.1592181843353;\n Sun, 14 Jun 2020 17:44:03 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Malloy <dmitrym@microsoft.com>,\n Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>,\n Fady Bader <fady@mellanox.com>, Tal Shnaiderman <talshn@mellanox.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Jerin Jacob <jerinjacobk@gmail.com>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Mon, 15 Jun 2020 03:43:43 +0300", "Message-Id": "<20200615004354.14380-2-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.4", "In-Reply-To": "<20200615004354.14380-1-dmitry.kozliuk@gmail.com>", "References": "<20200610142730.31376-1-dmitry.kozliuk@gmail.com>\n <20200615004354.14380-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 01/12] eal: replace rte_page_sizes with a set\n\tof constants", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Clang on Windows follows MS ABI where enum values are limited to 2^31-1.\nEnum rte_page_sizes has members valued above this limit, which get\nwrapped to zero, resulting in compilation error (duplicate values in\nenum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs.\n\nRemove rte_page_sizes and replace its values with #define's.\nThis enumeration is not used in public API, so there's no ABI breakage.\nAnnounce API changes for 20.08 in documentation.\n\nSuggested-by: Jerin Jacob <jerinjacobk@gmail.com>\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n doc/guides/rel_notes/release_20_08.rst | 2 ++\n lib/librte_eal/include/rte_memory.h | 23 ++++++++++-------------\n 2 files changed, 12 insertions(+), 13 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst\nindex dee4ccbb5..86d240213 100644\n--- a/doc/guides/rel_notes/release_20_08.rst\n+++ b/doc/guides/rel_notes/release_20_08.rst\n@@ -91,6 +91,8 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* ``rte_page_sizes`` enumeration is replaced with ``RTE_PGSIZE_xxx`` defines.\n+\n \n ABI Changes\n -----------\ndiff --git a/lib/librte_eal/include/rte_memory.h b/lib/librte_eal/include/rte_memory.h\nindex 3d8d0bd69..65374d53a 100644\n--- a/lib/librte_eal/include/rte_memory.h\n+++ b/lib/librte_eal/include/rte_memory.h\n@@ -24,19 +24,16 @@ extern \"C\" {\n #include <rte_config.h>\n #include <rte_fbarray.h>\n \n-__extension__\n-enum rte_page_sizes {\n-\tRTE_PGSIZE_4K = 1ULL << 12,\n-\tRTE_PGSIZE_64K = 1ULL << 16,\n-\tRTE_PGSIZE_256K = 1ULL << 18,\n-\tRTE_PGSIZE_2M = 1ULL << 21,\n-\tRTE_PGSIZE_16M = 1ULL << 24,\n-\tRTE_PGSIZE_256M = 1ULL << 28,\n-\tRTE_PGSIZE_512M = 1ULL << 29,\n-\tRTE_PGSIZE_1G = 1ULL << 30,\n-\tRTE_PGSIZE_4G = 1ULL << 32,\n-\tRTE_PGSIZE_16G = 1ULL << 34,\n-};\n+#define RTE_PGSIZE_4K (1ULL << 12)\n+#define RTE_PGSIZE_64K (1ULL << 16)\n+#define RTE_PGSIZE_256K (1ULL << 18)\n+#define RTE_PGSIZE_2M (1ULL << 21)\n+#define RTE_PGSIZE_16M (1ULL << 24)\n+#define RTE_PGSIZE_256M (1ULL << 28)\n+#define RTE_PGSIZE_512M (1ULL << 29)\n+#define RTE_PGSIZE_1G (1ULL << 30)\n+#define RTE_PGSIZE_4G (1ULL << 32)\n+#define RTE_PGSIZE_16G (1ULL << 34)\n \n #define SOCKET_ID_ANY -1 /**< Any NUMA socket. */\n \n", "prefixes": [ "v9", "01/12" ] }