Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71524/?format=api
{ "id": 71524, "url": "http://patchwork.dpdk.org/api/patches/71524/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200615004354.14380-7-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200615004354.14380-7-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200615004354.14380-7-dmitry.kozliuk@gmail.com", "date": "2020-06-15T00:43:48", "name": "[v9,06/12] trace: add size_t field emitter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7fb11701ff34517a276a8aa57f9f969431d47355", "submitter": { "id": 1581, "url": "http://patchwork.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200615004354.14380-7-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 10455, "url": "http://patchwork.dpdk.org/api/series/10455/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10455", "date": "2020-06-15T00:43:42", "name": "Windows basic memory management", "version": 9, "mbox": "http://patchwork.dpdk.org/series/10455/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/71524/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/71524/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 47BA1A0093;\n\tMon, 15 Jun 2020 02:44:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 406F61B75C;\n\tMon, 15 Jun 2020 02:44:23 +0200 (CEST)", "from mail-lj1-f195.google.com (mail-lj1-f195.google.com\n [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id B2A994C8B\n for <dev@dpdk.org>; Mon, 15 Jun 2020 02:44:09 +0200 (CEST)", "by mail-lj1-f195.google.com with SMTP id y11so17103461ljm.9\n for <dev@dpdk.org>; Sun, 14 Jun 2020 17:44:09 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id f19sm4176342lfk.24.2020.06.14.17.44.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 14 Jun 2020 17:44:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=dVcxVkYcX4IdEsRf5bHPXaga+vGMrVzMkh75QGfZRIc=;\n b=DW/G9p3NAGQx0+5PEh8TWaN4crXHzK2P6uoVLb5YZuuC4zVbhrGMm1gu4wF+rssn2a\n Ono5h9GjzL+lV1cyFc9oIwnr9NgKM4TlWVvdjvL3pP0ut+khQzFQrwiJyd1mRGRt8yUt\n LpGbjkLRXNFtMKlHBGVRPb61cWDDj9jX0JGPZLRbDpvVv5UCB+tIDbP4p69/EfB9hGVn\n YhgQh1Hwp2zDXVC2NkFaFBOd6ugDl/UscIPLb1/RFGa4XC/aBNafqMwChgjSFcugb1bG\n LNiPt1YJAvwC0z3Be/A904ovKGwFXO89pnHsirDisLtaQS94xaG7HJy8YgNRS6rX64AH\n QHaw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=dVcxVkYcX4IdEsRf5bHPXaga+vGMrVzMkh75QGfZRIc=;\n b=qLVJtZn2zfxe3mVj19D8iBn5R55ebxXb+Fndcam/7GjV9BukGDjF3Ilao+0FCXH3xS\n YQurHirWBgNKYU4d9UCnxHxZcNqEJBdb8/AUbhcpzoxMdzm0bMHl1Dg1S/WmJF0ON76M\n sA9/aHqDeSVbfFq5eGCk4a5LMCvwxRk/x99Z/wj+JfTTcGPWG4yMNCc8tFG2Py6OVWGW\n 8s85OQoWw2kvHs5CRtC4MgjQEzc5vPYG9kKMk64v+NDloWD2XIBizRr5AybjGjlsNz/0\n IG6YrxKsn7wZP5larV9Z2fsbU91YOlE5lWlq9Q9WjK5U5Yqgx6zL0YlFJ1FmAeOMEG2o\n RcEg==", "X-Gm-Message-State": "AOAM532XSymmKQsKEd9tx1Qs3Zfbvp5faIgkqv6CyedaTq0ZQoPFQTW/\n RWN5X9KwrTox/Bwd5I02OnmThKRoxwCkog==", "X-Google-Smtp-Source": "\n ABdhPJxsIUqKan5RYuGHzhCdzQmPGHo2Nv5u7z7Cjf7hJfzRNgZM5Z1d9iN+51nFMMuaUj6mP6HraA==", "X-Received": "by 2002:a2e:98c4:: with SMTP id s4mr12529568ljj.221.1592181849221;\n Sun, 14 Jun 2020 17:44:09 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Malloy <dmitrym@microsoft.com>,\n Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>,\n Fady Bader <fady@mellanox.com>, Tal Shnaiderman <talshn@mellanox.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Olivier Matz <olivier.matz@6wind.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>", "Date": "Mon, 15 Jun 2020 03:43:48 +0300", "Message-Id": "<20200615004354.14380-7-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.4", "In-Reply-To": "<20200615004354.14380-1-dmitry.kozliuk@gmail.com>", "References": "<20200610142730.31376-1-dmitry.kozliuk@gmail.com>\n <20200615004354.14380-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 06/12] trace: add size_t field emitter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows,\nsizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs.\nTracepoints using \"long\" field emitter are therefore invalid there.\nAdd dedicated field emitter for size_t and use it to store size_t values\nin all existing tracepoints.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n lib/librte_eal/include/rte_eal_trace.h | 8 ++++----\n lib/librte_eal/include/rte_trace_point.h | 3 +++\n lib/librte_mempool/rte_mempool_trace.h | 10 +++++-----\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_eal/include/rte_eal_trace.h b/lib/librte_eal/include/rte_eal_trace.h\nindex 1ebb2905a..bcfef0cfa 100644\n--- a/lib/librte_eal/include/rte_eal_trace.h\n+++ b/lib/librte_eal/include/rte_eal_trace.h\n@@ -143,7 +143,7 @@ RTE_TRACE_POINT(\n \tRTE_TRACE_POINT_ARGS(const char *type, size_t size, unsigned int align,\n \t\tint socket, void *ptr),\n \trte_trace_point_emit_string(type);\n-\trte_trace_point_emit_long(size);\n+\trte_trace_point_emit_size_t(size);\n \trte_trace_point_emit_u32(align);\n \trte_trace_point_emit_int(socket);\n \trte_trace_point_emit_ptr(ptr);\n@@ -154,7 +154,7 @@ RTE_TRACE_POINT(\n \tRTE_TRACE_POINT_ARGS(const char *type, size_t size, unsigned int align,\n \t\tint socket, void *ptr),\n \trte_trace_point_emit_string(type);\n-\trte_trace_point_emit_long(size);\n+\trte_trace_point_emit_size_t(size);\n \trte_trace_point_emit_u32(align);\n \trte_trace_point_emit_int(socket);\n \trte_trace_point_emit_ptr(ptr);\n@@ -164,7 +164,7 @@ RTE_TRACE_POINT(\n \trte_eal_trace_mem_realloc,\n \tRTE_TRACE_POINT_ARGS(size_t size, unsigned int align, int socket,\n \t\tvoid *ptr),\n-\trte_trace_point_emit_long(size);\n+\trte_trace_point_emit_size_t(size);\n \trte_trace_point_emit_u32(align);\n \trte_trace_point_emit_int(socket);\n \trte_trace_point_emit_ptr(ptr);\n@@ -183,7 +183,7 @@ RTE_TRACE_POINT(\n \t\tunsigned int flags, unsigned int align, unsigned int bound,\n \t\tconst void *mz),\n \trte_trace_point_emit_string(name);\n-\trte_trace_point_emit_long(len);\n+\trte_trace_point_emit_size_t(len);\n \trte_trace_point_emit_int(socket_id);\n \trte_trace_point_emit_u32(flags);\n \trte_trace_point_emit_u32(align);\ndiff --git a/lib/librte_eal/include/rte_trace_point.h b/lib/librte_eal/include/rte_trace_point.h\nindex b45171275..377c2414a 100644\n--- a/lib/librte_eal/include/rte_trace_point.h\n+++ b/lib/librte_eal/include/rte_trace_point.h\n@@ -138,6 +138,8 @@ _tp _args \\\n #define rte_trace_point_emit_int(val)\n /** Tracepoint function payload for long datatype */\n #define rte_trace_point_emit_long(val)\n+/** Tracepoint function payload for size_t datatype */\n+#define rte_trace_point_emit_size_t(val)\n /** Tracepoint function payload for float datatype */\n #define rte_trace_point_emit_float(val)\n /** Tracepoint function payload for double datatype */\n@@ -395,6 +397,7 @@ do { \\\n #define rte_trace_point_emit_i8(in) __rte_trace_point_emit(in, int8_t)\n #define rte_trace_point_emit_int(in) __rte_trace_point_emit(in, int32_t)\n #define rte_trace_point_emit_long(in) __rte_trace_point_emit(in, long)\n+#define rte_trace_point_emit_size_t(in) __rte_trace_point_emit(in, size_t)\n #define rte_trace_point_emit_float(in) __rte_trace_point_emit(in, float)\n #define rte_trace_point_emit_double(in) __rte_trace_point_emit(in, double)\n #define rte_trace_point_emit_ptr(in) __rte_trace_point_emit(in, uintptr_t)\ndiff --git a/lib/librte_mempool/rte_mempool_trace.h b/lib/librte_mempool/rte_mempool_trace.h\nindex e776df0a6..087c913c8 100644\n--- a/lib/librte_mempool/rte_mempool_trace.h\n+++ b/lib/librte_mempool/rte_mempool_trace.h\n@@ -72,7 +72,7 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_string(mempool->name);\n \trte_trace_point_emit_ptr(vaddr);\n \trte_trace_point_emit_u64(iova);\n-\trte_trace_point_emit_long(len);\n+\trte_trace_point_emit_size_t(len);\n \trte_trace_point_emit_ptr(free_cb);\n \trte_trace_point_emit_ptr(opaque);\n )\n@@ -84,8 +84,8 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_ptr(mempool);\n \trte_trace_point_emit_string(mempool->name);\n \trte_trace_point_emit_ptr(addr);\n-\trte_trace_point_emit_long(len);\n-\trte_trace_point_emit_long(pg_sz);\n+\trte_trace_point_emit_size_t(len);\n+\trte_trace_point_emit_size_t(pg_sz);\n \trte_trace_point_emit_ptr(free_cb);\n \trte_trace_point_emit_ptr(opaque);\n )\n@@ -126,7 +126,7 @@ RTE_TRACE_POINT(\n \tRTE_TRACE_POINT_ARGS(struct rte_mempool *mempool, size_t pg_sz),\n \trte_trace_point_emit_ptr(mempool);\n \trte_trace_point_emit_string(mempool->name);\n-\trte_trace_point_emit_long(pg_sz);\n+\trte_trace_point_emit_size_t(pg_sz);\n )\n \n RTE_TRACE_POINT(\n@@ -139,7 +139,7 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_u32(max_objs);\n \trte_trace_point_emit_ptr(vaddr);\n \trte_trace_point_emit_u64(iova);\n-\trte_trace_point_emit_long(len);\n+\trte_trace_point_emit_size_t(len);\n \trte_trace_point_emit_ptr(obj_cb);\n \trte_trace_point_emit_ptr(obj_cb_arg);\n )\n", "prefixes": [ "v9", "06/12" ] }