Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71725/?format=api
{ "id": 71725, "url": "http://patchwork.dpdk.org/api/patches/71725/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20200618135049.489773-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200618135049.489773-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200618135049.489773-2-bruce.richardson@intel.com", "date": "2020-06-18T13:50:46", "name": "[1/4] eal: remove unnecessary null-termination", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f4d829aff32eeaef66325cc1756cd91726becfbe", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200618135049.489773-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 10501, "url": "http://patchwork.dpdk.org/api/series/10501/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10501", "date": "2020-06-18T13:50:45", "name": "improve runtime loading of shared drivers", "version": 1, "mbox": "http://patchwork.dpdk.org/series/10501/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/71725/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/71725/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4B83DA04A5;\n\tThu, 18 Jun 2020 15:51:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D61CB1BF58;\n\tThu, 18 Jun 2020 15:51:06 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id CD4041BED6\n for <dev@dpdk.org>; Thu, 18 Jun 2020 15:51:04 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Jun 2020 06:51:04 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.84])\n by fmsmga006.fm.intel.com with ESMTP; 18 Jun 2020 06:51:03 -0700" ], "IronPort-SDR": [ "\n WPUZhgFv2t1fXTPob03HCzrZ/a+e9+Sd6bShZhsEhC7zTXUrVoL2xzCgSdjt/GAPKVr9x1RkDT\n sBLQ3NU+6ylg==", "\n NWs38Yrhf7bK17PZmgfoX7dARPJv/nky09z4TwF2ErE9QcOVw2qiuHxDi01jHt6YVckF06CBMM\n 4RNhL5B0Xjpg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9655\"; a=\"204065784\"", "E=Sophos;i=\"5.73,526,1583222400\"; d=\"scan'208\";a=\"204065784\"", "E=Sophos;i=\"5.73,526,1583222400\"; d=\"scan'208\";a=\"477200693\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 18 Jun 2020 14:50:46 +0100", "Message-Id": "<20200618135049.489773-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200618135049.489773-1-bruce.richardson@intel.com>", "References": "<20200618135049.489773-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/4] eal: remove unnecessary null-termination", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since strlcpy always null-terminates, and the buffer is zeroed before copy\nanyway, there is no need to explicitly zero the end of the character\narray, or to limit the bytes that strlcpy can write.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_eal/common/eal_common_options.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 8f2cbd1c6..6fbe9b5db 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -322,8 +322,7 @@ eal_plugin_add(const char *path)\n \t\treturn -1;\n \t}\n \tmemset(solib, 0, sizeof(*solib));\n-\tstrlcpy(solib->name, path, PATH_MAX-1);\n-\tsolib->name[PATH_MAX-1] = 0;\n+\tstrlcpy(solib->name, path, PATH_MAX);\n \tTAILQ_INSERT_TAIL(&solib_list, solib, next);\n \n \treturn 0;\n", "prefixes": [ "1/4" ] }