Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71745/?format=api
{ "id": 71745, "url": "http://patchwork.dpdk.org/api/patches/71745/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/675b47e1d4709df4e91d025d183fbd1c1057ee34.1592500565.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<675b47e1d4709df4e91d025d183fbd1c1057ee34.1592500565.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/675b47e1d4709df4e91d025d183fbd1c1057ee34.1592500565.git.anatoly.burakov@intel.com", "date": "2020-06-18T17:18:26", "name": "[v2,4/7] l3fwd-power: add support for requesting legacy mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3663c7af7f91ed85e1f8325c07450a5864bcf816", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/675b47e1d4709df4e91d025d183fbd1c1057ee34.1592500565.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 10507, "url": "http://patchwork.dpdk.org/api/series/10507/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10507", "date": "2020-06-18T17:18:24", "name": "Add interrupt-only mode to l3fwd-power", "version": 2, "mbox": "http://patchwork.dpdk.org/series/10507/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/71745/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/71745/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B86F3A04F1;\n\tThu, 18 Jun 2020 19:19:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D48D1BFF5;\n\tThu, 18 Jun 2020 19:18:55 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 58EF71BFB5\n for <dev@dpdk.org>; Thu, 18 Jun 2020 19:18:48 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Jun 2020 10:18:46 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.52])\n by fmsmga004.fm.intel.com with ESMTP; 18 Jun 2020 10:18:38 -0700" ], "IronPort-SDR": [ "\n PFg9O3vXi61nZxmPIfV8OC92b1836Re7+Jpi4l/ag0emZ8QB2eyDYPzg3pw04y2fBv2Ie3en0u\n 2tT1+aVzZEOg==", "\n xJIw1s+oMHW4shCLknC6XbdLfxmze/S1nPwowNg03iQ+iqXNDzfdM3U52o/5uA897ZzxTWK9b8\n spGJx9xkqHsA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9656\"; a=\"131064095\"", "E=Sophos;i=\"5.75,251,1589266800\"; d=\"scan'208\";a=\"131064095\"", "E=Sophos;i=\"5.75,251,1589266800\"; d=\"scan'208\";a=\"299768437\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "David Hunt <david.hunt@intel.com>, reshma.pattan@intel.com,\n hkalra@marvell.com, jerinjacobk@gmail.com, yinan.wang@intel.com", "Date": "Thu, 18 Jun 2020 18:18:26 +0100", "Message-Id": "\n <675b47e1d4709df4e91d025d183fbd1c1057ee34.1592500565.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1592500565.git.anatoly.burakov@intel.com>", "<cover.1592500565.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1592500565.git.anatoly.burakov@intel.com>", "<cover.1590656906.git.anatoly.burakov@intel.com>\n <cover.1592500565.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v2 4/7] l3fwd-power: add support for requesting\n\tlegacy mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, legacy mode is the implicit default, but it is not possible\nto directly request using legacy mode. Add the argument to enable\nrequesting legacy mode, and also make it the default.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n examples/l3fwd-power/main.c | 28 +++++++++++++++++++++++-----\n 1 file changed, 23 insertions(+), 5 deletions(-)", "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex c70611bb7f..c02b0a3574 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -195,7 +195,8 @@ static int parse_ptype; /**< Parse packet type using rx callback, and */\n \t\t\t/**< disabled by default */\n \n enum appmode {\n-\tAPP_MODE_LEGACY = 0,\n+\tAPP_MODE_DEFAULT = 0,\n+\tAPP_MODE_LEGACY,\n \tAPP_MODE_EMPTY_POLL,\n \tAPP_MODE_TELEMETRY\n };\n@@ -1435,6 +1436,7 @@ print_usage(const char *prgname)\n \t\t\" --enable-jumbo: enable jumbo frame\"\n \t\t\" which max packet len is PKTLEN in decimal (64-9600)\\n\"\n \t\t\" --parse-ptype: parse packet type by software\\n\"\n+\t\t\" --legacy: use legacy interrupt-based scaling\\n\"\n \t\t\" --empty-poll: enable empty poll detection\"\n \t\t\" follow (training_flag, high_threshold, med_threshold)\\n\"\n \t\t\" --telemetry: enable telemetry mode, to update\"\n@@ -1581,6 +1583,7 @@ parse_ep_config(const char *q_arg)\n \n }\n #define CMD_LINE_OPT_PARSE_PTYPE \"parse-ptype\"\n+#define CMD_LINE_OPT_LEGACY \"legacy\"\n #define CMD_LINE_OPT_EMPTY_POLL \"empty-poll\"\n #define CMD_LINE_OPT_TELEMETRY \"telemetry\"\n \n@@ -1601,6 +1604,7 @@ parse_args(int argc, char **argv)\n \t\t{\"enable-jumbo\", 0, 0, 0},\n \t\t{CMD_LINE_OPT_EMPTY_POLL, 1, 0, 0},\n \t\t{CMD_LINE_OPT_PARSE_PTYPE, 0, 0, 0},\n+\t\t{CMD_LINE_OPT_LEGACY, 0, 0, 0},\n \t\t{CMD_LINE_OPT_TELEMETRY, 0, 0, 0},\n \t\t{NULL, 0, 0, 0}\n \t};\n@@ -1673,10 +1677,21 @@ parse_args(int argc, char **argv)\n \t\t\t\tnuma_on = 0;\n \t\t\t}\n \n+\t\t\tif (!strncmp(lgopts[option_index].name,\n+\t\t\t\t\tCMD_LINE_OPT_LEGACY,\n+\t\t\t\t\tsizeof(CMD_LINE_OPT_LEGACY))) {\n+\t\t\t\tif (app_mode != APP_MODE_DEFAULT) {\n+\t\t\t\t\tprintf(\" legacy mode is mutually exclusive with other modes\\n\");\n+\t\t\t\t\treturn -1;\n+\t\t\t\t}\n+\t\t\t\tapp_mode = APP_MODE_LEGACY;\n+\t\t\t\tprintf(\"legacy mode is enabled\\n\");\n+\t\t\t}\n+\n \t\t\tif (!strncmp(lgopts[option_index].name,\n \t\t\t\t\tCMD_LINE_OPT_EMPTY_POLL, 10)) {\n-\t\t\t\tif (app_mode == APP_MODE_TELEMETRY) {\n-\t\t\t\t\tprintf(\" empty-poll cannot be enabled as telemetry mode is enabled\\n\");\n+\t\t\t\tif (app_mode != APP_MODE_DEFAULT) {\n+\t\t\t\t\tprintf(\" empty-poll mode is mutually exclusive with other modes\\n\");\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t\tapp_mode = APP_MODE_EMPTY_POLL;\n@@ -1693,8 +1708,8 @@ parse_args(int argc, char **argv)\n \t\t\tif (!strncmp(lgopts[option_index].name,\n \t\t\t\t\tCMD_LINE_OPT_TELEMETRY,\n \t\t\t\t\tsizeof(CMD_LINE_OPT_TELEMETRY))) {\n-\t\t\t\tif (app_mode == APP_MODE_EMPTY_POLL) {\n-\t\t\t\t\tprintf(\"telemetry mode cannot be enabled as empty poll mode is enabled\\n\");\n+\t\t\t\tif (app_mode != APP_MODE_DEFAULT) {\n+\t\t\t\t\tprintf(\" telemetry mode is mutually exclusive with other modes\\n\");\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t\tapp_mode = APP_MODE_TELEMETRY;\n@@ -2254,6 +2269,9 @@ main(int argc, char **argv)\n \tif (ret < 0)\n \t\trte_exit(EXIT_FAILURE, \"Invalid L3FWD parameters\\n\");\n \n+\tif (app_mode == APP_MODE_DEFAULT)\n+\t\tapp_mode = APP_MODE_LEGACY;\n+\n \t/* only legacy and empty poll mode rely on power library */\n \tif ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&\n \t\t\tinit_power_library())\n", "prefixes": [ "v2", "4/7" ] }