Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71795/?format=api
{ "id": 71795, "url": "http://patchwork.dpdk.org/api/patches/71795/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/c72faa8937f99b6c3edc94caefbf219f19fb6c14.1592563994.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<c72faa8937f99b6c3edc94caefbf219f19fb6c14.1592563994.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/c72faa8937f99b6c3edc94caefbf219f19fb6c14.1592563994.git.anatoly.burakov@intel.com", "date": "2020-06-19T10:53:49", "name": "[v3,1/7] l3fwd-power: disable interrupts by default", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bb4cc1cf36f770ca7a3f6477d00c59626a7f5807", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/c72faa8937f99b6c3edc94caefbf219f19fb6c14.1592563994.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 10521, "url": "http://patchwork.dpdk.org/api/series/10521/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10521", "date": "2020-06-19T10:53:49", "name": "Add interrupt-only mode to l3fwd-power", "version": 3, "mbox": "http://patchwork.dpdk.org/series/10521/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/71795/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/71795/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F5D1A0518;\n\tFri, 19 Jun 2020 12:54:02 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CF7751BE83;\n\tFri, 19 Jun 2020 12:54:00 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 39E7D1B9B7\n for <dev@dpdk.org>; Fri, 19 Jun 2020 12:53:58 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Jun 2020 03:53:57 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.52])\n by orsmga007.jf.intel.com with ESMTP; 19 Jun 2020 03:53:55 -0700" ], "IronPort-SDR": [ "\n h3tTqbzJfjVJhI64P040YgYqjhHoHC33vnuwIyqvlmkmXGrLw6AzpE9F8z8/dEQ4uY2ZBlAxkR\n N3otrLHHrGlA==", "\n 8pKPJ6pUX1b8dCKaueSBJsK38j+lQugsYBS5KoIPcjnmUqr8Ai5B7FoCHhnL4AkBSMVjEcYPCs\n T0d5G8TwGorg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9656\"; a=\"131318767\"", "E=Sophos;i=\"5.75,255,1589266800\"; d=\"scan'208\";a=\"131318767\"", "E=Sophos;i=\"5.75,255,1589266800\"; d=\"scan'208\";a=\"263346641\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "David Hunt <david.hunt@intel.com>, reshma.pattan@intel.com,\n hkalra@marvell.com, jerinjacobk@gmail.com, yinan.wang@intel.com", "Date": "Fri, 19 Jun 2020 11:53:49 +0100", "Message-Id": "\n <c72faa8937f99b6c3edc94caefbf219f19fb6c14.1592563994.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1592563994.git.anatoly.burakov@intel.com>", "<cover.1592563994.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1592563994.git.anatoly.burakov@intel.com>", "<cover.1592500565.git.anatoly.burakov@intel.com>\n <cover.1592563994.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v3 1/7] l3fwd-power: disable interrupts by default", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, interrupts are enabled in telemetry and empty poll modes, but\nthey are not used. Switch to disabling interrupts by default, and only\nenable interrupts for modes that require them.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nTested-by: Yinan Wang <yinan.wang@intel.com>\n---\n examples/l3fwd-power/main.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex 9db94ce044..2cc5d7b121 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -256,10 +256,7 @@ static struct rte_eth_conf port_conf = {\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\n-\t},\n-\t.intr_conf = {\n-\t\t.rxq = 1,\n-\t},\n+\t}\n };\n \n static struct rte_mempool * pktmbuf_pool[NB_SOCKETS];\n@@ -2270,6 +2267,8 @@ main(int argc, char **argv)\n \t/* initialize all ports */\n \tRTE_ETH_FOREACH_DEV(portid) {\n \t\tstruct rte_eth_conf local_port_conf = port_conf;\n+\t\t/* not all app modes need interrupts */\n+\t\tbool need_intr = app_mode == APP_MODE_LEGACY;\n \n \t\t/* skip ports that are not enabled */\n \t\tif ((enabled_port_mask & (1 << portid)) == 0) {\n@@ -2303,7 +2302,10 @@ main(int argc, char **argv)\n \t\t\tnb_rx_queue, (unsigned)n_tx_queue );\n \t\t/* If number of Rx queue is 0, no need to enable Rx interrupt */\n \t\tif (nb_rx_queue == 0)\n-\t\t\tlocal_port_conf.intr_conf.rxq = 0;\n+\t\t\tneed_intr = false;\n+\n+\t\tif (need_intr)\n+\t\t\tlocal_port_conf.intr_conf.rxq = 1;\n \n \t\tret = rte_eth_dev_info_get(portid, &dev_info);\n \t\tif (ret != 0)\n", "prefixes": [ "v3", "1/7" ] }