Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71798/?format=api
{ "id": 71798, "url": "http://patchwork.dpdk.org/api/patches/71798/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/b58810b2e6d95a38cd3f4e912f293702e1fe47ea.1592563994.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b58810b2e6d95a38cd3f4e912f293702e1fe47ea.1592563994.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b58810b2e6d95a38cd3f4e912f293702e1fe47ea.1592563994.git.anatoly.burakov@intel.com", "date": "2020-06-19T10:53:51", "name": "[v3,3/7] l3fwd-power: code style and flow fixes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "daa7948db72ca61e8a3ce849daff545cd1058fe8", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/b58810b2e6d95a38cd3f4e912f293702e1fe47ea.1592563994.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 10521, "url": "http://patchwork.dpdk.org/api/series/10521/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10521", "date": "2020-06-19T10:53:49", "name": "Add interrupt-only mode to l3fwd-power", "version": 3, "mbox": "http://patchwork.dpdk.org/series/10521/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/71798/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/71798/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB6E7A0518;\n\tFri, 19 Jun 2020 12:54:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C6C61BEB1;\n\tFri, 19 Jun 2020 12:54:06 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 4081D1BE8E\n for <dev@dpdk.org>; Fri, 19 Jun 2020 12:54:01 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Jun 2020 03:54:00 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.52])\n by orsmga007.jf.intel.com with ESMTP; 19 Jun 2020 03:53:58 -0700" ], "IronPort-SDR": [ "\n P9yutfvFzMIX85PTvX3IvX34BEZ8q/931wdRKtn2GruYgKm9/k6IaJ2sUO7wEXFTplRmQdu9Ol\n BUaKn6B2lSxQ==", "\n B255WC5WdiGzIl1bzxFVGrnv7tmQyoNGL0kLwEMRHGBS58mk9Z0Fke/n2TffzavnPTzr9H8XqF\n HC5uxsuHfFHw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9656\"; a=\"131318774\"", "E=Sophos;i=\"5.75,255,1589266800\"; d=\"scan'208\";a=\"131318774\"", "E=Sophos;i=\"5.75,255,1589266800\"; d=\"scan'208\";a=\"263347074\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "David Hunt <david.hunt@intel.com>, reshma.pattan@intel.com,\n hkalra@marvell.com, jerinjacobk@gmail.com, yinan.wang@intel.com", "Date": "Fri, 19 Jun 2020 11:53:51 +0100", "Message-Id": "\n <b58810b2e6d95a38cd3f4e912f293702e1fe47ea.1592563994.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1592563994.git.anatoly.burakov@intel.com>", "<cover.1592563994.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1592563994.git.anatoly.burakov@intel.com>", "<cover.1592500565.git.anatoly.burakov@intel.com>\n <cover.1592563994.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v3 3/7] l3fwd-power: code style and flow fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make the coding style more consistent, and the init logic control flow\nmore explicit.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n examples/l3fwd-power/main.c | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex 5cee9d5387..c70611bb7f 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -1126,7 +1126,7 @@ main_empty_poll_loop(__rte_unused void *dummy)\n }\n /* main processing loop */\n static int\n-main_loop(__rte_unused void *dummy)\n+main_legacy_loop(__rte_unused void *dummy)\n {\n \tstruct rte_mbuf *pkts_burst[MAX_PKT_BURST];\n \tunsigned lcore_id;\n@@ -1581,6 +1581,7 @@ parse_ep_config(const char *q_arg)\n \n }\n #define CMD_LINE_OPT_PARSE_PTYPE \"parse-ptype\"\n+#define CMD_LINE_OPT_EMPTY_POLL \"empty-poll\"\n #define CMD_LINE_OPT_TELEMETRY \"telemetry\"\n \n /* Parse the argument given in the command line of the application */\n@@ -1598,7 +1599,7 @@ parse_args(int argc, char **argv)\n \t\t{\"high-perf-cores\", 1, 0, 0},\n \t\t{\"no-numa\", 0, 0, 0},\n \t\t{\"enable-jumbo\", 0, 0, 0},\n-\t\t{\"empty-poll\", 1, 0, 0},\n+\t\t{CMD_LINE_OPT_EMPTY_POLL, 1, 0, 0},\n \t\t{CMD_LINE_OPT_PARSE_PTYPE, 0, 0, 0},\n \t\t{CMD_LINE_OPT_TELEMETRY, 0, 0, 0},\n \t\t{NULL, 0, 0, 0}\n@@ -1673,7 +1674,7 @@ parse_args(int argc, char **argv)\n \t\t\t}\n \n \t\t\tif (!strncmp(lgopts[option_index].name,\n-\t\t\t\t\t\t\"empty-poll\", 10)) {\n+\t\t\t\t\tCMD_LINE_OPT_EMPTY_POLL, 10)) {\n \t\t\t\tif (app_mode == APP_MODE_TELEMETRY) {\n \t\t\t\t\tprintf(\" empty-poll cannot be enabled as telemetry mode is enabled\\n\");\n \t\t\t\t\treturn -1;\n@@ -2253,7 +2254,9 @@ main(int argc, char **argv)\n \tif (ret < 0)\n \t\trte_exit(EXIT_FAILURE, \"Invalid L3FWD parameters\\n\");\n \n-\tif (app_mode != APP_MODE_TELEMETRY && init_power_library())\n+\t/* only legacy and empty poll mode rely on power library */\n+\tif ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&\n+\t\t\tinit_power_library())\n \t\trte_exit(EXIT_FAILURE, \"init_power_library failed\\n\");\n \n \tif (update_lcore_params() < 0)\n@@ -2526,12 +2529,12 @@ main(int argc, char **argv)\n \n \t/* launch per-lcore init on every lcore */\n \tif (app_mode == APP_MODE_LEGACY) {\n-\t\trte_eal_mp_remote_launch(main_loop, NULL, CALL_MASTER);\n+\t\trte_eal_mp_remote_launch(main_legacy_loop, NULL, CALL_MASTER);\n \t} else if (app_mode == APP_MODE_EMPTY_POLL) {\n \t\tempty_poll_stop = false;\n \t\trte_eal_mp_remote_launch(main_empty_poll_loop, NULL,\n \t\t\t\tSKIP_MASTER);\n-\t} else {\n+\t} else if (app_mode == APP_MODE_TELEMETRY) {\n \t\tunsigned int i;\n \n \t\t/* Init metrics library */\n@@ -2577,7 +2580,8 @@ main(int argc, char **argv)\n \tif (app_mode == APP_MODE_EMPTY_POLL)\n \t\trte_power_empty_poll_stat_free();\n \n-\tif (app_mode != APP_MODE_TELEMETRY && deinit_power_library())\n+\tif ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&\n+\t\t\tdeinit_power_library())\n \t\trte_exit(EXIT_FAILURE, \"deinit_power_library failed\\n\");\n \n \tif (rte_eal_cleanup() < 0)\n", "prefixes": [ "v3", "3/7" ] }