Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71802/?format=api
{ "id": 71802, "url": "http://patchwork.dpdk.org/api/patches/71802/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/af0d7a3360b5ff777baf520dbbc1c683b59ca3ea.1592563994.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<af0d7a3360b5ff777baf520dbbc1c683b59ca3ea.1592563994.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/af0d7a3360b5ff777baf520dbbc1c683b59ca3ea.1592563994.git.anatoly.burakov@intel.com", "date": "2020-06-19T10:53:55", "name": "[v3,7/7] l3fwd-power: add auto-selection of default mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dde790d778146064225d23d399dfa038634427b1", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/af0d7a3360b5ff777baf520dbbc1c683b59ca3ea.1592563994.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 10521, "url": "http://patchwork.dpdk.org/api/series/10521/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10521", "date": "2020-06-19T10:53:49", "name": "Add interrupt-only mode to l3fwd-power", "version": 3, "mbox": "http://patchwork.dpdk.org/series/10521/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/71802/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/71802/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 286C8A0518;\n\tFri, 19 Jun 2020 12:54:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EF74A1BEE7;\n\tFri, 19 Jun 2020 12:54:11 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 626811B9B7\n for <dev@dpdk.org>; Fri, 19 Jun 2020 12:54:08 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Jun 2020 03:54:08 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.52])\n by orsmga007.jf.intel.com with ESMTP; 19 Jun 2020 03:54:06 -0700" ], "IronPort-SDR": [ "\n Iv2vVOtrdUjXrJM/AWRznsEE2PFGSePlGZY34yrVBGuGsDUQoT1rrwo1vNw2ucEapjYnEXbSiv\n zBv4Yotm+V1Q==", "\n Y9EWuaK74sifGX8mU9JY0gj+9aZvOWDRvrVc9+hI61/q1P57L4COp3ctNPLIwLfJVDY0oiHOI/\n AL09/3tz+GWw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9656\"; a=\"131318786\"", "E=Sophos;i=\"5.75,255,1589266800\"; d=\"scan'208\";a=\"131318786\"", "E=Sophos;i=\"5.75,255,1589266800\"; d=\"scan'208\";a=\"263347993\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "David Hunt <david.hunt@intel.com>, reshma.pattan@intel.com,\n hkalra@marvell.com, jerinjacobk@gmail.com, yinan.wang@intel.com", "Date": "Fri, 19 Jun 2020 11:53:55 +0100", "Message-Id": "\n <af0d7a3360b5ff777baf520dbbc1c683b59ca3ea.1592563994.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1592563994.git.anatoly.burakov@intel.com>", "<cover.1592563994.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1592563994.git.anatoly.burakov@intel.com>", "<cover.1592500565.git.anatoly.burakov@intel.com>\n <cover.1592563994.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v3 7/7] l3fwd-power: add auto-selection of\n\tdefault mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the application does support running without the power\nlibrary being initialized, but it has to be specifically requested. On\nplatforms without support for frequency scaling using the power library,\nwe can just enable interrupt-only mode by default.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nSuggested-by: Jerin Jacob <jerinjacobk@gmail.com>\nTested-by: Harman Kalra <hkalra@marvell.com>\n---\n examples/l3fwd-power/main.c | 41 ++++++++++++++++++++++++++++++++++++-\n 1 file changed, 40 insertions(+), 1 deletion(-)", "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex 51acbfd87d..6a4a27984b 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -2412,6 +2412,42 @@ launch_timer(unsigned int lcore_id)\n \treturn 0;\n }\n \n+static int\n+autodetect_mode(void)\n+{\n+\tRTE_LOG(NOTICE, L3FWD_POWER, \"Operating mode not specified, probing frequency scaling support...\\n\");\n+\n+\t/*\n+\t * Empty poll and telemetry modes have to be specifically requested to\n+\t * be enabled, but we can auto-detect between interrupt mode with or\n+\t * without frequency scaling. Both ACPI and pstate can be used.\n+\t */\n+\tif (rte_power_check_env_supported(PM_ENV_ACPI_CPUFREQ))\n+\t\treturn APP_MODE_LEGACY;\n+\tif (rte_power_check_env_supported(PM_ENV_PSTATE_CPUFREQ))\n+\t\treturn APP_MODE_LEGACY;\n+\n+\tRTE_LOG(NOTICE, L3FWD_POWER, \"Frequency scaling not supported, selecting interrupt-only mode\\n\");\n+\n+\treturn APP_MODE_INTERRUPT;\n+}\n+\n+static const char *\n+mode_to_str(enum appmode mode)\n+{\n+\tswitch (mode) {\n+\tcase APP_MODE_LEGACY:\n+\t\treturn \"legacy\";\n+\tcase APP_MODE_EMPTY_POLL:\n+\t\treturn \"empty poll\";\n+\tcase APP_MODE_TELEMETRY:\n+\t\treturn \"telemetry\";\n+\tcase APP_MODE_INTERRUPT:\n+\t\treturn \"interrupt-only\";\n+\tdefault:\n+\t\treturn \"invalid\";\n+\t}\n+}\n \n int\n main(int argc, char **argv)\n@@ -2449,7 +2485,10 @@ main(int argc, char **argv)\n \t\trte_exit(EXIT_FAILURE, \"Invalid L3FWD parameters\\n\");\n \n \tif (app_mode == APP_MODE_DEFAULT)\n-\t\tapp_mode = APP_MODE_LEGACY;\n+\t\tapp_mode = autodetect_mode();\n+\n+\tRTE_LOG(INFO, L3FWD_POWER, \"Selected operation mode: %s\\n\",\n+\t\t\tmode_to_str(app_mode));\n \n \t/* only legacy and empty poll mode rely on power library */\n \tif ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&\n", "prefixes": [ "v3", "7/7" ] }